From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4399C433EF for ; Fri, 21 Jan 2022 21:21:43 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C2A52835A8; Fri, 21 Jan 2022 22:21:41 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="W1cv7TYy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D5465836CF; Fri, 21 Jan 2022 22:21:39 +0100 (CET) Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2DFAE830B9 for ; Fri, 21 Jan 2022 22:21:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2f.google.com with SMTP id e20so3731034qvu.7 for ; Fri, 21 Jan 2022 13:21:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QMXWjU9W3Ez7TyOLp0ylRsQN5ExFzFwWV+Rkr+9PI4U=; b=W1cv7TYyif7NeO+YkqAe3ryxou8H3d9EORekSyHkG65NqwV759LYS0VbbDV4OUjZOD drtu1c9QANt+RGbFkvjc5qlwEwH0j+aklhqhtzLTP/zePZqcW9wnhJv9Fj4hMBfPGgk2 5KJaHx0qyLmN7k4Km1FHxXaDAheX4ny/u3oTA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QMXWjU9W3Ez7TyOLp0ylRsQN5ExFzFwWV+Rkr+9PI4U=; b=gJjbuEHJWuBtNt2jENgFwLks/vy6vM3eY2bTEx8dbNI+glM6A0YUD8IV5JqIhXPS+P /tYd890bvTkjiNrT6KLxE1CQDc4SDA3BeLyKHv6gQTh5tJtSFXynfVgDijemE8rCeSwx Yi1wAv/eBkb2HoNe128oEq3DEi8RWybnP/dFzHGyUg96+UhM2aOH2N6rFxM8YAkFJK25 SbVSkc1/Efmcl1MTCxxpc5S/L421NjqdLypLEcvWi6ytagIgMRj/xNytFrH+IMkinuOq K4+OHd/qjOwloyYqRxAlH32uiZO8NboO3aCt1wDNRuXtBAUfyUDSXuAHr79gXbNzpCxC ccCQ== X-Gm-Message-State: AOAM533LmZ+Ud1nszwkSP0hCz1vYnUj7SMU54RK31iv+fC2m1dsJiGp3 GyZVc+V4zahATJqbn2k9FXSTlw== X-Google-Smtp-Source: ABdhPJx/WX0P0zOhR+1ym/IxMhddPR4xvdQorrc2kLi33Ub8niZacBJ2DZmtL7zxQPenedkf2ImqFw== X-Received: by 2002:a05:6214:e61:: with SMTP id jz1mr5708688qvb.112.1642800095987; Fri, 21 Jan 2022 13:21:35 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id l22sm3702628qtk.55.2022.01.21.13.21.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 13:21:35 -0800 (PST) Date: Fri, 21 Jan 2022 16:21:33 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , Alexandru Gagniuc , Yann Dirson , Stefan Roese , Marek =?iso-8859-1?Q?Beh=FAn?= , u-boot@lists.denx.de Subject: Re: [PATCH v2] tools: mkimage: Call verify_header after writing image to disk Message-ID: <20220121212133.GA2826984@bill-the-cat> References: <20220114173443.9877-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2fHTh5uZTiUOsy+g" Content-Disposition: inline In-Reply-To: <20220114173443.9877-1-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --2fHTh5uZTiUOsy+g Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 14, 2022 at 06:34:43PM +0100, Pali Roh=E1r wrote: > If image backend provides verify_header callback then call it after writi= ng > image to disk. This ensures that written image is correct. >=20 > Signed-off-by: Pali Roh=E1r > Reviewed-by: Stefan Roese > Reviewed-by: Simon Glass > --- > tools/mkimage.c | 41 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) This breaks a number of platforms such as ls1021atwr_sdcard_qspi and it's not clear to me why exactly. --=20 Tom --2fHTh5uZTiUOsy+g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHrI90ACgkQFHw5/5Y0 tyy5WwwAsGHio/nJhYjI6OKzLOqDCDB2nxo5glxG+bvA2BGYAJ5sy7dX0jSvml1I 7MgZCz85vAqkQC83D8EbzUbYFVjm/Xe0NUgdVRqe+vix44In+bRmVG4v1lbLZD0W DA29atxJI6G366sVIyNVGkHJpos4gY/SRQwDaibyrZju4OxaEpVECzYP6qLD3Vo8 I4chBO5/MnIrA5Ht9hFTHNfgpUioCwF+jBYJu9oIG//zUTt3JtflLPQ7yK5HKZ5o fQow4o1v2CPmVyWec34TQ2Um07u+pthCsrHQFZMTBvqpHKOQK7rzID/gRwNNwtS2 DcvyYja+qjBO2Q82feP2a1l7Pqh+QRX2RdZTFvCn11Ttv9Zy2LL/aNrPd5LVE1lk 4IKCareACCjRjOumeqt6+aM/T5N1aBGObk77xItJUhTNQPLmitNzVF2ZV/DkyDHe WuBV3/jcYy3udVofcQYn5nTiGnjlCRvV6K+2w/x98KN/z/Pm4xh8M6N/topUKgqb S5pUgKl3 =p4e9 -----END PGP SIGNATURE----- --2fHTh5uZTiUOsy+g--