From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4029C433EF for ; Sat, 22 Jan 2022 02:15:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CC5C083895; Sat, 22 Jan 2022 03:15:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="O0NrRpwa"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 40E7483895; Sat, 22 Jan 2022 03:15:51 +0100 (CET) Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1375983894 for ; Sat, 22 Jan 2022 03:15:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2f.google.com with SMTP id g11so6603483qvu.3 for ; Fri, 21 Jan 2022 18:15:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VIZ1ZMwr1i7l/STXQAcUkHtgvty47XknDsCuKOmgdcM=; b=O0NrRpwa43VajWrXgDfbyZSQReKfrCjbxuXihPAUZyaTwnK831AwgL1s/ryHVs4kgB 7ZsrEwg/ZcsohcoNDZld5xoymnJs1lKLT8ACmxcUJzABsRweW9trtN6R0tbOUZxfloHs bX2V1Fhxd2lUnpCQyCZGTpEXqXWeuPcfZG3zU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VIZ1ZMwr1i7l/STXQAcUkHtgvty47XknDsCuKOmgdcM=; b=t1P3+jolF4gmJUbqAePR91+RfLbBiIsIbSAg4eDjwkdmWKHCQNhX2yULMPkKQ5IFLj h5mWntUKFZ1NMCXalf7N+KLHOmthVxATgXxPLAkSsqd3KQDL6wj0EazlKuPylsuaPaWg ItOCLI+9Eq9PblZvPNjsHAVFyaar8OisbJkO3ohSUNNodPTfsQg7LgQTEGUHA4+rs+AU 1muT/JAnMmTMZNGO4jaEVXkH1K510VepTxgQJxuUiT1smAlwx1UJzvcocp9WFu0vWrIR FR3MGOGftGB6fw8JzMNL+83F1+yIIaAEdoZ6Z2raLaVvRgsWDYTxijnnw9e0Ow9tSakj pmMA== X-Gm-Message-State: AOAM530JY9cyOZLG4bZRL91SFSad6k1yepI1IkNzk0thGZBQSFEwr0Sp sMdSU6CjgdvVbLqGvFI8L3rnPg== X-Google-Smtp-Source: ABdhPJyDVuGPKKm4ZzhVMPJmOZYiv0hxmX9mQd3+muEbtofEImCtg6rZA7YI7R5+F1rP1NkWvPAM4w== X-Received: by 2002:a05:6214:626:: with SMTP id a6mr6302002qvx.114.1642817746831; Fri, 21 Jan 2022 18:15:46 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id b4sm3912601qkf.61.2022.01.21.18.15.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 18:15:46 -0800 (PST) Date: Fri, 21 Jan 2022 21:15:43 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , Alexandru Gagniuc , Yann Dirson , Stefan Roese , Marek =?iso-8859-1?Q?Beh=FAn?= , u-boot@lists.denx.de Subject: Re: [PATCH v2] tools: mkimage: Call verify_header after writing image to disk Message-ID: <20220122021543.GP7004@bill-the-cat> References: <20220114173443.9877-1-pali@kernel.org> <20220121212133.GA2826984@bill-the-cat> <20220122014422.4hir3y4a6ipqic42@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="azWPu1UzIEvT6cRm" Content-Disposition: inline In-Reply-To: <20220122014422.4hir3y4a6ipqic42@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --azWPu1UzIEvT6cRm Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 22, 2022 at 02:44:22AM +0100, Pali Roh=E1r wrote: > On Friday 21 January 2022 16:21:33 Tom Rini wrote: > > On Fri, Jan 14, 2022 at 06:34:43PM +0100, Pali Roh=E1r wrote: > >=20 > > > If image backend provides verify_header callback then call it after w= riting > > > image to disk. This ensures that written image is correct. > > >=20 > > > Signed-off-by: Pali Roh=E1r > > > Reviewed-by: Stefan Roese > > > Reviewed-by: Simon Glass > > > --- > > > tools/mkimage.c | 41 +++++++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 41 insertions(+) > >=20 > > This breaks a number of platforms such as ls1021atwr_sdcard_qspi and > > it's not clear to me why exactly. >=20 > Maybe they were already broken and this patch just detected it? > Or verify_header callback for particular image type is reject valid > image? >=20 > Do you have some pointers to failed build logs? Try building for ls1021atwr_sdcard_qspi with your patch applied, the only new thing that's shown in the logs is the error message. --=20 Tom --azWPu1UzIEvT6cRm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHraMwACgkQFHw5/5Y0 tyxxGQv/dq32Pq09AzX3ne4bZb1gYet67EFtXSVdsJ8jBQ4rEvT//unz4wrDLiWn io/5/LSnwhFxe1A8Ze9378vHCtfNNwYlFGdp4c594ZXwiKR6wbAraR66OqpAdx1T eg/xjqoAh3XggqMygLdw8bmT3BSIO++4sTAkeC83122A1UIBiglEjaBvUF92Glhn N50GaykaAxVLU/XWvlCOk4fK18qdMX0PSZZMVqEqF0MpjOgWlhVb3QlGSawQMpI6 Bx5DDYtP+DekPS4huOsTGyfJCn8KsAAcOT/Vm6dnzF9ynAGa7jj/akehZ6ldEeQt w/J/Cm9esW0tM/yoA9IaZ0HhpmAKJeOPlhYTXID1a7GlgurUGbv+LRbsTcCa5NWV mJwfBcmC5ix7MgQ9ifcOCfAu/J0c/7bL5FGqjQG0K2KBgiVaL+EJsM0/IxebvQq7 mW7bb5plwnMvflLaXRufhJs77E82lOqBfarTsNh2KCyXPcJIe5v2FZXiN4u0KIpT cDjiWxpi =Xrog -----END PGP SIGNATURE----- --azWPu1UzIEvT6cRm--