From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CABB3C433F5 for ; Mon, 24 Jan 2022 07:23:50 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E0F7480FAE; Mon, 24 Jan 2022 08:23:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="yqR51+GY"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8F52380FB8; Mon, 24 Jan 2022 08:23:47 +0100 (CET) Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 93FD08069D for ; Mon, 24 Jan 2022 08:23:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pj1-x1035.google.com with SMTP id nn16-20020a17090b38d000b001b56b2bce31so4940570pjb.3 for ; Sun, 23 Jan 2022 23:23:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=ppAPZvKUtQanbvfC8TeYMp4s4PdLxcIB/KDgGZIra6Q=; b=yqR51+GYfa3Qn8JlGxFBabDK+0r7wIut7JuBfaHHbPuLKzoLdlYuGJc8ZOl7y56XK8 KLZUHeISD2YbCu8zsjdvr0PTftAaoAM9l3OS4KSph3vgwms0hbmNhseJkaAgjA+/Nng3 W3yh7Dil9cbClUT5HCMSLfFgug2oMHA5LqA9RykUCx0jMPLfvjkuv3Tp0jgG5rkEFwHO m0Djnpy8inlPKgcqqH7BB44Ezhkw+mDkMzxUo3xPFHPI9JQ+UfWJyneKoLADYcZK245o sOSxlQ8HDKZnMKDyhLbKFWAj3/X5hKEjWStHwtMz9of/0DcyaH1w59qSYmzMmGbaV/Y3 5+mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=ppAPZvKUtQanbvfC8TeYMp4s4PdLxcIB/KDgGZIra6Q=; b=br6/PlAR37DZNoiuWlAtLNX1ENAz1cINGcTtTDMRl7saEk1cnUmZpZFk+XAkzx7/w8 UuYp4RQ4RL+v6U8ejzswojhIjDdeXcWOJXEHA2Xhq4re31Yo/DNz6wrhHp8xutccuzeW +Qsg5vtyDdhqsetRo1Z4r7VxV/eMZM4PFZfnSeccOUim8/GiaNvACyziyZe6h13StZzZ Kyc5lug3U0/RIl7MIjVOmM0sS8bk4kt3BGbRVc06JOF2Gj5G9BnlDcoIDsuH7D0fxrlD J5cy6kxgWZ5hGhV4hPJxyqyJgR8gFS15fYErPN5qxT1v1f7kgyGCfgQ+5DxBMHRZMqO/ LL2g== X-Gm-Message-State: AOAM533TlZXjhaIRC8exwxcDqbfUMcSDB30BDaekKv9jULEXwZm8G93A 7HA08mT6ee+KqD4qISsVBKrTmQ== X-Google-Smtp-Source: ABdhPJyazTWMJbPFb8rMu1yjDL/A/+Ewt2xHYIibP0r7PKxiHbGpns2S/Nwv5sbPopO3ZyWcVk/EgA== X-Received: by 2002:a17:90b:1b0d:: with SMTP id nu13mr701918pjb.24.1643009022921; Sun, 23 Jan 2022 23:23:42 -0800 (PST) Received: from laputa ([2400:4050:c3e1:100:db1:8b95:c482:df85]) by smtp.gmail.com with ESMTPSA id nn4sm1217025pjb.39.2022.01.23.23.23.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 23:23:42 -0800 (PST) Date: Mon, 24 Jan 2022 16:23:31 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: Simon Glass , Tom Rini , Rasmus Villemoes , Patrick Delaunay , U-Boot Mailing List Subject: Re: [PATCH 6/8] cmd: efidebug: simplify printing GUIDs Message-ID: <20220124072331.GC48616@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , Simon Glass , Tom Rini , Rasmus Villemoes , Patrick Delaunay , U-Boot Mailing List References: <20220116151441.219566-1-heinrich.schuchardt@canonical.com> <20220116151441.219566-7-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Fri, Jan 21, 2022 at 05:03:03PM +0100, Heinrich Schuchardt wrote: > On 1/21/22 16:20, Simon Glass wrote: > > Hi Heinrich, > > > > On Sun, 16 Jan 2022 at 08:14, Heinrich Schuchardt > > wrote: > > > > > > Use "%pS" to print text representations of GUIDs. > > > > > > Signed-off-by: Heinrich Schuchardt > > > --- > > > cmd/efidebug.c | 160 ++--------------------------------------- > > > include/efi_api.h | 8 +++ > > > include/efi_dt_fixup.h | 4 -- > > > include/efi_rng.h | 4 -- > > > lib/uuid.c | 116 ++++++++++++++++++++++++++++++ > > > 5 files changed, 128 insertions(+), 164 deletions(-) > > > > > > > Does this blow up the image size? These strings only in the debug side before. > > It was to avoid image size increase that I added > +#ifdef CONFIG_CMD_EFIDEBUG > > > > > Having said that, I would much rather see a string than a guid, which > > I consider to be little more than an obfuscation. > > That was my motivation. When debugging a boot failure I set DEBUG in > lib/efi_loader/efi_boottime.c and reading GUIDs in the debug output was not > helpful. But setting DEBUG in efi_boottime.c doesn't lead to CONFIG_CMD_EFIDEBUG being on in uuid.c. Do we want to have a more direct CONFIG? -Takahiro Akashi > Best regards > > Heinrich > > > > > Regards, > > Simon