From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3843CC433EF for ; Mon, 24 Jan 2022 18:08:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3F30580FD6; Mon, 24 Jan 2022 19:08:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="mS0Krwna"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7383381197; Mon, 24 Jan 2022 19:08:13 +0100 (CET) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B34D880FB8 for ; Mon, 24 Jan 2022 19:08:10 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x832.google.com with SMTP id c15so8002057qtv.1 for ; Mon, 24 Jan 2022 10:08:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=J7myk+7M7CaL34PZG6vCEDigTmxOXRaBiVc7o/NvLoc=; b=mS0Krwna5EiP0PTkERAp7qKG/vAT7gpGDvEikF3nK/lbgcdHuLmaovlFKQZaMntqsp 0ppaGzNOUqMjxqUkWFVLaTohFGgGfeGWy0cSiu4sdzFxdwcNK5Rz5DUT6kKhZJG+5boZ Cg3nzyzELVc0SfirFndVnMEQN8F3YBGZr+u+E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=J7myk+7M7CaL34PZG6vCEDigTmxOXRaBiVc7o/NvLoc=; b=uP1/DxhGbVbK7aihqcDH5PsRf3oKHohluOSFOoP1vPgYyRw/p1U5NZAV3FLs7+x8LO x14I7GwHtzlvRkWiiPLGWkQ9XOg+RLL7+8uIT+rZGbDOpBnAI/sf+5GW4B+6BkmTaid6 0kxGwTyOBIG7fskFoMXuP+/u+FGg/e+Lh5c0FL+MIjvI546E7UlXmEWxDWlYHnmPb0Ay B1gDvFTYzC3vmyq5pWwWNdne8Wzsw6wJMc0uWw7o8y8tsWSiWdWYO8nbK7SEDlLlZamx ySlKoZApT4CzeGy7SojOuSIP+iYE8Mr6MpHapk/M+/jjBFDNOqJHzT4SFHMCDsrUpfbl it8Q== X-Gm-Message-State: AOAM530P9jPt9NUnR/y9Jmguh1kHr0H2o4gXMiH1DZD5EeTvWeYSb8mS TDd8uwIR3X5Lj4BhDDTWhhZICA== X-Google-Smtp-Source: ABdhPJzs1b6Bf3ast3lpR5qNxutSa5ykMXkGO8NMaHIu6kOyuEqN/iBVqBY8iP6bvSKq/oWL7oT6+g== X-Received: by 2002:ac8:5714:: with SMTP id 20mr13493550qtw.311.1643047689587; Mon, 24 Jan 2022 10:08:09 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id j14sm8021020qkp.70.2022.01.24.10.08.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 10:08:08 -0800 (PST) Date: Mon, 24 Jan 2022 13:08:07 -0500 From: Tom Rini To: Sven Schwermer Cc: u-boot@lists.denx.de, Alexandru Gagniuc , Artem Lapkin , Ramon Fried , Simon Glass Subject: Re: [PATCH v2 1/2] cmd: source: Use script from default config Message-ID: <20220124180807.GH7515@bill-the-cat> References: <20220101184540.42491-1-sven@svenschwermer.de> <20220118132943.GA2928548@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4WCFFtl4AQpQKunj" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --4WCFFtl4AQpQKunj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 22, 2022 at 09:36:58PM +0100, Sven Schwermer wrote: > Hi Tom, >=20 > I didn't think this would result in a size increase. Could you elaborate? Alright. So for background, if you build with tools/buildman/buildman rather than just "make" directly there's some handy tools like "bloat" detection, which shows function size changes from build A to build B. Doing something like this will show the changes for pine64_plus for example export SOURCE_DATE_EPOCH=3D`date +%s` =2E/tools/buildman/buildman -o /tmp/pine64_plus -devl -SBC pine64_plus =2E/tools/buildman/buildman -o /tmp/pine64_plus -devl -SsB pine64_plus That shows in the end: aarch64: (for 1/1 boards) all +551.0 rodata +107.0 text +444.0 pine64_plus : all +551 rodata +107 text +444 u-boot: add: 2/0, grow: 0/-1 bytes: 452/-8 (444) function old new d= elta fit_find_config_node - 264 = +264 board_fit_config_name_match - 188 = +188 image_source_script 520 512 = -8 And it's that growth, over 722 configs, that I'm concerned with. --=20 Tom --4WCFFtl4AQpQKunj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHu6wMACgkQFHw5/5Y0 tyzyAAv/Uso9trjmkR3/iVRVAoWNKxPDfUG1WjOQ1ga6CVgEB1oEdlWQOEGu1hgJ 2CvjKef+achfMFHFlY+g0tQ3NWPunmmMNSjdi6V41nVopv0em71oQRb6/59YUTPd RmJZx4C5o4j1velAv/WGu6M0rCJiaj5aAoTMNL4y4z01JxJ8tX7/nHctqlLJ2Yu2 3o66o6U6UDZ26zKP2hylojRhn41AYnOp0LP5MFNOpbILeMBx6D0DLLpehUB/uQiT rK18h7+BI3uwt/d3kKbpKmdhp7C6+4ROlfSqAZ/dGAqwi+6DNO94DFcwwS15RU1B cBNUirjn+iAPUroX+hnjvsIuv432stM+spusly71iqt13Lw8ZJFh+QlMLclwpbgR 6eFCkdVDPqF6s3h/UKjyra2l2mFw2ADWuP9C9vsOkkWt8Bcvr81ab8bO2GmY5iUF bZXzdy/yhqwsGl5TIZtrQ0IURx3vok7QKm3AwI+Q6qNq8gig3tZ48i7pYO0JsH0W pGO9fNcF =QZYt -----END PGP SIGNATURE----- --4WCFFtl4AQpQKunj--