From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85DBDC433EF for ; Mon, 24 Jan 2022 21:03:11 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 564E480FE4; Mon, 24 Jan 2022 22:03:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="AfsfbNnT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A387A82A65; Mon, 24 Jan 2022 22:03:07 +0100 (CET) Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D1A7480FD6 for ; Mon, 24 Jan 2022 22:03:04 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x829.google.com with SMTP id c19so21205811qtx.3 for ; Mon, 24 Jan 2022 13:03:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fy121NIAqAZpVKfc9f2oFWLBpC0CW2rZmL5OCtkm0EA=; b=AfsfbNnTHd+FDUuUNyexPGv6Qu6jmDnNacdQ8RWQP/NbuWjH5aamEOE2y+40ZJiNAp iIzIrrjhjnz6Df1tH+Hkqy0uTAmET8Q9tnKDSm2DLBrz/ruZJZcaSCt9VvVS87F0AVi4 9UEmHzqVd4s04dHY0ckWTqGuGRFkIbLKZQfqE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fy121NIAqAZpVKfc9f2oFWLBpC0CW2rZmL5OCtkm0EA=; b=DLmXsXel/jgEg33TU9tEjer0o8IfIS6c7dFdijg5/DWMSrhJ2LE81iGc2gDXXANeop rIdForDogvEuXdhzQSU/DSQcf4sIj69cb/EfhrJPc7ZuvU09AhaKDpDILiAtU38AN5Do MRyNeEAc56MXwoLidTjf55wsjkRktxDe5dsZaQHmg5YRqKwy9mTMIoO994eIH7qjquHk Xz+dUArjzCFXvot5D2LJzLYSMK7SdCHMbPIayj3MmeCqteL7kggZ/O9c3SQqDchwdQK/ GKpxv8x+yAuLzOtTBJ2un3qgtUoxL1CuOBRWxREbfIhS5fonsYJpRMuERFyMWzup9A8f BOtw== X-Gm-Message-State: AOAM531AkE3keqeBd4961UM/0Ktm/d5Iq3i7ctRY3WT+DoZep2OgceWO jUywstnuWKteUvFRsjo0fM/gNw== X-Google-Smtp-Source: ABdhPJy6OR826iIrX/fYg+Vxi0maFox/Zo7luRefyluDOIuSTah/Hmil1abHew50xClu4ZJxN5iwXQ== X-Received: by 2002:a05:622a:1a26:: with SMTP id f38mr14281447qtb.78.1643058182955; Mon, 24 Jan 2022 13:03:02 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id w5sm4482074qko.34.2022.01.24.13.03.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 13:03:02 -0800 (PST) Date: Mon, 24 Jan 2022 16:03:00 -0500 From: Tom Rini To: Nikita Maslov Cc: u-boot@lists.denx.de Subject: Re: [PATCH] scripts: setlocalversion: remove quotes around localversion from config Message-ID: <20220124210300.GA547726@bill-the-cat> References: <40d76a4e-e888-c1ef-aa0a-af19392fd4f6@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ew6BAiZeqk4r7MaW" Content-Disposition: inline In-Reply-To: <40d76a4e-e888-c1ef-aa0a-af19392fd4f6@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --ew6BAiZeqk4r7MaW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 14, 2022 at 12:26:30AM +0300, Nikita Maslov wrote: > From: Nikita Maslov > Date: Fri, 14 Jan 2022 00:13:39 +0300 > Subject: [PATCH] scripts: setlocalversion: remove quotes around=20 > localversion from config >=20 > After replacing of include/config/auto.conf sourcing with > extraction of CONFIG_LOCALVERSION, resulting version string > contains quotes around localversion part which are always > present in auto.conf (even if localversion is empty). >=20 > This patch fixes this script so it removes quotes now. >=20 > Signed-off-by: Nikita Maslov > Cc: Philipp Tomsich > Cc: Tom Rini > Reviewed-by: Simon Glass > --- >=20 > scripts/setlocalversion | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > '=3D' '/^CONFIG_LOCALVERSION_AUTO=3D/ {print $2}' | xargs echo` > else > echo "Error: kernelrelease not valid - run 'make prepare' to=20 > update it" >&2 > exit 1 > -- >=20 > diff --git a/scripts/setlocalversion b/scripts/setlocalversion > index c1c0435267..4a63143706 100755 > --- a/scripts/setlocalversion > +++ b/scripts/setlocalversion > @@ -153,8 +153,9 @@ if test -e include/config/auto.conf; then > # We are interested only in CONFIG_LOCALVERSION and > # CONFIG_LOCALVERSION_AUTO, so extract these in a safe > # way (i.e. w/o sourcing auto.conf) > - CONFIG_LOCALVERSION=3D`cat include/config/auto.conf | awk -F '=3D= '=20 > '/^CONFIG_LOCALVERSION=3D/ {print $2}'` > - CONFIG_LOCALVERSION_AUTO=3D`cat include/config/auto.conf | awk -F= =20 > '=3D' '/^CONFIG_LOCALVERSION_AUTO=3D/ {print $2}'` > + # xargs echo removes quotes > + CONFIG_LOCALVERSION=3D`cat include/config/auto.conf | awk -F '=3D= '=20 > '/^CONFIG_LOCALVERSION=3D/ {print $2}' | xargs echo` > + CONFIG_LOCALVERSION_AUTO=3D`cat include/config/auto.conf | awk -F= =20 Can you please re-post this? The whitespace was rather badly destroyed, thanks. --=20 Tom --ew6BAiZeqk4r7MaW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHvE/0ACgkQFHw5/5Y0 tyxq0QwAnCwHOyHq1gbfwihNlnOgCGe8CaxAA4gXEfEmayOyaLN+ZRKeu68NOyA7 Ld0eWJI4nI0jMzim8hqQNzzKv6+F161ivejwvMv0KNmxoe7DNlsHP9ggOH7wRDJU Mt2IJ1uIrQIzMbaptykT+UvxFtfDZDCYymT0AXzTu1tU+hbYhGWOblodHGzHzOO5 7Tsc1TUwdrpd2XhRXecFN0y+Q0Cmxv9bh7xCsivaj23eKvZ4/OKlz+QT/EYMjYxc 4FXcNHKAwf0/Z9R7h/MkHKDLYR2aL6KMJWof+O433KL5QVAETAH8BM6422aMJu4o c384QkMpXj3J7EKZSHEyJTXK9CFZF1f278wVzNyP5HZ3AlFch1l+n88beT0Cv2b7 6W5BWTNz8KIv67cvN2jklvlMPJaDGEml7bX4IApzSEksdFZpiryNRHAEbOdhq3HB kon1K6CTW+6Zteid8doxyoitL9qlkf4tSdJY6ax520ifSRUJIh3lhg2ZkhdA5HYL XzzKSRHC =U+il -----END PGP SIGNATURE----- --ew6BAiZeqk4r7MaW--