From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03B91C433F5 for ; Tue, 25 Jan 2022 00:19:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 72CA28302D; Tue, 25 Jan 2022 01:19:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="Bks6vsrr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 78B5C83102; Tue, 25 Jan 2022 01:19:41 +0100 (CET) Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7705980636 for ; Tue, 25 Jan 2022 01:19:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pj1-x102e.google.com with SMTP id h12so18026894pjq.3 for ; Mon, 24 Jan 2022 16:19:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=9ouNoGtzSs5WbHiaRgR5jjtrpvUPjlcpGqRmRbo7S5o=; b=Bks6vsrrPF98oIriMayQerdzcHuxuahCXEIlfl+LUKQ2250CEJ1oS/WTIDb0OQn0oX LFzuzwk7zQlhM8yLW0nYZaZCnazGysUD0K6NU5tGad/BKuIQ8RwgqsyvpTEC9/mHSl5U gbaYFGMB6tPi2He6cKw8rXdkWfoOm7zDRLbupKP6Ai2dT1RxNLrfLj3LBC1vPMI8KiZ2 MrJmAOarpcinsCZ63mwEe9m7nfyENmwwF9LIuABNPhUgqAFpZ16mk4tp9JuJNoN/7xUz GDQVLMhoo4xzBE5LWUvwo9+X9LuLs9kJsFnE1fyx7ynIoZD6UBhZk15lHcBefwO5ktS2 lPTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=9ouNoGtzSs5WbHiaRgR5jjtrpvUPjlcpGqRmRbo7S5o=; b=VUiHtle3LKGXFLkqZ13YXVzBweeHdAeeINYIjKwEGcTL6Hsd7cLQGHc07g6QFuNn6A Djz2Z5YKEcMnWxGrvKgu8cXEoinq99rPyN+aByUlsuVsfI1RZGElDVtFcW23L9/wz9Hs 7Y7z5GLuu2bQbEeQ0KBxOkkE+vVHteT2oGemwInAiGYlOsw4h3pP14vdkcGRvmqrPgvk fVVgmmb0DCHjBffP7f8MvRWAK/A1keduB5fxdAVQ68RePQznvUncPnFJGc83vh0WjHYN VQ7h0LGHl9E7KGJtNcLuO2o7rkkribvXztjX7FAoo4J43bcehrNxQHLYf3JLRbKZOkqY lj+Q== X-Gm-Message-State: AOAM5327j9Ln96aFv64XTqrYSo0HniypAPZghhsSDM+I257Us02CT0VT wtVvQIa8lobXRuRkqjyYEf3Szg== X-Google-Smtp-Source: ABdhPJw61nSkhIKvfld9M0Mrfe1EGXdBO4OyL0wHa75z4jdV5Hov2J04c/lLlu2+2BZEe07/ikauEg== X-Received: by 2002:a17:902:8605:b0:149:9a25:103c with SMTP id f5-20020a170902860500b001499a25103cmr16403402plo.155.1643069976675; Mon, 24 Jan 2022 16:19:36 -0800 (PST) Received: from laputa ([2400:4050:c3e1:100:c0fe:d8ec:1255:eef8]) by smtp.gmail.com with ESMTPSA id pi1sm466260pjb.10.2022.01.24.16.19.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 16:19:36 -0800 (PST) Date: Tue, 25 Jan 2022 09:19:32 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: Simon Glass , Tom Rini , Rasmus Villemoes , Patrick Delaunay , U-Boot Mailing List Subject: Re: [PATCH 6/8] cmd: efidebug: simplify printing GUIDs Message-ID: <20220125001932.GA9031@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , Simon Glass , Tom Rini , Rasmus Villemoes , Patrick Delaunay , U-Boot Mailing List References: <20220116151441.219566-1-heinrich.schuchardt@canonical.com> <20220116151441.219566-7-heinrich.schuchardt@canonical.com> <20220124072331.GC48616@laputa> <770c7f69-af81-6123-ae69-e399d6e3e67d@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <770c7f69-af81-6123-ae69-e399d6e3e67d@gmx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Mon, Jan 24, 2022 at 09:25:34AM +0100, Heinrich Schuchardt wrote: > On 1/24/22 08:23, AKASHI Takahiro wrote: > > On Fri, Jan 21, 2022 at 05:03:03PM +0100, Heinrich Schuchardt wrote: > > > On 1/21/22 16:20, Simon Glass wrote: > > > > Hi Heinrich, > > > > > > > > On Sun, 16 Jan 2022 at 08:14, Heinrich Schuchardt > > > > wrote: > > > > > > > > > > Use "%pS" to print text representations of GUIDs. > > > > > > > > > > Signed-off-by: Heinrich Schuchardt > > > > > --- > > > > > cmd/efidebug.c | 160 ++--------------------------------------- > > > > > include/efi_api.h | 8 +++ > > > > > include/efi_dt_fixup.h | 4 -- > > > > > include/efi_rng.h | 4 -- > > > > > lib/uuid.c | 116 ++++++++++++++++++++++++++++++ > > > > > 5 files changed, 128 insertions(+), 164 deletions(-) > > > > > > > > > > > > > Does this blow up the image size? These strings only in the debug side before. > > > > > > It was to avoid image size increase that I added > > > +#ifdef CONFIG_CMD_EFIDEBUG > > > > > > > > > > > Having said that, I would much rather see a string than a guid, which > > > > I consider to be little more than an obfuscation. > > > > > > That was my motivation. When debugging a boot failure I set DEBUG in > > > lib/efi_loader/efi_boottime.c and reading GUIDs in the debug output was not > > > helpful. > > > > But setting DEBUG in efi_boottime.c doesn't lead to CONFIG_CMD_EFIDEBUG > > being on in uuid.c. Do we want to have a more direct CONFIG? > > We could use CONFIG_LOGLEVEL >= LOGL_DEBUG because once that loglevel is > set you can use the log command to log one of the EFI related functions. I'm not sure the log level is the best choice for controlling messages. Showing a human-readable GUID would also be a help in case of errors. > Overall the EFI debugging requires rethinking: I definitely agree, no specific idea though. -Takahiro Akashi > If you simply add '#define DEFINE 1' to the top of > lib/efi_loader/efi_boottime your screen will be flooded by function > calls related to timer events. Probably those high frequency events > should use LOGL_DEBUG_IO. > > Best regards > > Heinrich > > > > > -Takahiro Akashi > > > > > Best regards > > > > > > Heinrich > > > > > > > > > > > Regards, > > > > Simon >