From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6FBDFC433F5 for ; Tue, 25 Jan 2022 15:56:43 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5810183841; Tue, 25 Jan 2022 16:56:41 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="kmBK/AEC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 06BB38383D; Tue, 25 Jan 2022 16:56:39 +0100 (CET) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5A8AC83847 for ; Tue, 25 Jan 2022 16:56:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x834.google.com with SMTP id i4so9526068qtr.0 for ; Tue, 25 Jan 2022 07:56:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lC3xWlLW9yDvqB+ky6VK5DRvH1vWtxmTjBEC9PMVcRs=; b=kmBK/AECIgrc1Xg9htyw0mQNjl0iTUEWtvGjprDLcq1f/hJfspJS1nJYXWdw6U2Vdc 9U3Mz9lZdsoCTDiZ1vBz6egOQxjJHGVrFTUDxc26EfAcN+0fQh0aKJ9aQvm8jT1AMUOw HJpkEX9YrR0dd3ZYYvVZ6sKZEkgJK3itb7TrE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lC3xWlLW9yDvqB+ky6VK5DRvH1vWtxmTjBEC9PMVcRs=; b=c6FYPFCPp60n47NKL8Mev8tSMtrQGOKH8194MQc8fwWBlCOJczBFsO+SNnj8ohCLY9 R8CFrhU7jLL+gXA7ZceQTIPf3/BePyLZ1CAncGF3T2xU2Znto3zZ31b3LUYAbiwVj3oa JBuYBTdilXbU9PES7ooHP8SIIDnEwq1mNp2utVYzmj2UoAOPRJF6uaPHa7bbd+nlczI1 6TbQFSucITeCN4i3dwKKTvmJ9DwDS3Ni2G1RRk5apqiCHJsMsjq9hLF7DoLOz16+AliM 3JupOxuBQJ4/XnnkO21BX4PFADonAli9St0MuSTRkKIyxmVVMPOQ3UYfPMJM2CwIOdxb M6Og== X-Gm-Message-State: AOAM532BtKVvs9Dz3eXd1pdLbzF6ZlJea8pabOaUm+UCuVuUZXGeckEE RvlM90StpnxEOY+EesrmdnRZfg== X-Google-Smtp-Source: ABdhPJzmFbg5E1FWGRENSCtVnvVnkpWSyIGOiNeMTM0mFDKKHIHKWFQfMR6JWkKiWnYnHxbqKilLJw== X-Received: by 2002:ac8:4e47:: with SMTP id e7mr6201673qtw.98.1643126194955; Tue, 25 Jan 2022 07:56:34 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id o4sm7627434qtw.53.2022.01.25.07.56.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jan 2022 07:56:34 -0800 (PST) Date: Tue, 25 Jan 2022 10:56:32 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Heinrich Schuchardt , Marek =?iso-8859-1?Q?Beh=FAn?= , Masahiro Yamada , Pali =?iso-8859-1?Q?Roh=E1r?= Subject: Re: [PATCH 5/6] Makefile: Add a pylint checker to the build Message-ID: <20220125155632.GI7515@bill-the-cat> References: <20211122034841.304138-1-sjg@chromium.org> <20211122034841.304138-2-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FZIkiClxIZ9JeWSb" Content-Disposition: inline In-Reply-To: <20211122034841.304138-2-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --FZIkiClxIZ9JeWSb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 21, 2021 at 08:48:40PM -0700, Simon Glass wrote: > At present the Python code in U-Boot is somewhat inconsistent, with some > files passing pylint quite cleanly and others not. >=20 > Add a way to track progress on this clean-up, by checking that no module > has got any worse as a result of changes. >=20 > This can be used with 'make pylint'. >=20 > Signed-off-by: Simon Glass > --- >=20 > .gitignore | 4 + > Makefile | 45 +++++++- > doc/develop/index.rst | 8 ++ > doc/develop/python_cq.rst | 80 +++++++++++++++ > scripts/pylint.base | 211 ++++++++++++++++++++++++++++++++++++++ > 5 files changed, 347 insertions(+), 1 deletion(-) > create mode 100644 doc/develop/python_cq.rst > create mode 100644 scripts/pylint.base So, I'm applying this momentarily. But given the discussion at the time, I wanted to follow up as well with some commentary. The scoring mechanism is not perfect and I'm not applying the final part of this to enable CI yet. In terms of minimum score? I don't know how that would work, setting aside problems like removing code leads to a possibly worse ratio. Maybe we need to get some people listed under MAINTAINERS for python code? I'll be putting pylint in my local testing loop and that'll at least make me question regressions but arbitrarily taking "binman.fdt_test 3.23" I can't see what on earth is even related to that score since there's nothing useful to me under "git grep fdt_test tools/". But overall I think this at least starts us down the right track of making it easier to make our python code more generally python compliant. --=20 Tom --FZIkiClxIZ9JeWSb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHwHa0ACgkQFHw5/5Y0 tyx8AQv/ZNHI6mhq4A/05ogrhk9TVBVZkN/1qpaX36jtNVkGwm4ZJ/NHWD2x9XQ/ jQWAufqmf7neZmfF13l4DR25J9pNSz5Kaq41uN+E5GzYYPgYejqYKRhCsgyBigF/ OtnzmN74WbbVXfesGnBdGlrHXolYFDuzc4SnNr/dbGey9hQXnRA5Sd0fkjD3kZ7M DaO2tiGQDzRuIEgvFYs6YFZpym+BEvEatdBF2GrPX5p0/eev//1oJY/gJ3GnaHRq 6otlH6JBCEbQAjdqut+9choA6/prwrQ7xyowMWR79yixgt+z4G8y2Y4MyBodsdoK hGR2fFNrwuVFOeYd0hFsiEqZB7DA+PGPOGsav4FquGOSUH7fQ7d3EYUC4yg4rHf8 aaKf4+PDzsN3Ei3N9cTangg9ZrN+xc96fKkWRlAJirohjUNVEEo+ynOZWeTzRcGU YfpuznzRt+ThGOTTNsIbXjd7qe5aq8/fkv4ZcxHMp+xjYHaXjo9cFJ/nuuIBWNhs mDM5Dpp6 =iyMZ -----END PGP SIGNATURE----- --FZIkiClxIZ9JeWSb--