From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCF4DC433EF for ; Tue, 25 Jan 2022 15:59:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C64C483911; Tue, 25 Jan 2022 16:58:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="uvy6CxmE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0DEF883911; Tue, 25 Jan 2022 16:58:21 +0100 (CET) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4928B83903 for ; Tue, 25 Jan 2022 16:58:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x831.google.com with SMTP id w6so24055404qtk.4 for ; Tue, 25 Jan 2022 07:58:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=e+K52nbZ3EViYRO8kwOZ9a9IiObKvfKLBfBL1LH/aH0=; b=uvy6CxmENsJUuqdk8B3U0cUVrrauYhXuPvwfsIdBZ/4tzu4Jl8qrLRSt5Jjz7P+c8m M8oRzS4ajmDhGBr3qMnSg6UlEWa24EY58yDmQZLjzX4WmP3Pvq7dyor/MQscvFfvYzzl lHQHT9Sh+kMTOPlg0VXoVFhpDxVFf/exCoJA4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e+K52nbZ3EViYRO8kwOZ9a9IiObKvfKLBfBL1LH/aH0=; b=BREYs5xlFIju/q0NDCVUJ9EKiv8lE96ChS8fXdZAAanoyfCR4VedNg2phMlJsrB8Em XJwjeCxUs8EwPYipqtMwwm7nnWp0PWnvd8CQW6l+Bta3XiWLcXQnQq9krykq1wCFqX5J Izj3U4REbY+exgkfCYz0dG9SunNXhy/Pyi6w0sM0Eio8FNTk6CS1tmmpYNKmFXMZh9Io B3r/lnR2wawSX3DolczlsiY9A2aAapgb0jiEFZuvlTaShaYi6Apy/TontF55FxTluw4l CNy8AfeZfLUylWK1hTXOYhUytBRMl13wR8lvnDV8WuHBvPz98/GZrITPYJ8Chi4YhbJ4 BC2Q== X-Gm-Message-State: AOAM531LLNhrnXWiO8uH5y00/euSfG4ljWrU/pLlA5MAswMmlf1aOuLG 8mQs9zuAwendEQA3vS9q6vCpWw== X-Google-Smtp-Source: ABdhPJwL96gV1WfIRF8COEXS1hBvQKqNsh6yNfVrKBm6D65l9yY4nO5SVXz3FaSszSkYmKAKeUF4yw== X-Received: by 2002:a05:622a:14f:: with SMTP id v15mr2070874qtw.321.1643126297176; Tue, 25 Jan 2022 07:58:17 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id c127sm8938846qkf.36.2022.01.25.07.58.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jan 2022 07:58:16 -0800 (PST) Date: Tue, 25 Jan 2022 10:58:14 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Heinrich Schuchardt , Masahiro Yamada , Trevor Woerner Subject: Re: [PATCH 5/6] moveconfig: Use a function to read files Message-ID: <20220125155814.GY7515@bill-the-cat> References: <20211218215435.1159723-1-sjg@chromium.org> <20211218215435.1159723-6-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VSJGZE3ajDCqFLUt" Content-Disposition: inline In-Reply-To: <20211218215435.1159723-6-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --VSJGZE3ajDCqFLUt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 18, 2021 at 02:54:34PM -0700, Simon Glass wrote: > At present there is quite a bit of ad-hoc code reading from files. The > most common case is to read the file as lines. Put it in a function and > set the unicode encoding correctly. >=20 > Avoid writing back to a file when there are obviously no changes as this > speeds things up slightly. >=20 > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! --=20 Tom --VSJGZE3ajDCqFLUt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHwHhYACgkQFHw5/5Y0 tyzOpAv/fx9fkgI4Sl8zg37hYEH89fKIgwFUt3hui44GBJgJjFba+uldb8kXab9C 6s8DPGDcTS8z/FFvwsIEfgsjqpHUBrNk9zgFpmm0Ikj8Z25MBHV/ltzrxmd4M+wf +NF0Km3RVMHoXdpTELovLAJPjAYuMl8admm/ois7eKjv0clePAw0PQYb1Sr2FOqF tMm7/mbGW0OZqHySWQ2psn4/sBG7HZBc5SPsWSz1yXC7jCpRlJ4ukMPvwlaAYEMF Auae0nzPhMTWNpVKWKmNfOC22BWy0hMEYi09RI0tIF16PgshW5UxNON5rGmK0QQ4 BHMv7761deU7vUv+oVDkW83eR+Fdiardd83UsqAWiZJUn0nFdWIuMdVAxv36n1pi 9+bCg1JR4GoIyiw4XTjJtTeWyHERQ9H1HWJ1JU6kQL0cwjy9KPL5EciZTXXjrosl 8KxBim4l9MGEwm+NhLPUIWeXhNlhSa+Mk0IGeMPaC1lf11U6K6xHmJmpxVNU1N1R 4y1ANO4F =f7/b -----END PGP SIGNATURE----- --VSJGZE3ajDCqFLUt--