Re: [PATCH u-boot-marvell 13/14] tools: kwboot: Fix usage of -D without -t

Stefan Roese
2022-01-26T15:46:06Z

On 1/25/22 18:13, Marek Behún wrote:
> From: Pali Rohár <pali@kernel.org>
>
> When -D is specified then both bootmsg and debugmsg are not set, but
> imgpath is set. Fix this check for valid and required parameters.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
> tools/kwboot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/kwboot.c b/tools/kwboot.c
> index fca1c73c55..859559fb72 100644
> --- a/tools/kwboot.c
> +++ b/tools/kwboot.c
> @@ -1819,7 +1819,7 @@ main(int argc, char **argv)
> }
> } while (1);
>
> - if (!bootmsg && !term && !debugmsg)
> + if (!bootmsg && !term && !debugmsg && !imgpath)
> goto usage;
>
> ttypath = argv[optind++];

Viele Grüße,
Stefan Roese

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de