Re: [PATCH u-boot-marvell 10/14] tools: kwboot: Remove 2s delay before sending first xmodem packet

Stefan Roese
2022-01-26T15:46:17Z

On 1/25/22 18:13, Marek Behún wrote:
> From: Pali Rohár <pali@kernel.org>
>
> This delay is not needed anymore since kwboot already handles retrying
> logic for incomplete xmodem packets and also forces BootROM to flush its
> input queue. Removing it decreases total transfer time.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
> tools/kwboot.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/tools/kwboot.c b/tools/kwboot.c
> index 824ae005b2..de433c1b04 100644
> --- a/tools/kwboot.c
> +++ b/tools/kwboot.c
> @@ -1142,10 +1142,6 @@ kwboot_xmodem(int tty, const void *_img, size_t size, int baudrate)
> */
> hdrsz += (KWBOOT_XM_BLKSZ - hdrsz % KWBOOT_XM_BLKSZ) % KWBOOT_XM_BLKSZ;
>
> - kwboot_printv("Waiting %d ms and flushing tty\n", blk_rsp_timeo);
> - usleep(blk_rsp_timeo * 1000);
> - tcflush(tty, TCIOFLUSH);
> -
> pnum = 1;
>
> rc = kwboot_xmodem_one(tty, &pnum, 1, img, hdrsz, baudrate);

Viele Grüße,
Stefan Roese

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de