Re: [PATCH u-boot-marvell 01/14] tools: kwboot: Increase blk_rsp_timeo to 2s

Stefan Roese
2022-01-26T15:34:11Z

On 1/25/22 18:13, Marek Behún wrote:
> From: Pali Rohár <pali@kernel.org>
>
> Fix xmodem retry mechanism if some bytes from xmodem packet were lost and
> BootROM is still waiting for completing previous xmodem packet.
>
> It is required to wait at least 1.312s on A385, otherwise BootROM does not
> accept next xmodem packet if previous one was not completely transferred.
>
> 2s should be enough timeout cause that BootROM will drop incomplete xmodem
> packet and expects new packet.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
> tools/kwboot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/kwboot.c b/tools/kwboot.c
> index c3d8ab6544..82cfd9a827 100644
> --- a/tools/kwboot.c
> +++ b/tools/kwboot.c
> @@ -75,7 +75,7 @@ struct kwboot_block {
> uint8_t csum;
> } __packed;
>
> -#define KWBOOT_BLK_RSP_TIMEO 1000 /* ms */
> +#define KWBOOT_BLK_RSP_TIMEO 2000 /* ms */
> #define KWBOOT_HDR_RSP_TIMEO 10000 /* ms */
>
> /* ARM code to change baudrate */

Viele Grüße,
Stefan Roese

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de