From: Anup Patel <apatel@ventanamicro.com>
To: Rick Chen <rick@andestech.com>, Bin Meng <bmeng.cn@gmail.com>
Cc: Atish Patra <atishp@atishpatra.org>,
Alistair Francis <Alistair.Francis@wdc.com>,
Anup Patel <anup@brainfault.org>,
U-Boot Mailing List <u-boot@lists.denx.de>,
Anup Patel <apatel@ventanamicro.com>
Subject: [PATCH v2 3/4] riscv: qemu: Implement is_flash_available() for MTD NOR
Date: Thu, 27 Jan 2022 11:41:09 +0530 [thread overview]
Message-ID: <20220127061110.721103-4-apatel@ventanamicro.com> (raw)
In-Reply-To: <20220127061110.721103-1-apatel@ventanamicro.com>
Currently, if MTD NOR is enabled then U-Boot tries to issue flash
commands even when CFI flash DT node is not present. This causes
access fault on RISC-V emulators or ISS which do not emulate CFI
flash. To handle this issue, we implement is_flash_available() for
qemu-riscv board which will return 1 only if CFI flash DT node is
present.
Fixes: d248627f9d42 ("riscv: qemu: Enable MTD NOR flash support")
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
Reviewed-by: Rick Chen <rick@andestech.com>
---
board/emulation/qemu-riscv/qemu-riscv.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/board/emulation/qemu-riscv/qemu-riscv.c b/board/emulation/qemu-riscv/qemu-riscv.c
index b0d9dd59b1..ae3b7a3295 100644
--- a/board/emulation/qemu-riscv/qemu-riscv.c
+++ b/board/emulation/qemu-riscv/qemu-riscv.c
@@ -5,6 +5,7 @@
#include <common.h>
#include <dm.h>
+#include <dm/ofnode.h>
#include <env.h>
#include <fdtdec.h>
#include <image.h>
@@ -16,6 +17,17 @@
DECLARE_GLOBAL_DATA_PTR;
+#if IS_ENABLED(CONFIG_MTD_NOR_FLASH)
+int is_flash_available(void)
+{
+ if (!ofnode_equal(ofnode_by_compatible(ofnode_null(), "cfi-flash"),
+ ofnode_null()))
+ return 1;
+
+ return 0;
+}
+#endif
+
int board_init(void)
{
/*
--
2.25.1
next prev parent reply other threads:[~2022-01-27 6:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 6:11 [PATCH v2 0/4] QEMU spike machine support for U-Boot Anup Patel
2022-01-27 6:11 ` [PATCH v2 1/4] serial: Add RISC-V HTIF console driver Anup Patel
2022-01-28 14:13 ` Bin Meng
2022-01-27 6:11 ` [PATCH v2 2/4] riscv: qemu: Enable HTIF console support Anup Patel
2022-01-28 12:36 ` Bin Meng
2022-01-27 6:11 ` Anup Patel [this message]
2022-01-28 7:31 ` [PATCH v2 3/4] riscv: qemu: Implement is_flash_available() for MTD NOR Bin Meng
2022-02-06 10:00 ` Heinrich Schuchardt
2022-01-27 6:11 ` [PATCH v2 4/4] doc: qemu-riscv: Update documentation for QEMU spike machine Anup Patel
2022-01-28 7:18 ` Bin Meng
2022-02-06 8:40 ` [PATCH v2 0/4] QEMU spike machine support for U-Boot Anup Patel
[not found] ` <HK0PR03MB2994AD37D80D204D94463A57C12C9@HK0PR03MB2994.apcprd03.prod.outlook.com>
2022-02-07 6:10 ` Rick Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220127061110.721103-4-apatel@ventanamicro.com \
--to=apatel@ventanamicro.com \
--cc=Alistair.Francis@wdc.com \
--cc=anup@brainfault.org \
--cc=atishp@atishpatra.org \
--cc=bmeng.cn@gmail.com \
--cc=rick@andestech.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox