* [PATCH 1/2] imx: imx8mm_beacon: Remove redundant code
@ 2022-01-27 21:10 Adam Ford
2022-01-27 21:10 ` [PATCH 2/2] imx: imx8mn_beacon: " Adam Ford
2022-02-05 16:41 ` [PATCH 1/2] imx: imx8mm_beacon: " sbabic
0 siblings, 2 replies; 4+ messages in thread
From: Adam Ford @ 2022-01-27 21:10 UTC (permalink / raw)
To: u-boot; +Cc: aford173, trini, sbabic, aford
The function to return the default MMC device for the environment
already has a __weak instance doing exactly the same thing. Remove
the superfluous one.
Signed-off-by: Adam Ford <aford173@gmail.com>
diff --git a/board/beacon/imx8mm/imx8mm_beacon.c b/board/beacon/imx8mm/imx8mm_beacon.c
index 87ffebb571..c228bbf777 100644
--- a/board/beacon/imx8mm/imx8mm_beacon.c
+++ b/board/beacon/imx8mm/imx8mm_beacon.c
@@ -50,8 +50,3 @@ int board_init(void)
return 0;
}
-
-int board_mmc_get_env_dev(int devno)
-{
- return devno;
-}
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] imx: imx8mn_beacon: Remove redundant code
2022-01-27 21:10 [PATCH 1/2] imx: imx8mm_beacon: Remove redundant code Adam Ford
@ 2022-01-27 21:10 ` Adam Ford
2022-02-05 16:39 ` sbabic
2022-02-05 16:41 ` [PATCH 1/2] imx: imx8mm_beacon: " sbabic
1 sibling, 1 reply; 4+ messages in thread
From: Adam Ford @ 2022-01-27 21:10 UTC (permalink / raw)
To: u-boot; +Cc: aford173, trini, sbabic, aford
The function to return the default MMC device for the environment
already has a __weak instance doing exactly the same thing. Remove
the superfluous one.
Signed-off-by: Adam Ford <aford173@gmail.com>
diff --git a/board/beacon/imx8mn/imx8mn_beacon.c b/board/beacon/imx8mn/imx8mn_beacon.c
index 7fe252b262..6397dac872 100644
--- a/board/beacon/imx8mn/imx8mn_beacon.c
+++ b/board/beacon/imx8mn/imx8mn_beacon.c
@@ -50,8 +50,3 @@ int board_init(void)
return 0;
}
-
-int board_mmc_get_env_dev(int devno)
-{
- return CONFIG_SYS_MMC_ENV_DEV;
-}
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] imx: imx8mn_beacon: Remove redundant code
2022-01-27 21:10 ` [PATCH 2/2] imx: imx8mn_beacon: " Adam Ford
@ 2022-02-05 16:39 ` sbabic
0 siblings, 0 replies; 4+ messages in thread
From: sbabic @ 2022-02-05 16:39 UTC (permalink / raw)
To: Adam Ford, u-boot
> The function to return the default MMC device for the environment
> already has a __weak instance doing exactly the same thing. Remove
> the superfluous one.
> Signed-off-by: Adam Ford <aford173@gmail.com>
> diff --git a/board/beacon/imx8mn/imx8mn_beacon.c b/board/beacon/imx8mn/imx8mn_beacon.c
> index 7fe252b262..6397dac872 100644
> --- a/board/beacon/imx8mn/imx8mn_beacon.c
> +++ b/board/beacon/imx8mn/imx8mn_beacon.c
> @@ -50,8 +50,3 @@ int board_init(void)
>
> return 0;
> }
> -
> -int board_mmc_get_env_dev(int devno)
> -{
> - return CONFIG_SYS_MMC_ENV_DEV;
> -}
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] imx: imx8mm_beacon: Remove redundant code
2022-01-27 21:10 [PATCH 1/2] imx: imx8mm_beacon: Remove redundant code Adam Ford
2022-01-27 21:10 ` [PATCH 2/2] imx: imx8mn_beacon: " Adam Ford
@ 2022-02-05 16:41 ` sbabic
1 sibling, 0 replies; 4+ messages in thread
From: sbabic @ 2022-02-05 16:41 UTC (permalink / raw)
To: Adam Ford, u-boot
> The function to return the default MMC device for the environment
> already has a __weak instance doing exactly the same thing. Remove
> the superfluous one.
> Signed-off-by: Adam Ford <aford173@gmail.com>
> diff --git a/board/beacon/imx8mm/imx8mm_beacon.c b/board/beacon/imx8mm/imx8mm_beacon.c
> index 87ffebb571..c228bbf777 100644
> --- a/board/beacon/imx8mm/imx8mm_beacon.c
> +++ b/board/beacon/imx8mm/imx8mm_beacon.c
> @@ -50,8 +50,3 @@ int board_init(void)
>
> return 0;
> }
> -
> -int board_mmc_get_env_dev(int devno)
> -{
> - return devno;
> -}
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-05 16:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-27 21:10 [PATCH 1/2] imx: imx8mm_beacon: Remove redundant code Adam Ford
2022-01-27 21:10 ` [PATCH 2/2] imx: imx8mn_beacon: " Adam Ford
2022-02-05 16:39 ` sbabic
2022-02-05 16:41 ` [PATCH 1/2] imx: imx8mm_beacon: " sbabic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox