From: Tom Rini <trini@konsulko.com>
To: Samuel Dionne-Riel <samuel@dionne-riel.com>,
Simon Glass <sjg@chromium.org>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH 1/4] drivers: Introduce vibrator uclass
Date: Fri, 28 Jan 2022 17:39:07 -0500 [thread overview]
Message-ID: <20220128223907.GA3875575@bill-the-cat> (raw)
In-Reply-To: <20211222223607.3734687-2-samuel@dionne-riel.com>
[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]
On Wed, Dec 22, 2021 at 05:36:04PM -0500, Samuel Dionne-Riel wrote:
> Signed-off-by: Samuel Dionne-Riel <samuel@dionne-riel.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
> arch/sandbox/dts/test.dts | 10 +++
> configs/sandbox_defconfig | 2 +
> drivers/Kconfig | 2 +
> drivers/Makefile | 1 +
> drivers/vibrator/Kconfig | 21 +++++++
> drivers/vibrator/Makefile | 5 ++
> drivers/vibrator/vibrator-uclass.c | 62 +++++++++++++++++++
> include/dm/uclass-id.h | 1 +
> include/vibrator.h | 87 +++++++++++++++++++++++++++
> test/dm/Makefile | 1 +
> test/dm/vibrator.c | 97 ++++++++++++++++++++++++++++++
> 11 files changed, 289 insertions(+)
> create mode 100644 drivers/vibrator/Kconfig
> create mode 100644 drivers/vibrator/Makefile
> create mode 100644 drivers/vibrator/vibrator-uclass.c
> create mode 100644 include/vibrator.h
> create mode 100644 test/dm/vibrator.c
I don't know how, but this is breaking the SDL-based test on sandbox for
me. It runs fine before, and then with this applied I get the "SDL
renderer does not exist" error message.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-01-28 22:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 22:36 [PATCH 0/4] Add vibration motor support to U-Boot Samuel Dionne-Riel
2021-12-22 22:36 ` [PATCH 1/4] drivers: Introduce vibrator uclass Samuel Dionne-Riel
2021-12-28 8:34 ` Simon Glass
2022-01-28 22:39 ` Tom Rini [this message]
2021-12-22 22:36 ` [PATCH 2/4] vibrator: Add vibrator_gpio driver Samuel Dionne-Riel
2021-12-28 8:34 ` Simon Glass
2021-12-22 22:36 ` [PATCH 3/4] cmd: Add vibrator command Samuel Dionne-Riel
2021-12-28 8:34 ` Simon Glass
2021-12-22 22:36 ` [PATCH 4/4] pinephone_defconfig: Add gpio vibrator support Samuel Dionne-Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220128223907.GA3875575@bill-the-cat \
--to=trini@konsulko.com \
--cc=samuel@dionne-riel.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox