From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70FB3C433EF for ; Sat, 29 Jan 2022 12:51:02 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E21C7836A9; Sat, 29 Jan 2022 13:50:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="VKpAxDdf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E0E9083678; Sat, 29 Jan 2022 13:50:53 +0100 (CET) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 57F8283689 for ; Sat, 29 Jan 2022 13:50:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x729.google.com with SMTP id w8so7948985qkw.8 for ; Sat, 29 Jan 2022 04:50:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6PyzqxauZGGydcQqA/rUxp3+KaDGptvuD2JiD7Ks7+o=; b=VKpAxDdfGyzGZlg9oiH+I2ZXEpzFNkv6ZrKOTbsfcXxkCycO/jlE6U9rOb/0oVVnBz liVwPuvBhB6eUP+ycoXGXoBQJ4jIOLMdrVfKpjv2u8Kz9jbfbR0e6OejZtzQYilL2bF5 gHJgAvJvOXr9z+IDGdTaBA3AMNbKhEbnRzYFw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6PyzqxauZGGydcQqA/rUxp3+KaDGptvuD2JiD7Ks7+o=; b=Iqv3w5RARg8HOhQNFqXhfsylQhsXFHBx09pmayNCaBmoeCl7o3wTgAD91Z35KjO8Ag 9Tf+gynFtRGdfOftwJ7rycMvn5ne7eixEWpIe5Bo+4cS3JNVmw1CwH9Kv5A59/mwBGaI eKTN62v1VCsXxgRvFiJcavDtyq9i67W0Q9/4whVSePYihBCsX8lGiOhnWxRHoz81EoVt 5XKyI1xXNlgnabDWDGRN1PUaxYSufZs7wJ0a2LcFdJzIwZwrAr/6ylYE3sqnSvGruAtw ic1xZPL/i9DC92vmiJvWCgy/cklReUWgvNDS7qhgRynVkpzZPvAsqtTVRco68Jcj2w6X +32g== X-Gm-Message-State: AOAM533xbMJ45KRqkLfQwMzNb1JClMSV8RIAGWeG95XSR3zldqZud5WA e97AfHpIQHbEOAe/ZKpYtofEJg== X-Google-Smtp-Source: ABdhPJyl4CeLShKy6RQ3U12NjjlAxPhwSQqnvI7g4X01tpN+voh08gIPjvRbL6TNDcRV/IVsikmqfg== X-Received: by 2002:a05:620a:2a0a:: with SMTP id o10mr8444333qkp.141.1643460650107; Sat, 29 Jan 2022 04:50:50 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id h7sm4997371qtb.15.2022.01.29.04.50.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 04:50:49 -0800 (PST) Date: Sat, 29 Jan 2022 07:50:47 -0500 From: Tom Rini To: Adam Ford Cc: u-boot@lists.denx.de, marex@denx.de, aford@beaconembedded.com Subject: Re: [PATCH V3] phy: nop-phy: Enable reset-gpios support Message-ID: <20220129125047.GP7515@bill-the-cat> References: <20220122180202.13583-1-aford173@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BxgRixwWt/z/BIGD" Content-Disposition: inline In-Reply-To: <20220122180202.13583-1-aford173@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --BxgRixwWt/z/BIGD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 22, 2022 at 12:02:02PM -0600, Adam Ford wrote: > Some usb-nop-xceiv devices use a gpio to put them in and > out of reset. Add a reset function to put them into that > state. This is similar to how Linux handles the > usb-nop-xceiv driver. >=20 > Signed-off-by: Adam Ford > --- > V3: Encapsulate the nop_phy_ops reference to nop_phy_reset > in an if-def so it doesn't appear when DM_GPIO is not > enabled. >=20 > V2: Only use the GPIO functions when DM_GPIO is enabled > Add error handling so if the GPIO fails, it will shutdown > the clocks and return with the error code. > Call nop_phy_reset() instead of repeating the same code. At the risk of sounding a bit too cranky, please build test v4 for k2e_evm as it's still failing to build due to these changes. --=20 Tom --BxgRixwWt/z/BIGD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmH1OCcACgkQFHw5/5Y0 tyynBAwAi0iEod5fFdOnoo8ndFHOoLzDZMR1zVYZPp+Y+6W3S58GMqubJcpC5Teu MZuwQLBMDPYSXrIeHYy/J/k7E/WD57vLidpbSGFSXv4gGTULQ6iHKtFONJdlsmxZ hvGxxggWBvwbx3Ounplob5l8+Vt5ZyWTggZuk9RuAnhuYfP1n9Y5sd8gApOb5X3m jenlHBEsvvLVI7LnvKkfeS/arCAzh1WzFk66oo8a0rszxnwsD94tV6yZXz2ONuLf 8v/sire2TSkuitHDajGTbNV0IDWRhMmM+qQ0wsujKldTaZKdOddiLNb1EkkEKGjC IcEjP0vOhbOIK41dhyVltWFsRrXIZHQ9MtlcMPl3LbXSOMLyfDn+QC0pM7xofyEn ptQUvdp9jCzicgGKOvafUSiKSnSVO2eMD/AqwJeDuKWfgNYB2Q4YuRTegXJwzZSD gJE/PhZ3PVskrPE3nWVk2udLwgmhkzqLlpLDm8tQj3kaVlx7z8/eJpWp73OzeDz0 fwceigup =XV3X -----END PGP SIGNATURE----- --BxgRixwWt/z/BIGD--