From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C695DC433EF for ; Sat, 29 Jan 2022 18:50:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DF9ED8383A; Sat, 29 Jan 2022 19:49:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="uWtCYmJ3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 07F7D836BE; Sat, 29 Jan 2022 19:49:50 +0100 (CET) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 03144837D2 for ; Sat, 29 Jan 2022 19:49:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x835.google.com with SMTP id b5so7981574qtq.11 for ; Sat, 29 Jan 2022 10:49:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VV+JoKddFafoeu+mauf3VlT+0xAaQzhR46NuEwh6eHc=; b=uWtCYmJ3b/tVJfnxTpomhl9JYa9XbqUO7dVeJQxYd5YFBMcHAcP9rNgoBtWgtjOhtu z08goQHoZx/7SHrAFxMB96bfyyA5Q3ob2vwuP3eyZNS77ewvEa9RywxIrIkRTAwKLHRg Xs3dFvF47epP3c7miOgJkYbykfTsUICTp0JYg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VV+JoKddFafoeu+mauf3VlT+0xAaQzhR46NuEwh6eHc=; b=2BktfLXdFs+/B/r71M8enajtP+HK8fbT+Nj45WS0Efej+jIvTXeQR/lU67fJZdG0KM ww15GcnPXF+SgmrlJ8vDI54EkfubS0K5yL/fA4pbJjMyRql14w2I3hUG3QxTiguDKOcH J6U7EU7UrzfKkOaL6Q1uHG9VzQWS3nhxiVDBq8Ur/K4dUJnEZzmiedRaXkr6PMHzhU6K y9ei1A6W0RIkmFowmEFaBvV9DI/8twkFhtjR+XO04qqlwTlbh5f1MGFw7oucubnbo865 exr45KqADFE3EdXphOCYmV3gBPZIUdsAqcVzLtdkAV1l2MECa7a4VNPVuoVVcOMuqJbk Y4IA== X-Gm-Message-State: AOAM533fMCLt8FNKyc5IYlzVDIEcLowjLOtpFcbDQOEQlLt0MsuHZcKb OoTgzr6FWuw8z+dXL2bexMKHPAG9zByG8Q== X-Google-Smtp-Source: ABdhPJwsPHPiXW+sEHFzjovexj4wicackjHbqaJHFXiB7jzqxSjQzaHsz9zT3hauvsnDlChNQK/Snw== X-Received: by 2002:ac8:5c16:: with SMTP id i22mr10058694qti.669.1643482185851; Sat, 29 Jan 2022 10:49:45 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id s34sm5381610qtc.88.2022.01.29.10.49.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 10:49:45 -0800 (PST) Date: Sat, 29 Jan 2022 13:49:43 -0500 From: Tom Rini To: Patrick Delaunay Cc: u-boot@lists.denx.de, Lukasz Majewski , U-Boot STM32 Subject: Re: [PATCH] dfu: mtd: skip empty pages when writing page for UBI partition Message-ID: <20220129184943.GC7515@bill-the-cat> References: <20220118102619.1.I161a621b6f151ada380bedac41d2a2bd67d47933@changeid> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8lT/blNmSiRvUClR" Content-Disposition: inline In-Reply-To: <20220118102619.1.I161a621b6f151ada380bedac41d2a2bd67d47933@changeid> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --8lT/blNmSiRvUClR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 18, 2022 at 10:26:21AM +0100, Patrick Delaunay wrote: > Align the DFU MTD backend for the UBI partitions with the mtd command wri= te > behavior when the option .dontskipff is not used: don't write the empty > pages (full of 0xFF); it is not required for UBI, see [1] for details. >=20 > This patch avoids the "free space fixup" procedure in the kernel [2] > and allows to program a UBIFS volume generated by mkfs.ubifs without the > option -F, --space-fixup. >=20 > The MTD DFU backend implements this behavior introduced on DFU NAND > backend by the commit 13cb7cc9e8e4 ("dfu: Add option to skip empty pages > when flashing UBI images to NAND") and also supported by the command nand > by CONFIG_CMD_NAND_TRIMFFS and by commit c9494866df83 ("cmd_nand: add nand > write.trimffs command"). >=20 > [1] http://www.linux-mtd.infradead.org/doc/ubi.html#L_flasher_algo > [2] http://www.linux-mtd.infradead.org/faq/ubifs.html#L_free_space_fixup >=20 > Signed-off-by: Patrick Delaunay Applied to u-boot/master, thanks! --=20 Tom --8lT/blNmSiRvUClR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmH1jEcACgkQFHw5/5Y0 tyz2pwv9HHiHk4p73ZW4Bkmkb1MMjDhKPb77xyYK3Mw6aX/2FC8tZOU9a7hVHdL8 qnMs6UrUbXXUX2H/UgIw4yVlyfGJyOMUJcAedj4BTnMv2YsGyq8KqY5l2pQU6XkI c3c9DXEY/DuyGi0uce/lixkB6dUZd/xKyNSNjR1ZD6XASq/J+kmWV8uhPqUdBZx8 k4JJqrBSsH17EnenMDy/q9iwST0rL/JXj9mZGM5HamgaG7yQy6AaqcmErXmNpTr2 teOWrkHK4kuBqCNq382Y91KP6c73CfCixCvQAia6Ot/Xj9XCQaDeAfVDv4eA9flA hKU1Ny7+IJ3nNp3bLvKLro/yUVhLOVbvQTiveEKW+bch/duNrFiwveYYvVhgTUvU r/gVguUp7uHrzaXH51xLJcVgqNQ5SOX9p4SOkM47rMKcYOO/mngoCoWI0Wp/n7Bl 54xa73QFM20aCdbS+xyT8vmTlZFLTcm1s6s/+NfxSRbzNSnuKBt/VpEJjUXzxlfs KM+3UXa2 =T8+K -----END PGP SIGNATURE----- --8lT/blNmSiRvUClR--