From: Tom Rini <trini@konsulko.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Simon Glass <sjg@chromium.org>,
Nandor Han <nandor.han@vaisala.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH 1/1] bootcount: fix printf() code
Date: Sat, 29 Jan 2022 13:49:49 -0500 [thread overview]
Message-ID: <20220129184949.GD7515@bill-the-cat> (raw)
In-Reply-To: <20220119003343.95620-1-heinrich.schuchardt@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 667 bytes --]
On Wed, Jan 19, 2022 at 01:33:43AM +0100, Heinrich Schuchardt wrote:
> For printing phys_addr_t we should use %pa to avoid warning like:
>
> drivers/bootcount/bootcount_syscon.c:110:17: note: in expansion of macro ‘dev_err’
> 110 | dev_err(dev, "%s: Unsupported register size: %d\n", __func__,
> | ^~~~~~~
>
> seen for sandbox_defconfig with CONFIG_PHYS_64BIT=y.
>
> Cf. commit 1eebd14b7902 ("vsprintf: Add modifier for phys_addr_t")
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2022-01-29 18:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 0:33 [PATCH 1/1] bootcount: fix printf() code Heinrich Schuchardt
2022-01-27 15:05 ` Simon Glass
2022-01-29 18:49 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220129184949.GD7515@bill-the-cat \
--to=trini@konsulko.com \
--cc=heinrich.schuchardt@canonical.com \
--cc=nandor.han@vaisala.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox