From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C517C433EF for ; Mon, 31 Jan 2022 15:11:36 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8ABC7835BE; Mon, 31 Jan 2022 16:11:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="OJn2lVQG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BF836835BE; Mon, 31 Jan 2022 16:11:31 +0100 (CET) Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5950A830F4 for ; Mon, 31 Jan 2022 16:11:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2f.google.com with SMTP id s6so13002180qvv.11 for ; Mon, 31 Jan 2022 07:11:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Q0TLW2GeBn/U1gEgHT2dyXEU6VdmDmz+29mW7QCTc8g=; b=OJn2lVQGt553C66elmrm2yfH96oS3SO+GNZC3Yh8dBwGxlgUidPbsF2NN/5OeiVOOc n7PBHG7FuosI47hoyWUPiimA69TzZzuTZARKWbM2mL04FlnkcLArJZ1TTVseMIvHKpN3 z94t5FZZWX80Ueq/rWpJb1GOZ4H+kbdU+PSm0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Q0TLW2GeBn/U1gEgHT2dyXEU6VdmDmz+29mW7QCTc8g=; b=jHewBbbUVbrluNTcwzHeMPRGe/A7qDeMkyGUOuHCVC/Ohhu/WfbZvcXVJ8nToevSFM I/nLi2BXAY1gDy+Ba/s0v945CcXp5siCHH6NozOmdl5L9d/hAF4DQNiE2HaANp8M6B7O 395kcYcJs1zyAt2QBrZn0R6i6953mn9O/3+WJZ/d21jxRudbY1nuhtmGtJW4snDnA6JF f2wjPOzITSkz0w+SMWLB0BlJkOHxDy18VbeN5gRycM2Z3uRER//BmESIF8OKiQ4sUIpj rNjaWMbUf3o/WqpOPx5sHFqlZsEkeYei6WhLiImCASuqy3w8Wk8N4GOzbyIZkiUWbEpM lnVw== X-Gm-Message-State: AOAM532vuSoS7V62jvg5zGlEzvdJDcZVyqNOSNMyK9VMKmZiuNOmX/r+ n8RAmjJV1HtpmhcJIArDfgpwlWKlAoCI4Q== X-Google-Smtp-Source: ABdhPJzINE1Eyjoug2U7oWOc39z7BR8hNyqxY1sXw4bjH6hSq44PHFN2MH0R4S9i+iCTTXnrOF8qrg== X-Received: by 2002:ad4:5f89:: with SMTP id jp9mr18456718qvb.109.1643641887140; Mon, 31 Jan 2022 07:11:27 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id h6sm7255639qkk.14.2022.01.31.07.11.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 07:11:26 -0800 (PST) Date: Mon, 31 Jan 2022 10:11:24 -0500 From: Tom Rini To: Nathan Barrett-Morrison Cc: u-boot@lists.denx.de Subject: Re: Falcon Mode Support For Uncompressed Kernel Images Message-ID: <20220131151124.GN7515@bill-the-cat> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XqOulWco09xrjj7X" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --XqOulWco09xrjj7X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 17, 2022 at 07:58:00PM -0500, Nathan Barrett-Morrison wrote: > Hi All, >=20 > While trying to bring up Falcon Mode boot on an ARM64 board, I discovered > that there is no path which allows you to use an uncompressed kernel image > (booti). I've added this path and attached the relevant patch. >=20 > I've made this a separate if/else CONFIG option instead of allowing both > bootz+booti paths to coexist, as it seems unlikely to me that there would > be such a board which needs both. Most architectures use either bootz or > booti, but not both. >=20 > Sincerely, > Nathan Barrett-Morrison > From d5542ccc2d4f81ac0442be8ca772a99e1a13b6dd Mon Sep 17 00:00:00 2001 > From: Nathan Barrett-Morrison > Date: Mon, 17 Jan 2022 19:42:10 -0500 > Subject: [PATCH] Add in the ability to load and boot an uncompressed > kernel image during the Falcon Mode boot sequence. This is required for > architectures which do not support compressed kernel image booting (i.e., > ARM64) >=20 > Signed-off-by: Nathan Barrett-Morrison > Cc: Tom Rini > Cc: Aneesh V > --- > arch/arm/lib/Makefile | 2 +- > common/spl/Kconfig | 6 ++++++ > common/spl/spl.c | 21 +++++++++++++++++++++ > 3 files changed, 28 insertions(+), 1 deletion(-) >=20 > diff --git a/arch/arm/lib/Makefile b/arch/arm/lib/Makefile > index c48e1f622d..24c9e3c1e5 100644 > --- a/arch/arm/lib/Makefile > +++ b/arch/arm/lib/Makefile > @@ -36,7 +36,7 @@ obj-$(CONFIG_CMD_BOOTZ) +=3D bootm.o zimage.o > obj-$(CONFIG_SYS_L2_PL310) +=3D cache-pl310.o > else > obj-$(CONFIG_$(SPL_TPL_)FRAMEWORK) +=3D spl.o > -obj-$(CONFIG_SPL_FRAMEWORK) +=3D zimage.o > +obj-$(CONFIG_SPL_FRAMEWORK) +=3D zimage.o image.o > obj-$(CONFIG_OF_LIBFDT) +=3D bootm-fdt.o > endif > ifdef CONFIG_ARM64 > diff --git a/common/spl/Kconfig b/common/spl/Kconfig > index 4a739a7421..6d2ddddc9f 100644 > --- a/common/spl/Kconfig > +++ b/common/spl/Kconfig > @@ -917,6 +917,12 @@ config SYS_OS_BASE > Specify the address, where the OS image is found, which > gets booted. > =20 > +config SPL_OS_BOOT_UNCOMPRESSED > + bool "Use uncompressed kernel image alongside Falcon Mode" > + depends on SPL_SPI_LOAD > + help > + Use an uncompressed kernel image to boot. This is targetting > + architectures which use booti instead of bootz (i.e, ARM64). > endif # SPL_OS_BOOT We shouldn't need another CONFIG option here, and this would then I believe fail to boot uncompressed arm32 images. The real problem I think is that the code assumed bootm/bootz but needs to instead be more explicit in checking / supporting each and then also yes, adding booti support. Following up with also supporting compressed Images may or may not take additional logic, I'm not sure off-hand. --=20 Tom --XqOulWco09xrjj7X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmH3/BkACgkQFHw5/5Y0 tyxDTAv8DM9rVDIdJywA16fJcBqfm0mary+9wL/eJLTEeQnsmfXr1lmecufTjOFq 3nO2rbGDI8junYqjmKZly6Jg2JcmyzaOQzEYV859xF1Q/qkuJNEtilTiA/DrofxK OoASiuMTkKs6xfCMYru18OwPB2dRy9f1l7DUDTUQi/dGA7mEHxCk3xFrZXcVmtoY H2a79x8xV8aFs44KO1qmHlPeUIGqu+/dvsbSBE8XvFwP4dgz77J2wETLIV51kD5h xAiLQPnr7Qfc0WbVInnDdupOF4Isi/rTEKClPsVvnbd7WrV70apaFTFCw9+zJrJ2 OEyXCXt4Ex/Ksu2DaDfpqa8IiJV9w8qvro8e08MHb1JMDlx4SZXe+LkswdhKLKW/ 3pmoXu7LBoMvO8lboOInBUCqe85YygjtKk1fpmjXISlt+PjxudT1LZuT/8KtiWtd qiWS2r9fX3gFnf0fxA8REqGu7oWY8PIZEQbwC9TaraX0X5y5sg5YB5i7/pq9hNv4 xtb7wnoa =KSc5 -----END PGP SIGNATURE----- --XqOulWco09xrjj7X--