From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: "U-Boot Mailing List" <u-boot@lists.denx.de>,
"Marek Behún" <marek.behun@nic.cz>
Subject: Re: [PATCH] pylint: Adjust how the output is produced
Date: Mon, 31 Jan 2022 10:22:01 -0500 [thread overview]
Message-ID: <20220131152201.GQ7515@bill-the-cat> (raw)
In-Reply-To: <20220129043107.371229-1-sjg@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 935 bytes --]
On Fri, Jan 28, 2022 at 09:31:07PM -0700, Simon Glass wrote:
> The current Makefile rule requires there to be a 'Module' line in the
> pylint output, like this:
>
> ************* Module binman.fip_util
>
> This line only appears if pylint has some comments about the module. We
> cannot rely on it for naming.
>
> Update the code to instead use the filename as the identifier for each
> score, so rather than:
>
> multiplexed_log 7.49
>
> we output:
>
> test_multiplexed_log.py 7.20
>
> It is still easy to see which file the score relates to. In fact the new
> naming is nicer since the full subdirectories are shown.
>
> The avoids the problem where a module name is not produced, and the output
> gets out of sync.
>
> Regenerate pylint.base so we can start from the current baseline.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2022-01-31 15:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 4:31 [PATCH] pylint: Adjust how the output is produced Simon Glass
2022-01-29 12:50 ` Tom Rini
2022-01-31 15:22 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220131152201.GQ7515@bill-the-cat \
--to=trini@konsulko.com \
--cc=marek.behun@nic.cz \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox