From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E849C433F5 for ; Mon, 31 Jan 2022 16:04:49 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 82A0A82A6C; Mon, 31 Jan 2022 17:04:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="CpuM5NiL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9BEDC820AE; Mon, 31 Jan 2022 17:04:45 +0100 (CET) Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 362B98339D for ; Mon, 31 Jan 2022 17:04:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x730.google.com with SMTP id o12so12440787qke.5 for ; Mon, 31 Jan 2022 08:04:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kZkwinyb8MxRwMBVbcVGtxyPUbNR/tdtRXVdjdzuhrs=; b=CpuM5NiLaMRf3hfgMyMKtjerbl0iZMFeT6WorejVTEEEGd84iZ2BcWuJWGpyfO6H4X Y6B1UNdaI6PvD5WtqDhhyz+P+tEcMVjRqn0+Ji/1+82PHumBvazbJMBaJA4KlcxEo0mN +IG5+hV/xI4YUFMkxCK6ZkEfl+D2aZQ96mmEM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kZkwinyb8MxRwMBVbcVGtxyPUbNR/tdtRXVdjdzuhrs=; b=PUItxxsau3kAvWtZih6IXiCtwPTIzCAfC7ftbTI43cch0LJCQz7h9gxBtjddcd77Qi EfnQyR4ENLExwzuVEeBvuFHf1Bz+dRIlA8c5zX8aJrWQesZ9F7u8juO3dLD8tNLQSdf2 cA5Eq2FOoBfuBPakArFC/wS8ElwpEO9YRemFZXwTWuE2C1pSEYx0z8KqA8gkgcnV8dpk TzwqPxBWJPyfpogcLasgeXhAYIvBE/MYotPlqRKXfxNlQPXxguVnCi709wyFPf6xfJq9 298ipR0O6eljn4A4ypXf8F7ccSoS+A2AHq/qxTiPnRNoXhp8pH9gumVs+rMAkF9d+M2N VCzw== X-Gm-Message-State: AOAM530h3CVHRJRftUzUckdG9uTALeTu4REpsIyYYsee5FRGuIzYwy26 IEv7zLxmVxZo3XA6v7Q/OzGV7A== X-Google-Smtp-Source: ABdhPJyUz+TqnBdGfS1qLs5IaMqoCOWyh075LQqNp5qjLz382TzuTFBJU4zhz9jgSbCTYGOjMFRxJQ== X-Received: by 2002:a05:620a:2408:: with SMTP id d8mr7691558qkn.446.1643645078901; Mon, 31 Jan 2022 08:04:38 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id r14sm4439585qkp.48.2022.01.31.08.04.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 08:04:38 -0800 (PST) Date: Mon, 31 Jan 2022 11:04:35 -0500 From: Tom Rini To: Heinrich Schuchardt Cc: Simon Glass , Stefan Roese , Michael Walle , Alison Wang , Andre Przywara , Biwen Li , Dennis Gilmore , Heiko Schocher , Igor Opaniuk , Marek =?iso-8859-1?Q?Beh=FAn?= , Mario Six , Meenakshi Aggarwal , Mian Yousaf Kaukab , Mingkai Hu , Patrick Delaunay , Pramod Kumar , Priyanka Jain , Rajesh Bhagat , Rasmus Villemoes , Rick Chen , Rob Herring , Tang Yuantian , Wasim Khan , Yangbo Lu , liuhao , shuyiqi , Heinrich Schuchardt , U-Boot Mailing List Subject: Re: [PATCH 6/8] scsi: Drop CONFIG_SYS_SCSI_MAX_DEVICE Message-ID: <20220131160435.GY7515@bill-the-cat> References: <20220131144938.927349-1-sjg@chromium.org> <20220131144938.927349-7-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BT3sS6uW76RUUBOi" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --BT3sS6uW76RUUBOi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 31, 2022 at 04:58:46PM +0100, Heinrich Schuchardt wrote: > On 1/31/22 15:49, Simon Glass wrote: > > This is defined based on two other CONFIGs for all boards except sandbox > > and durian. > >=20 > > For sandbox the value does not matter. For durian the value seems > > excessive. > >=20 > > Drop the option completely, to simplify configuration and reduce the > > number of things we need to convert to Kconfig. > >=20 > > Signed-off-by: Simon Glass [snip] > > diff --git a/include/configs/helios4.h b/include/configs/helios4.h > > index de1ebbf3751..c1d42f17ca6 100644 > > --- a/include/configs/helios4.h > > +++ b/include/configs/helios4.h > > @@ -40,8 +40,6 @@ > > #define CONFIG_SCSI_AHCI_PLAT > > #define CONFIG_SYS_SCSI_MAX_SCSI_ID 1 >=20 > This should be Kconfig too. 1 seems to be a reasonable default value as it > covers most boards. The minimum should be enforced as 1 in Kconfig. >=20 > > #define CONFIG_SYS_SCSI_MAX_LUN 1 >=20 > Make this Kconfig, please. Let it default to 1 and enforce a minimum of 1 > and a maximum of 256 in Kconfig. As the series title notes this is "some" options, so yes, a good follow-up would be to cover more of them. I believe the end goal here is that we can drop dead code and more easily check/complain about unmigrated boards. --=20 Tom --BT3sS6uW76RUUBOi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmH4CJAACgkQFHw5/5Y0 tywkKwv+PjL2ErFjdvPG3Z16pF96kBADoI7JqgUPFVYhqJw0qvaDaxGmKB7sgM34 rY5rGfw7qK+7bh/gF9JWOiOpaDLq69GAXFBei2zJBTDWZ3bx55hEinyXxe7OQSR1 XdEkRnzSeuB4BYBxbH6/iQOrbxboWLvfSmNBpODTbkCbmUXLWkxHz/Ssg4QXSWH0 5POe3ZCTiT3l2H+ETXtXTxLA7GzBkkxHDG82B5NHB6UGCIuFq7KEHj3wrEHylSRD oMyyNk2bHydxtM/cwvXDG8h4MS/PvDphOoqNsUMDL7UFFPL97BdUPQTJUnYuQ36p F+5Ncne00VaFxkteEC3bZ37+nfqpuvUFE83zZj8WVM+0yhzVGAV475xdtb3+2PM+ OC4k2IXbdbIli0+A+c+6XhAuCqABA4EFPS8s+mElk/HjiK0Qq+ncSCcOdH69/HkB cMiZUYe0U+zKmlZ89pq658Mp30IxVYYBA353/Htx+DRKEm8WNayTb8d4I4tm4bXx kqsDjrfe =iWJD -----END PGP SIGNATURE----- --BT3sS6uW76RUUBOi--