From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Michal Simek <monstr@monstr.eu>, huang lin <hl@rock-chips.com>,
Jeffy Chen <jeffy.chen@rock-chips.com>,
Kever Yang <kever.yang@rock-chips.com>,
Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
"NXP i . MX U-Boot Team" <uboot-imx@nxp.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Wolfgang Denk <wd@denx.de>
Subject: Re: [PATCH v2 1/2] Makefile: Create a file to indicate the config
Date: Mon, 31 Jan 2022 11:21:38 -0500 [thread overview]
Message-ID: <20220131162138.GA7515@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ2t03aNtRtMuQskKgHgA2XpR5C==upJOO=O61_9w-6q7g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1396 bytes --]
On Mon, Jan 31, 2022 at 09:13:07AM -0700, Simon Glass wrote:
> Hi Tom,
>
> On Mon, 31 Jan 2022 at 07:24, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Sun, Jan 30, 2022 at 08:52:24AM -0700, Simon Glass wrote:
> >
> > > At present it is not actually possible to discover the defconfig file that
> > > was used to build U-Boot, so far as I can tell. Write this out to a file
> > > in the build directory, so this is visible.
> > >
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> >
> > I don't think we need this really normally, it's just for the follow-up
> > patch.
>
> I'd argue that it is helpful to have this somewhere. Is there anywhere
> else in the build directory where it can be discovered?
It's not a guarantee to exist is my first problem. My minor problems
are this needs to be in .gitignore and also I think this wasn't ensuring
output directory not source directory. But I don't see the use case
this is filling. If you're in-tree, you should know what you configured
and are working on. If you're out of tree and didn't do any sort of
naming convention to your objdirs, did you also really care what
defconfig exactly (I use a mix of named and garbage-named temp dirs)?
And if you're a tool of some sort, you were told what to use at some
point I would assume. Which all gets back to I don't see the use case
exactly for it.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-01-31 16:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-30 15:52 [PATCH v2 1/2] Makefile: Create a file to indicate the config Simon Glass
2022-01-30 15:52 ` [PATCH v2 2/2] Makefile: Don't allow new boards with SPL_FIT_GENERATOR Simon Glass
2022-01-30 19:40 ` Michal Simek
2022-01-30 23:14 ` Simon Glass
2022-01-31 14:24 ` Tom Rini
2022-01-31 16:13 ` Simon Glass
2022-01-31 16:15 ` Tom Rini
2022-01-31 17:27 ` Simon Glass
2022-01-31 18:00 ` Tom Rini
2022-01-31 19:57 ` Simon Glass
2022-01-31 20:40 ` Tom Rini
2022-01-31 21:22 ` Simon Glass
2022-01-31 22:05 ` Tom Rini
2022-01-31 22:59 ` Simon Glass
2022-01-31 23:25 ` Tom Rini
2022-01-31 23:32 ` Tom Rini
2022-02-01 14:05 ` Simon Glass
2022-02-01 15:42 ` Simon Glass
2022-02-01 16:08 ` Mark Kettenis
2022-02-01 16:24 ` Simon Glass
2022-01-31 22:02 ` Mark Kettenis
2022-01-31 14:24 ` [PATCH v2 1/2] Makefile: Create a file to indicate the config Tom Rini
2022-01-31 16:13 ` Simon Glass
2022-01-31 16:21 ` Tom Rini [this message]
2022-01-31 17:27 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220131162138.GA7515@bill-the-cat \
--to=trini@konsulko.com \
--cc=hl@rock-chips.com \
--cc=jeffy.chen@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=monstr@monstr.eu \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
--cc=wd@denx.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox