From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F7D4C433F5 for ; Mon, 31 Jan 2022 22:05:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F17C383457; Mon, 31 Jan 2022 23:05:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="HByKcwW2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4BFEA834E5; Mon, 31 Jan 2022 23:05:48 +0100 (CET) Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 18460820AE for ; Mon, 31 Jan 2022 23:05:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72d.google.com with SMTP id 13so13440854qkd.13 for ; Mon, 31 Jan 2022 14:05:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qYvxjHUsuxyZ5nccEo5QI6WnryErSmxFGS51TcHAe8U=; b=HByKcwW2VBRmw759MoQdhHWoNwdXFbNZo6V69DpCWwYnU8F2kDaRacInt2vwXtVf9+ m8qrwE+d8iuNqwve4SSt5qxNWaHZFBf9VTsWcg/kvL3dJLcoFv8XFav6MVYwiA6q4if7 vggxHMP5hWNm2zXu00MrkCHSTg6cR9QiB844g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qYvxjHUsuxyZ5nccEo5QI6WnryErSmxFGS51TcHAe8U=; b=jx1OLVyOOFf7ozeaeO6xkXebufgk3nVXsbPCNGpDcIVtaF66Sv3Q6w5+dVTcgElIHF ymRg/NKXHo/IzJQEsCepJ/EMjHu4VkBkx5bW4AKcts/VKPBtAKbSzcJ21iEmpCNSpuWB +4f3i8Haa1opCwkBUxuO4s/CxBfxVJbN4/p3HTwqQXQN7aLFnHHMmEBi2xBZWZhG1Bpu 7+0Q45tBAepZZ9tpnyl1EP8dY2CSAOhu7hA0sil3mO+b4qgeu5YqxNeMkqz30Trb7Gda zSE+XlX8xU9L+9P5GuevDiEM6iNMptqp9NOcDhNUJs2AKMk3YANpDlA7iK0ovokF4Ih8 Slrg== X-Gm-Message-State: AOAM53168gJGpRHvVSTAfjpB9VU6IpQaRNEARsJhkbC4bLwWF7C3sLh4 m9t4jj2fUlrHfYN1dlj0dd+FkQ== X-Google-Smtp-Source: ABdhPJyBynYrAl0o9+HCVNZmaRCu+WK41qWo3NH5+XcYk6Td7Li3RaT7etGPPWeqmmDirL5n20YUSQ== X-Received: by 2002:a37:b0c5:: with SMTP id z188mr14644144qke.165.1643666743896; Mon, 31 Jan 2022 14:05:43 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id n6sm9222817qtx.23.2022.01.31.14.05.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 14:05:43 -0800 (PST) Date: Mon, 31 Jan 2022 17:05:41 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Michal Simek , huang lin , Jeffy Chen , Kever Yang , Philipp Tomsich , "NXP i . MX U-Boot Team" , Marek =?iso-8859-1?Q?Beh=FAn?= , Masahiro Yamada Subject: Re: [PATCH v2 2/2] Makefile: Don't allow new boards with SPL_FIT_GENERATOR Message-ID: <20220131220541.GH7515@bill-the-cat> References: <20220130155225.726890-1-sjg@chromium.org> <20220130155225.726890-2-sjg@chromium.org> <20220131142412.GH7515@bill-the-cat> <20220131161544.GZ7515@bill-the-cat> <20220131180001.GC7515@bill-the-cat> <20220131204039.GG7515@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gsknP8gbNnI51S+b" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --gsknP8gbNnI51S+b Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 31, 2022 at 02:22:41PM -0700, Simon Glass wrote: > Hi Tom, >=20 > On Mon, 31 Jan 2022 at 13:40, Tom Rini wrote: > > > > On Mon, Jan 31, 2022 at 12:57:57PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 31 Jan 2022 at 11:00, Tom Rini wrote: > > > > > > > > On Mon, Jan 31, 2022 at 10:27:41AM -0700, Simon Glass wrote: > > > > > Hi Tom, > > > > > > > > > > On Mon, 31 Jan 2022 at 09:15, Tom Rini wrote: > > > > > > > > > > > > On Mon, Jan 31, 2022 at 09:13:02AM -0700, Simon Glass wrote: > > > > > > > Hi Tom, > > > > > > > > > > > > > > On Mon, 31 Jan 2022 at 07:24, Tom Rini w= rote: > > > > > > > > > > > > > > > > On Sun, Jan 30, 2022 at 08:52:25AM -0700, Simon Glass wrote: > > > > > > > > > > > > > > > > > More than a year after this migration message appeared, w= e still have new > > > > > > > > > boards being added with this option. Add a check against = this. > > > > > > > > > > > > > > > > > > Signed-off-by: Simon Glass > > > > > > > > > > > > > > > > Please just make this an error in checkpatch.pl instead. > > > > > > > > > > > > > > I couldn't think of a way of doing that...do you have an idea? > > > > > > > > > > > > Yes, 2f3e8d6a86cb ("checkpatch: report ERROR only on disabling = of fdt > > > > > > and initrd relocation") updates the check I had for fdt_high/in= itrd_high > > > > > > being in the file at all to only be for additions. And yes, I = check > > > > > > every PR for new checkpatch ERROR lines and only ignore the one= s for > > > > > > code imported from other projects. > > > > > > > > > > Yes, I understand that, but SPL_FIT_GENERATOR defaults to on for > > > > > certain boards, so there is no need to mention it anywhere in the > > > > > patch. Also someone could adjust the condition in the Kconfig to = add > > > > > other boards. > > > > > > > > Then you want something a bit more like the fdt|initrd_high check n= ow, > > > > along with updating the help around SPL_FIT_GENERATOR to note that = this > > > > option is deprecated, is the path forward then I think. > > > > > > I'm still a bit lost. > > > > > > What I want: break the build if someone adds a new board that uses > > > SPL_FIT_GENERATOR > > > > > > What you are offering: checkpatch check for people adding that option > > > > > > But the patch doesn't generally include that option. > > > > > > I can certainly mention in the Kconfig help that the option is > > > deprecated, but without checking if it is defined for a NEW board, I > > > cannot prevent it from growing. > > > > > > What am I missing? Can you be more specific? > > > > How do you add a new board that enables SPL_FIT_GENERATOR without > > "SPL_FIT_GENERATOR" being in the resulting patch, other than being > > ARCH_ZYNQMP/ARCH_ROCKCHIP ? >=20 > Well that's the case I am most concerned with, actually. Also, someone > might add a new condition to SPL_FIT_GENERATOR. For the current cases, we just need to get them migrated since it's all the same logic? So it would I think be a one-and-done thing. For a new conditional, it should trip checkpatch by having the words in it, and also since the help would also say to not do this, and we already generate a warning, it shouldn't be an issue? --=20 Tom --gsknP8gbNnI51S+b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmH4XTIACgkQFHw5/5Y0 tyxCXgwAitDxZQaM/ZYfNpAbEn0LX+oLZeaD8x+59itCFs2qeQnDPongo3NQjkIp iA1fRZZpHkv+Y5TqickhBooyWQcOf1Gk56gdOGCPOMBrEUSAeNu4s042U0MdCRKb JG24gT6zZwe8Q9aBiC1xHp2KaNvfofkoHdu7NIa6XXD0NqNtSH2TzkvghTat3reC qD61MHLRkcjmXyTCEK/jTr0sPYgh5yNz3Ks2MfSiiHENBB7krfYcvnKQwU//dZo6 piMqilh8rVRJl/bRSStk8QS45TDTdkKx9Du0DrGXo8CNaXe6YBU8xayDTqiBi54Q 2QrYmTpoOLPAPq8mQxNKzTs+yN5BKunRshFA0RGDq195BWWlD2AHYilJaYcpMbYo V2g0cLUbianYHt5gpY3D4lXPM/xGCjRFTN+qEBrqe53SO810ZqHxqIoQT+kSAosO nhWoKS7HKwuLQo5Pd9KGReWpQUPG9IloQiXmBaSbJZn+ebpJ3bcrybMxQK72WX9Y ozvu6R7t =JFol -----END PGP SIGNATURE----- --gsknP8gbNnI51S+b--