From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBA2DC433F5 for ; Mon, 31 Jan 2022 23:25:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AAF2581F6B; Tue, 1 Feb 2022 00:25:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ImvdfEtU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 10EE481F6B; Tue, 1 Feb 2022 00:25:41 +0100 (CET) Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C656E80FAA for ; Tue, 1 Feb 2022 00:25:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2e.google.com with SMTP id e17so5706539qvb.8 for ; Mon, 31 Jan 2022 15:25:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IsSB5gWVm4KLo7WBLTFB5Xx5Yr0LHk+Qo3yJtwWx0Wc=; b=ImvdfEtUucW3GIXSjdqakE11U0NYrGeYI8NDHnQqAmuViG7xFi6bKRADUfkMxwr+la uqvo/mVC2JgkHbb5tHAcg2i2HWAkuguVIGo6Mp+UgfYY7cOOzRs+cZtXSOn6KvTPwBv6 h4PexO3ivtacf8/RSyGS9vPh4n6tPQWdf06s0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IsSB5gWVm4KLo7WBLTFB5Xx5Yr0LHk+Qo3yJtwWx0Wc=; b=ybVrZfe06ManrmHJ0DN3uBfS06+tS0PVR8vMlSIMd31nBZagePxmYfrx65fmcwruiz jwmWlqvgkCQ1N8RZE3bevrNs9iDJL01R2n8mudAFCkqd/c8EbboMoceyrii0725YHZN0 xxiteplw5OtEfTHgr+LP4kpVORcVw9iNjn9sdNP3GyeobNcOkmrGW2Mil8Y01tnYdFfP w+QpFMdwpfKS0rRHEOtZ9lWl7yYVryNe4n1M4VtGPdPGxU5ex3aULTrpaayhRYJW3juQ b6Mtbc+VZjk7DjV0rsRML1X64aE0uU13mrJTCkEdwp9lcptBKzPClHi0CDRzN8CvZvcC h2jQ== X-Gm-Message-State: AOAM531FLdVn4ZoVZSd0WqUZn9ceeQ8xuEOkj2+K+i8K9gCwzwsXb0kx sqweJmxpIFR5/y8rQgIxyXGnAg== X-Google-Smtp-Source: ABdhPJwWbDD7YH4ayg/Ecjxpm6DqZS5JdXVZghmFZdc2ngIdQk2MryLiMtGcvGtSDNq+L/tiGIokUw== X-Received: by 2002:a05:6214:1d28:: with SMTP id f8mr20147393qvd.107.1643671536588; Mon, 31 Jan 2022 15:25:36 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id f16sm413349qtk.8.2022.01.31.15.25.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 15:25:35 -0800 (PST) Date: Mon, 31 Jan 2022 18:25:33 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Michal Simek , huang lin , Jeffy Chen , Kever Yang , Philipp Tomsich , "NXP i . MX U-Boot Team" , Marek =?iso-8859-1?Q?Beh=FAn?= , Masahiro Yamada Subject: Re: [PATCH v2 2/2] Makefile: Don't allow new boards with SPL_FIT_GENERATOR Message-ID: <20220131232533.GK7515@bill-the-cat> References: <20220131142412.GH7515@bill-the-cat> <20220131161544.GZ7515@bill-the-cat> <20220131180001.GC7515@bill-the-cat> <20220131204039.GG7515@bill-the-cat> <20220131220541.GH7515@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vL7xWxsqy+bNTFJd" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --vL7xWxsqy+bNTFJd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 31, 2022 at 03:59:08PM -0700, Simon Glass wrote: > Hi Tom, >=20 > (yes Mark I am trying to stop further boards going in that use the > shell scripts) >=20 > On Mon, 31 Jan 2022 at 15:05, Tom Rini wrote: > > > > On Mon, Jan 31, 2022 at 02:22:41PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 31 Jan 2022 at 13:40, Tom Rini wrote: > > > > > > > > On Mon, Jan 31, 2022 at 12:57:57PM -0700, Simon Glass wrote: > > > > > Hi Tom, > > > > > > > > > > On Mon, 31 Jan 2022 at 11:00, Tom Rini wrote: > > > > > > > > > > > > On Mon, Jan 31, 2022 at 10:27:41AM -0700, Simon Glass wrote: > > > > > > > Hi Tom, > > > > > > > > > > > > > > On Mon, 31 Jan 2022 at 09:15, Tom Rini w= rote: > > > > > > > > > > > > > > > > On Mon, Jan 31, 2022 at 09:13:02AM -0700, Simon Glass wrote: > > > > > > > > > Hi Tom, > > > > > > > > > > > > > > > > > > On Mon, 31 Jan 2022 at 07:24, Tom Rini wrote: > > > > > > > > > > > > > > > > > > > > On Sun, Jan 30, 2022 at 08:52:25AM -0700, Simon Glass w= rote: > > > > > > > > > > > > > > > > > > > > > More than a year after this migration message appeare= d, we still have new > > > > > > > > > > > boards being added with this option. Add a check agai= nst this. > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Simon Glass > > > > > > > > > > > > > > > > > > > > Please just make this an error in checkpatch.pl instead. > > > > > > > > > > > > > > > > > > I couldn't think of a way of doing that...do you have an = idea? > > > > > > > > > > > > > > > > Yes, 2f3e8d6a86cb ("checkpatch: report ERROR only on disabl= ing of fdt > > > > > > > > and initrd relocation") updates the check I had for fdt_hig= h/initrd_high > > > > > > > > being in the file at all to only be for additions. And yes= , I check > > > > > > > > every PR for new checkpatch ERROR lines and only ignore the= ones for > > > > > > > > code imported from other projects. > > > > > > > > > > > > > > Yes, I understand that, but SPL_FIT_GENERATOR defaults to on = for > > > > > > > certain boards, so there is no need to mention it anywhere in= the > > > > > > > patch. Also someone could adjust the condition in the Kconfig= to add > > > > > > > other boards. > > > > > > > > > > > > Then you want something a bit more like the fdt|initrd_high che= ck now, > > > > > > along with updating the help around SPL_FIT_GENERATOR to note t= hat this > > > > > > option is deprecated, is the path forward then I think. > > > > > > > > > > I'm still a bit lost. > > > > > > > > > > What I want: break the build if someone adds a new board that uses > > > > > SPL_FIT_GENERATOR > > > > > > > > > > What you are offering: checkpatch check for people adding that op= tion > > > > > > > > > > But the patch doesn't generally include that option. > > > > > > > > > > I can certainly mention in the Kconfig help that the option is > > > > > deprecated, but without checking if it is defined for a NEW board= , I > > > > > cannot prevent it from growing. > > > > > > > > > > What am I missing? Can you be more specific? > > > > > > > > How do you add a new board that enables SPL_FIT_GENERATOR without > > > > "SPL_FIT_GENERATOR" being in the resulting patch, other than being > > > > ARCH_ZYNQMP/ARCH_ROCKCHIP ? > > > > > > Well that's the case I am most concerned with, actually. Also, someone > > > might add a new condition to SPL_FIT_GENERATOR. > > > > For the current cases, we just need to get them migrated since it's all > > the same logic? So it would I think be a one-and-done thing. For a new >=20 > Yes I think so and some of them are done. These are what I can find: >=20 > ./arch/riscv/lib/mkimage_fit_opensbi.sh > ./arch/arm/mach-zynqmp/mkimage_fit_atf.sh > ./arch/arm/mach-imx/mkimage_fit_atf.sh > ./arch/arm/mach-rockchip/make_fit_atf.py >=20 > but they are not used by that many boards. >=20 > I feel that the amount of pending migration is somewhat overwhelming > and we should take a stronger line in mainline. >=20 > Perhaps I should send a patch to simply remove the option? Would that > be acceptable? Is there something technically preventing their migration to buildman? Looking over examples for imx8* conversions, it's just adding a binman node and describing things there, yes? --=20 Tom --vL7xWxsqy+bNTFJd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmH4b+oACgkQFHw5/5Y0 tyzCxgv/cseDaQ4X1KBQ7vi7/LYBs1xj1NRog1ZQrADFD6qjBueO3t8JkbjiT9iq rellENSEUEndJH1DtIOYkdcxRVeiVQbLN/WZuEEfolq+PEMqPGqvqhx7wAo2kSKy ANYSm2NUsvNXOgZLSozA2aifB+SsWxABy/+hUd9WnZvyX4oxLp0YfiiZE9K8sIbb wnFr/EdFhJL8vxH3p2bI2+DOjTQwEcVCT8fSDWq/UkmPyjVFsT55qHHU+a6ZlcUs JpObesi/WhTugK1GL2NqQcUmRBH7Su13G251id4MTgSbOJQflzyk+b2hPb6Oo5wx Sdo6SYc5DVdJ1bP6atdNBJnT6kYcvSM7kVQAgw/PUONBRrQfc+rlUqR134MJhBbR MA1ixlwg2fiwAp0uziI3ipHbbpbxC6fO3N5X+vdGY8he1L6XldRTpyWk8qM3RoV4 npxBqudilqqShyBj+kdOJ1AErQbInbLzk38bRuH5liLdU7mMIM4U/yevnozPWu2j kDWy7Qku =U6/R -----END PGP SIGNATURE----- --vL7xWxsqy+bNTFJd--