From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44B72C433EF for ; Mon, 31 Jan 2022 23:33:05 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 70AB883025; Tue, 1 Feb 2022 00:33:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="WHbBMvlS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 327308302C; Tue, 1 Feb 2022 00:33:00 +0100 (CET) Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 15D7481F6B for ; Tue, 1 Feb 2022 00:32:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2d.google.com with SMTP id g13so14427576qvw.4 for ; Mon, 31 Jan 2022 15:32:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Nu1lKXEVvDxoHLjP4jKO+Qlb13+wOHJZfk0NCwTR/6E=; b=WHbBMvlS4iACACOEDCgZNHoNJuw3j1K6eytTrUCAb7MzZkFbwCkBrln9xJMBin0rTl IqRaGU2la9X70L77/xoolAUB03jJSzQOhTs9aT8Md5ljNk0oB+YZ4H1q5IvRLeyLTDNI A2we7SurbkSBJ85nOEtlpyx9atjWMoFtdj1a4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Nu1lKXEVvDxoHLjP4jKO+Qlb13+wOHJZfk0NCwTR/6E=; b=K1MTXhgscP2lynizz9uK06APYIwB6264mmRy0+BWK4Eri6QIEX/AKjrwderF8Xlo/S 8pTDK3lKbGJaet9GN1m7luLYdl8ciXYZDCGtpnOEyeHvL687s4gXH7tjKyayylVb4EcP 9IZ2uASLBbsdeGi2wSchpvMqTzqTTIgwXTL38XBp+KIrBvEthv5nyC8GYIoFHChgl/tQ tGOvmFzLc+ejfIp6CHVkhJwitkWNrUHKDm3wlNkehIf7XxxBWn65kIz5aB0iy+nzyBG+ AuPWwpZL2grnfzvziy5NBW4it09sB0HJOxX0kBqEJ7SryDB8tPZEVMgmL01IwGD5xG9r vxLg== X-Gm-Message-State: AOAM5302nLRqhSH36jiZERESpzJTno9kfDavHtM1nVlF4uqXX+uOzolO hKBTzbkbRP8DJ24n2VF9xIn9xQ== X-Google-Smtp-Source: ABdhPJzwkZATUz0QlzOlqRSddLAtq5yZdhec5n8uZzstI95xhX3peeXeCHqlaxbi0+1LICmRipmU4Q== X-Received: by 2002:a05:6214:c6c:: with SMTP id t12mr19619240qvj.121.1643671975877; Mon, 31 Jan 2022 15:32:55 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id bl4sm2364545qkb.15.2022.01.31.15.32.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 15:32:55 -0800 (PST) Date: Mon, 31 Jan 2022 18:32:53 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Michal Simek , huang lin , Jeffy Chen , Kever Yang , Philipp Tomsich , "NXP i . MX U-Boot Team" , Marek =?iso-8859-1?Q?Beh=FAn?= , Masahiro Yamada Subject: Re: [PATCH v2 2/2] Makefile: Don't allow new boards with SPL_FIT_GENERATOR Message-ID: <20220131233253.GL7515@bill-the-cat> References: <20220131161544.GZ7515@bill-the-cat> <20220131180001.GC7515@bill-the-cat> <20220131204039.GG7515@bill-the-cat> <20220131220541.GH7515@bill-the-cat> <20220131232533.GK7515@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ithwq2VAKZXg2OxI" Content-Disposition: inline In-Reply-To: <20220131232533.GK7515@bill-the-cat> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --ithwq2VAKZXg2OxI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 31, 2022 at 06:25:33PM -0500, Tom Rini wrote: > On Mon, Jan 31, 2022 at 03:59:08PM -0700, Simon Glass wrote: > > Hi Tom, > >=20 > > (yes Mark I am trying to stop further boards going in that use the > > shell scripts) > >=20 > > On Mon, 31 Jan 2022 at 15:05, Tom Rini wrote: > > > > > > On Mon, Jan 31, 2022 at 02:22:41PM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Mon, 31 Jan 2022 at 13:40, Tom Rini wrote: > > > > > > > > > > On Mon, Jan 31, 2022 at 12:57:57PM -0700, Simon Glass wrote: > > > > > > Hi Tom, > > > > > > > > > > > > On Mon, 31 Jan 2022 at 11:00, Tom Rini wro= te: > > > > > > > > > > > > > > On Mon, Jan 31, 2022 at 10:27:41AM -0700, Simon Glass wrote: > > > > > > > > Hi Tom, > > > > > > > > > > > > > > > > On Mon, 31 Jan 2022 at 09:15, Tom Rini = wrote: > > > > > > > > > > > > > > > > > > On Mon, Jan 31, 2022 at 09:13:02AM -0700, Simon Glass wro= te: > > > > > > > > > > Hi Tom, > > > > > > > > > > > > > > > > > > > > On Mon, 31 Jan 2022 at 07:24, Tom Rini wrote: > > > > > > > > > > > > > > > > > > > > > > On Sun, Jan 30, 2022 at 08:52:25AM -0700, Simon Glass= wrote: > > > > > > > > > > > > > > > > > > > > > > > More than a year after this migration message appea= red, we still have new > > > > > > > > > > > > boards being added with this option. Add a check ag= ainst this. > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Simon Glass > > > > > > > > > > > > > > > > > > > > > > Please just make this an error in checkpatch.pl inste= ad. > > > > > > > > > > > > > > > > > > > > I couldn't think of a way of doing that...do you have a= n idea? > > > > > > > > > > > > > > > > > > Yes, 2f3e8d6a86cb ("checkpatch: report ERROR only on disa= bling of fdt > > > > > > > > > and initrd relocation") updates the check I had for fdt_h= igh/initrd_high > > > > > > > > > being in the file at all to only be for additions. And y= es, I check > > > > > > > > > every PR for new checkpatch ERROR lines and only ignore t= he ones for > > > > > > > > > code imported from other projects. > > > > > > > > > > > > > > > > Yes, I understand that, but SPL_FIT_GENERATOR defaults to o= n for > > > > > > > > certain boards, so there is no need to mention it anywhere = in the > > > > > > > > patch. Also someone could adjust the condition in the Kconf= ig to add > > > > > > > > other boards. > > > > > > > > > > > > > > Then you want something a bit more like the fdt|initrd_high c= heck now, > > > > > > > along with updating the help around SPL_FIT_GENERATOR to note= that this > > > > > > > option is deprecated, is the path forward then I think. > > > > > > > > > > > > I'm still a bit lost. > > > > > > > > > > > > What I want: break the build if someone adds a new board that u= ses > > > > > > SPL_FIT_GENERATOR > > > > > > > > > > > > What you are offering: checkpatch check for people adding that = option > > > > > > > > > > > > But the patch doesn't generally include that option. > > > > > > > > > > > > I can certainly mention in the Kconfig help that the option is > > > > > > deprecated, but without checking if it is defined for a NEW boa= rd, I > > > > > > cannot prevent it from growing. > > > > > > > > > > > > What am I missing? Can you be more specific? > > > > > > > > > > How do you add a new board that enables SPL_FIT_GENERATOR without > > > > > "SPL_FIT_GENERATOR" being in the resulting patch, other than being > > > > > ARCH_ZYNQMP/ARCH_ROCKCHIP ? > > > > > > > > Well that's the case I am most concerned with, actually. Also, some= one > > > > might add a new condition to SPL_FIT_GENERATOR. > > > > > > For the current cases, we just need to get them migrated since it's a= ll > > > the same logic? So it would I think be a one-and-done thing. For a = new > >=20 > > Yes I think so and some of them are done. These are what I can find: > >=20 > > ./arch/riscv/lib/mkimage_fit_opensbi.sh > > ./arch/arm/mach-zynqmp/mkimage_fit_atf.sh > > ./arch/arm/mach-imx/mkimage_fit_atf.sh > > ./arch/arm/mach-rockchip/make_fit_atf.py > >=20 > > but they are not used by that many boards. > >=20 > > I feel that the amount of pending migration is somewhat overwhelming > > and we should take a stronger line in mainline. > >=20 > > Perhaps I should send a patch to simply remove the option? Would that > > be acceptable? >=20 > Is there something technically preventing their migration to buildman? > Looking over examples for imx8* conversions, it's just adding a binman > node and describing things there, yes? Poking at this a bit more, it seems like the outstanding imx platforms to be converted still have pending patches and it's just part of the general imx backlog. The riscv one isn't used and should be removed. That leaves rockchip and zynqmp needing conversion. Michal has already commented in this thread and I'll leave it to him to say how long he needs to see how long zynqmp needs to update. That leaves Rockchip. --=20 Tom --ithwq2VAKZXg2OxI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmH4caUACgkQFHw5/5Y0 tyyE4gv5AZFt6b3BL02NCis2G+8bVR00DLKmhVtHwf+FjqNj58PHRLTiCm7oRgK+ 2sGE+ysSp07XYY3ISRNCdBUwFjOBUlG5VfKUddnDFqqUE65IfhUE2ZpJQLhchoUN WspUm0aniNX33YQ9LeqCzD1pc3tlBaMUnzYPOYq/PxSPP9jpsfAKSRkRvv8/58UT UATOKZPBXn8Kx5oC/pbCLvhqixzGusPXQSNsWtZuOuDOfj9TwNstXTakEY3/pe6b eLIthHh3E3UP4+DvZBLnHiVOOo0IiNVGKUuBC1gZoaXWbhLs+8OMlAVoW5VBPkcP 9+zISP6tMQjqo+LJ7KZutF/UkDuxLJ/WjZUobdc0k2y9Tm1GdWFvgyaTpFEszpCL nSU99K90q0VfZUJ+MAfiKZTBYvbFYqdjyzdQISI5d6QcYixrJ5givOocAjskf6cL m0Lq3Bmq4M9a9ehWRoBCN4pnH9bxZvhUtPyioAKk437ogeEd47EVW+sOXjwpNJVV QIYGmN1K =Y8lt -----END PGP SIGNATURE----- --ithwq2VAKZXg2OxI--