From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49BA9C433EF for ; Thu, 3 Feb 2022 22:09:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5D0EF8210D; Thu, 3 Feb 2022 23:09:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="K3TkIHS0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5937D83A3D; Thu, 3 Feb 2022 23:09:24 +0100 (CET) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 84E7C8197D for ; Thu, 3 Feb 2022 23:09:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x731.google.com with SMTP id c189so3242994qkg.11 for ; Thu, 03 Feb 2022 14:09:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2SRxRx2P2maO/7a9+SwcsctGAYLcgB/EAaQAx1wYOgo=; b=K3TkIHS0jsx6mRW0Kj9g9gFnSmKVHmPiYNyYBjcgVAXgpDHOjacsV3Vu95tja772jT WpKmpwWC8r8DdQmJF+NUT/av7nLl2rXbuF1ivUBQMlf4EImGr9oY9xGSnROARttJVwNO tp+fLzkZtR5UHysVy7VBzolT9mg7VBqjF8dIs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2SRxRx2P2maO/7a9+SwcsctGAYLcgB/EAaQAx1wYOgo=; b=XJ8n0a4XiBxkbjkjd1dXf0lalCaapW02PZ98aXzyNzvJk7tT0NUIX0jEg/z+R5jYSu AWaMMzv7dDQTmN6Wk7PAjG+VzO3/ZQcz9J7MGwJavW0x1vzHJ1Kb0jMrNU+6QFWE4EbX J/kxpdFMwksY7/COlFMmlhb+81DuHiGrA1we7oRop6BgjzWcUFSnNVq2mwPJyGs+835p ShLcyAFVVSfGjliXC0IkRUBsH4buiAd44DYTL64ZarnPqtIoRatzlSzNmvOrzrHHVm5A Rid70beE6j+eH0104ENnD6GUprVneXleLPsNMUM70L6fclnPGlzkiTqpkFITzxS5clRG OOCg== X-Gm-Message-State: AOAM532HJ7Fi60QJ7Ia/m/wi0HJkGRl2vKQKr2ELDmj0OC9BoAy78kaj iVHILMOICMZZ8p7zcydp7kEaTw== X-Google-Smtp-Source: ABdhPJwAbzxJyv5BajBGUqcgJVbOLnAX9iV8GJmPvYrG7dxHNBkavtoQMTqqgTcUTwqElZASU44xHg== X-Received: by 2002:a05:620a:4110:: with SMTP id j16mr60686qko.671.1643926160337; Thu, 03 Feb 2022 14:09:20 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id u17sm73392qki.12.2022.02.03.14.09.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Feb 2022 14:09:19 -0800 (PST) Date: Thu, 3 Feb 2022 17:09:18 -0500 From: Tom Rini To: Simon Glass Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , U-Boot Mailing List Subject: Re: [PATCH] Nokia RX-51: Convert to CONFIG_DM_KEYBOARD Message-ID: <20220203220918.GC7515@bill-the-cat> References: <20220203183850.10186-1-pali@kernel.org> <20220203211623.GY7515@bill-the-cat> <20220203214544.GA7515@bill-the-cat> <20220203215307.GB7515@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2CtqMDJfWc01zJhs" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --2CtqMDJfWc01zJhs Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 03, 2022 at 03:03:21PM -0700, Simon Glass wrote: > Hi, >=20 > On Thu, 3 Feb 2022 at 15:02, Simon Glass wrote: > > > > Hi, > > > > On Thu, 3 Feb 2022 at 14:53, Tom Rini wrote: > > > > > > On Thu, Feb 03, 2022 at 04:45:44PM -0500, Tom Rini wrote: > > > > On Thu, Feb 03, 2022 at 04:16:23PM -0500, Tom Rini wrote: > > > > > On Thu, Feb 03, 2022 at 07:38:50PM +0100, Pali Roh=E1r wrote: > > > > > > > > > > > Signed-off-by: Pali Roh=E1r > > > > > > --- > > > > > > > > > > > > I would really appreciate if U-Boot test framework starts print= ing > > > > > > deprecation warnings, instead of sending patches which directly= drop > > > > > > support for some boards. > > > > > > > > > > > > There is absolutely no warning during building U-Boot for RX-51= board > > > > > > that this board has not been converted to DM_KEYBOARD yet. > > > > > > > > > > Please send some patch that implements what you're wanting to see= for > > > > > how to make the warnings more visible. I do agree the warning for > > > > > v2022.10 only showed up after the merge to -next once v2022.01 ca= me out, > > > > > but it's still a fairly long time to clean up the few unconverted > > > > > boards. > > > > > > > > Oh, I see what's going on. Simon, the DM_KEYBOARD check isn't > > > > triggering for any boards. I'll look more. > > > > > > And here's where we're at. nokia_rx51 doesn't set CONFIG_KEYBOARD, so > > > didn't trigger the warning about migration. Every platform that sets > > > CONFIG_KEYBOARD is migrated. I don't know how many other platforms a= re > > > in the situation nokia_rx51 is in. Yanking out the legacy code and > > > seeing what fails to build, and going from there is probably the next > > > option. > > > > Yes. > > > > As to your questoin, none that I know of. I sent a series to drop > > cfb_console which was how this used to work, although in fact it > > hasn't worked for a while. The problem here seems to be that this > > board was multiple migrations behind and so was not caught. > > > > We should be able to remove the migration check. > > > > Pali, just to explain from the other POV, I am finding it increasingly > > frustrating dealing with ad-hoc CONFIG options, old drivers, etc. We > > really need to complete some of the migrations we started 6 years ago. >=20 > BTW the keyboard driver should go in drivers/input and should use > device tree, not platdata. This is likely one of the cases where we end up saying a platform is only platdata, given size concerns? That's my quick recollection from talking about the USB stuff a few months back, and some other related size questions. --=20 Tom --2CtqMDJfWc01zJhs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmH8UooACgkQFHw5/5Y0 tyyRnwwAgBZaOjm0J4o21Rv7Zkj9h2QWU41O4nfcdnzgW9Hze2ku1ppKHmdPfQiw e7FJXRKpSw/WVuEgxncC4kX0F3mvldIzpae9wL25Vp5OXOMQ4CX7KnG1GkeyVJeJ NzAxuFM7gVCNoYIH33DHYfHk0RfbCLcYDmqIqwiOi5Qo5RZyeBe+p6lsQs+KxS24 uVtf489aGvGJV/nOukHB41WGGkqd4KiVZHSBvrcYDJRd4I1KUP1NS0f4cP56vshd L7OHsM2/eMEu//TwCbFeUrhvisYbIeDGJc1VE1y2IATyzXix0vXCWfm8U98p22xn 34ht4mQiUNjCtWh0dYAsKCW3/tNASHEpyCsd2gx7ZOEIDWyxqh13GzGM/gcZLV+L vnelRbHD1r9hfh+3u2vtfu1Qan4HkRweHZv81ojosHfdJEUP67Nbeu+8CD/BXEy5 V20Fk1XfDjHn2P6aWXy7tRyOFMnT0FW66hJiSZ7tPUlhd7NqD6rATszYCq6KaqHU gcESQAzh =hAk0 -----END PGP SIGNATURE----- --2CtqMDJfWc01zJhs--