From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08696C433F5 for ; Fri, 4 Feb 2022 13:42:05 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 751DA8210D; Fri, 4 Feb 2022 14:42:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="JNbdHaGZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8FD228197D; Fri, 4 Feb 2022 14:42:01 +0100 (CET) Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9A34A8197D for ; Fri, 4 Feb 2022 14:41:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72a.google.com with SMTP id o10so4777352qkg.0 for ; Fri, 04 Feb 2022 05:41:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eMeUDPk5qgcZkx76iv56auv4ZwUtUWzN29creQ7fT04=; b=JNbdHaGZehE3i5aCKJi+Q4fp3/wnemh/1revee+u6PNCt+Onb+ipbTri7f9tl3NoOl shqf20Z12iZU1he03K/hurxWdlK7YSYXka9hxRXNhhlt8pqPckpZz65kgvo+Ojbs5er5 Og7VYA2VkbfVCAIt7bfHQ0SOsukYhMvwB+xr0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eMeUDPk5qgcZkx76iv56auv4ZwUtUWzN29creQ7fT04=; b=0QrAKcybKz+8N6r0URRQ9ZP8fZSIR88VN9RP6Qfzg3ep/xEyhzIMs1ScuOcT/BPvJp 4s5tA3zgRrCsmumBqF9NdmDWziKwAynJvLnfSIje6pNbtuM6VOarhDBQMJKXScJln7Cc K2Xxz7hxHO/lv/xhchTyR6ZuHfux3HeYeezRA/jJ3uRRjz4ULasjGqY2n83vJZSefCzA Z8FG8c3wieW59Iaq+Yi5xqPbaJUz1OOeUAOvuuGErg1FXG7ZnDSTWpKmxMwwvq5AOEUS k2waET9X0b1BXgCNiJn4DN6TjAxPPB5WEZmAQq6sEHHzhQbj5IKySeakng8X4YSxW1na N78g== X-Gm-Message-State: AOAM533k3lFB7T50BuOsXYKboXR1q2wI0tXJK+KJXT7B00HIDxAAxn1r VrIMQI8cP7VmvH2xWzQMQMdR/g== X-Google-Smtp-Source: ABdhPJwycRvve1Z+3BZwZyXoE+s0rXRJ7rSU5ZrOX5pp5GU5sLRBg/bFtSQj5H1k1CRBpLPwrhtCTw== X-Received: by 2002:a37:b0f:: with SMTP id 15mr1455417qkl.769.1643982117370; Fri, 04 Feb 2022 05:41:57 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id y5sm984349qkj.28.2022.02.04.05.41.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Feb 2022 05:41:56 -0800 (PST) Date: Fri, 4 Feb 2022 08:41:55 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , U-Boot Mailing List Subject: Re: [PATCH] Nokia RX-51: Convert to CONFIG_DM_KEYBOARD Message-ID: <20220204134155.GP7515@bill-the-cat> References: <20220203183850.10186-1-pali@kernel.org> <20220203211623.GY7515@bill-the-cat> <20220203214544.GA7515@bill-the-cat> <20220203215307.GB7515@bill-the-cat> <20220204105652.sluginmttbwgcwku@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ljwjD4eUwP//fgul" Content-Disposition: inline In-Reply-To: <20220204105652.sluginmttbwgcwku@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --ljwjD4eUwP//fgul Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 04, 2022 at 11:56:52AM +0100, Pali Roh=E1r wrote: > On Thursday 03 February 2022 15:02:02 Simon Glass wrote: > > Hi, > >=20 > > On Thu, 3 Feb 2022 at 14:53, Tom Rini wrote: > > > > > > On Thu, Feb 03, 2022 at 04:45:44PM -0500, Tom Rini wrote: > > > > On Thu, Feb 03, 2022 at 04:16:23PM -0500, Tom Rini wrote: > > > > > On Thu, Feb 03, 2022 at 07:38:50PM +0100, Pali Roh=E1r wrote: > > > > > > > > > > > Signed-off-by: Pali Roh=E1r > > > > > > --- > > > > > > > > > > > > I would really appreciate if U-Boot test framework starts print= ing > > > > > > deprecation warnings, instead of sending patches which directly= drop > > > > > > support for some boards. > > > > > > > > > > > > There is absolutely no warning during building U-Boot for RX-51= board > > > > > > that this board has not been converted to DM_KEYBOARD yet. > > > > > > > > > > Please send some patch that implements what you're wanting to see= for > > > > > how to make the warnings more visible. I do agree the warning for > > > > > v2022.10 only showed up after the merge to -next once v2022.01 ca= me out, > > > > > but it's still a fairly long time to clean up the few unconverted > > > > > boards. > > > > > > > > Oh, I see what's going on. Simon, the DM_KEYBOARD check isn't > > > > triggering for any boards. I'll look more. > > > > > > And here's where we're at. nokia_rx51 doesn't set CONFIG_KEYBOARD, so > > > didn't trigger the warning about migration. Every platform that sets > > > CONFIG_KEYBOARD is migrated. I don't know how many other platforms a= re > > > in the situation nokia_rx51 is in. Yanking out the legacy code and > > > seeing what fails to build, and going from there is probably the next > > > option. > >=20 > > Yes. > >=20 > > As to your questoin, none that I know of. I sent a series to drop > > cfb_console which was how this used to work, although in fact it > > hasn't worked for a while. The problem here seems to be that this > > board was multiple migrations behind and so was not caught. >=20 > It is not truth that cfb_console has not worked. This driver is / was > working fine on n900 without any issues. Yes, it's such an old missed migration that there's no check for it. > > We should be able to remove the migration check. > >=20 > > Pali, just to explain from the other POV, I am finding it increasingly > > frustrating dealing with ad-hoc CONFIG options, old drivers, etc. We > > really need to complete some of the migrations we started 6 years ago. > >=20 > > Regards, > > Simon >=20 > Well, I see and understand you. But as I explained it more times, it was > me who is/was waiting for review of n900 patches and I was not able to > speed up review process. There was always some n900 patch in waiting > state. >=20 > Now when pending n900 patches were reviewed and merged, I prepared and > sent another one -- this DM_KEYBOARD which removes one part of > cfb_console code from n900 board code. Alright. So, do you see the warning about DM_SERIAL? Are you going to start work on that migration now, or in about a week or two when I pick this up, assuming no changes are requested? --=20 Tom --ljwjD4eUwP//fgul Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmH9LR8ACgkQFHw5/5Y0 tyw+fwv/QewUW7Ph2UffHkNdifTAWnIi3F4YucLiBJ/+t9HjU0I/e0vLLmPkZckn LJkyFZZ2IeS3JH2sk+RUmlfF9aAB7+VQBr6Tf1dPFUx0fAwZKc+AgxMBvzYO8ojD neurQAUczp4nKTH/ACvYWC5qZhT6LRUkf+M2GMIQ9c98YpzYeZXA0ejEhipni7Oy enhvYMxKa3eHiIZclE9KtfdlSeq1GRQ8wCSpwkMFEws7/EJUo6uq6c1Z2WRFEYdf tYAUsK3wbpIp+zF/Z7tI6yDSu3XWa7T24ttWLsGss1gjGmOsNiM9c4dlkmqAQ2nC cff2cjrlSgkWqVxCkb8YUHIvuukx5vlQeUogXPrzVRgtMQPhdhlKWg7X2Uz9+If2 /lH+bxm3NSNMDpZxrM78jPA0ZHKZN0uvlJ5V4RhuS+mg2q10rrvpX69KRMidoSFy Oue6wAHXrkMRYqBkz0L4MBNCr/oY/UOkPOMOaV6pppIavIwLNV+oVu9+NhWv0ANV 0LX4aOlL =QYdi -----END PGP SIGNATURE----- --ljwjD4eUwP//fgul--