From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BF38C433FE for ; Sat, 5 Feb 2022 16:39:07 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0B2C583B4D; Sat, 5 Feb 2022 17:39:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1644079146; bh=2nUc07ys2Mg2t0JjM2Am0zM8Aes/aq3mAtItqn/w/tU=; h=From:To:Subject:In-reply-to:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From; b=SyVYH+IwZgH6Gik1FvtvpJnDR8LezCLf5NsmtPpmtd0oGqc/IJLqzNG6rscDb4Emk Txh4dZTGH2i54QJfcih3SniWLomQvypx7yDsYaSuiVCIesp97WSclerI9gpOLa9BHZ 1xHFJbJIKQbo8HB/Me2aVPEZmXc64HGm7fSZa/kKdEVKrhKLsc06BiKUrsI+peUXd0 kAXR0u/IxD1xx4WYAy/RCTSQRRmt5Xj1C4hq4cAvRqT+Vg8TRr3RUpcyDy7SvpHCUI 32W4f0nz5Li5tAnR4CtXFL95aZwHQTMWhEn4J+UmALLrFpSKoPYvD78w/7tj9UJbqX K5ahKtOM/2yow== Received: by phobos.denx.de (Postfix, from userid 109) id 2EC9683AA4; Sat, 5 Feb 2022 17:39:02 +0100 (CET) Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1D8AD83A69 for ; Sat, 5 Feb 2022 17:38:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sbabic@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4JrdQV4q5lz1sYfM; Sat, 5 Feb 2022 17:38:58 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4JrdQV4b7Qz1qqkD; Sat, 5 Feb 2022 17:38:58 +0100 (CET) X-Amavis-Alert: BAD HEADER SECTION, Missing required header field: "Date" Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id Ins771Rb4ZJr; Sat, 5 Feb 2022 17:38:57 +0100 (CET) Received: from papero (host-88-217-136-221.customer.m-online.net [88.217.136.221]) by mail.mnet-online.de (Postfix) with ESMTP; Sat, 5 Feb 2022 17:38:57 +0100 (CET) From: sbabic@denx.de X-Patchwork-Submitter: Mattias Hansson X-Patchwork-Id: 1559066 X-Patchwork-Delegate: sbabic@denx.de To: Mattias Hansson ,u-boot@lists.denx.de Subject: [PATCH v2] tools/mxsimage: Remove fclose on empty FILE pointer In-reply-to: <20211124121049.24054-1-hansson.mattias@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Message-Id: <20220205163902.2EC9683AA4@phobos.denx.de> Date: Sat, 5 Feb 2022 17:38:59 +0100 (CET) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean > If `sb_load_cmdfile()` fails to open the configuration file it will jump > to error handling where the code will try to `fclose()` the FILE pointer > which is NULL causing `mkimage` to segfault. > This patch removes the label for error handling and instead returns > immediately which skips the `fclose()` and prevents the segfault. The > errno is also described in the error message to guide users. > Signed-off-by: Mattias Hansson > Reviewed-by: Wolfgang Denk Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de =====================================================================