From: sbabic@denx.de
To: Adam Ford <aford173@gmail.com>,u-boot@lists.denx.de
Subject: [PATCH 1/2] imx: imx8mm_beacon: Remove redundant code
Date: Sat, 5 Feb 2022 17:41:02 +0100 (CET) [thread overview]
Message-ID: <20220205164106.24F0C83BF8@phobos.denx.de> (raw)
In-Reply-To: <20220127211001.104334-1-aford173@gmail.com>
> The function to return the default MMC device for the environment
> already has a __weak instance doing exactly the same thing. Remove
> the superfluous one.
> Signed-off-by: Adam Ford <aford173@gmail.com>
> diff --git a/board/beacon/imx8mm/imx8mm_beacon.c b/board/beacon/imx8mm/imx8mm_beacon.c
> index 87ffebb571..c228bbf777 100644
> --- a/board/beacon/imx8mm/imx8mm_beacon.c
> +++ b/board/beacon/imx8mm/imx8mm_beacon.c
> @@ -50,8 +50,3 @@ int board_init(void)
>
> return 0;
> }
> -
> -int board_mmc_get_env_dev(int devno)
> -{
> - return devno;
> -}
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
prev parent reply other threads:[~2022-02-05 16:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 21:10 [PATCH 1/2] imx: imx8mm_beacon: Remove redundant code Adam Ford
2022-01-27 21:10 ` [PATCH 2/2] imx: imx8mn_beacon: " Adam Ford
2022-02-05 16:39 ` sbabic
2022-02-05 16:41 ` sbabic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220205164106.24F0C83BF8@phobos.denx.de \
--to=sbabic@denx.de \
--cc=aford173@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox