public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Moritz Fischer <moritzf@google.com>
To: u-boot@lists.denx.de
Cc: sjg@chromium.org, bmeng.cn@gmail.com,
	andriy.shevchenko@linux.intel.com,
	 Moritz Fischer <moritzf@google.com>
Subject: [PATCH 1/2] arch: x86: lib: acpi_table: Fix MCFG entries
Date: Sat,  5 Feb 2022 12:17:44 -0800	[thread overview]
Message-ID: <20220205201745.1059029-1-moritzf@google.com> (raw)

Commit d953137526cc ("x86: Move SSDT table to a writer function")
introduced a bug where the actual MCFG entries are no longer generated.

Cc: Simon Glass <sjg@chromium.org>
Fixes: d953137526cc ("x86: Move SSDT table to a writer function")
Signed-off-by: Moritz Fischer <moritzf@google.com>
---

Hi Simon, Andriy,

it looks like this got dropped when moving stuff around, I don't have HW
to test this, but it seemed off.

- Moritz

---

 arch/x86/lib/acpi_table.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/lib/acpi_table.c b/arch/x86/lib/acpi_table.c
index c0534343f1..753bf39619 100644
--- a/arch/x86/lib/acpi_table.c
+++ b/arch/x86/lib/acpi_table.c
@@ -499,6 +499,8 @@ int acpi_write_mcfg(struct acpi_ctx *ctx, const struct acpi_writer *entry)
 	header->length = sizeof(struct acpi_mcfg);
 	header->revision = 1;
 
+	current = acpi_fill_mcfg(current);
+
 	/* (Re)calculate length and checksum */
 	header->length = current - (u32)mcfg;
 	header->checksum = table_compute_checksum(mcfg, header->length);
-- 
2.35.0.263.gb82422642f-goog


             reply	other threads:[~2022-02-05 20:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-05 20:17 Moritz Fischer [this message]
2022-02-05 20:17 ` [PATCH 2/2] acpi: Move MCFG implementation to common lib Moritz Fischer
2022-02-07 20:22   ` Simon Glass
2022-02-07 20:49     ` Moritz Fischer
2022-02-08 15:08       ` Simon Glass
2022-02-08 20:39         ` Simon Glass
2022-02-07 20:22 ` [PATCH 1/2] arch: x86: lib: acpi_table: Fix MCFG entries Simon Glass
2022-02-08 20:39   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220205201745.1059029-1-moritzf@google.com \
    --to=moritzf@google.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bmeng.cn@gmail.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox