From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0DEB9C433F5 for ; Sat, 5 Feb 2022 20:19:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8A6CE83595; Sat, 5 Feb 2022 21:19:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="G9+IYk4O"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 388C783B8B; Sat, 5 Feb 2022 21:17:52 +0100 (CET) Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 31F3D83B76 for ; Sat, 5 Feb 2022 21:17:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=3a9v-YQcKBjQcehYjpVWeeWbU.Seck-ReejbYiji.TUdn.TU@flex--moritzf.bounces.google.com Received: by mail-yb1-xb49.google.com with SMTP id v70-20020a25c549000000b006130de5790aso20389234ybe.4 for ; Sat, 05 Feb 2022 12:17:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=XyOfrcTruUDtwSz+hLA4VEeSsJijt21eEq9SNi5S3eI=; b=G9+IYk4Ow2hHmaOV3gxfxrb+tWVSEebnlr+8fJ5oO632IUpMmIoIfO1Q64n6KEfKdZ I4WYIaBH0IZI7CuLSub00B6gXIyuMBoGdt7n6oHuoXL77yUnjOv8PJH/H7fo/oaQz79/ zfU6NY2hZs9qJ8Xcq0hJ/cY/Pt2MoQy2zTDmQZVUz+OqHVYCiDKY4bsst4d9EQI5soqx NbnLzgrXXC5fsQFqwyK1sdaTxwvMfOr07BZRP86DjOfD7PYhtfSC7o4dxba+ajv/UvcH wdUCZ7ln90ooo8+PnTvaCE8rhn+6KQkqTbtB4EBQl7AwfBfuJEmM7+FFBJ2JGQCsp01s s0wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=XyOfrcTruUDtwSz+hLA4VEeSsJijt21eEq9SNi5S3eI=; b=yJbzflsKfGbBbPXofpAf8ry1l8QMkVJIhqobtmmPDKlWUVzZizfOByPlKehWt+42BA b+aP1a2u+u1STcThM8dJzVPuXkB/cgfF5HgDFzXiF0sluFNb8BhbjA2LGz3bG62YXxRx gu/HGQb0VpJHltGqfjyPp/4JDLWu66nW2G2XwBJlfd6YHS7soEMTj5qX/8PLqoBMGhAB K6hmv2pc/jy+r5fKPb7enbNoDi1TumbV3IztrlCUSNrPKlTLiXIIrb/xTSIFd8v/1L3Q IJ2sFqbpu9QweDIMwUZW2NwPfe20DGoOmFY0GHGSF4Xw5eLMQDeFkjGtQ9UUHMM0AyRa DgKg== X-Gm-Message-State: AOAM531M1lPZtxOc3LJ8ZNNrB/HbCpq38cfiCFZS7Xt1xZy6Vi09GmgC NNZ32Q+gPtFmmhbVZnKERAbwSvoxYRClfe/b6vygpgmtJAr7odAUeOInVZYrLSDgS6B/KQJPiF1 ML928S2ZFcKNndkLcORjLyIXQL0KKIyWTPvcdVJNLcUeB9MFLcHthXVkwtyp4LA== X-Google-Smtp-Source: ABdhPJxRE00CFNpIAPVKcbuCc+dT1FGnzo0DVtua+zqU6qzAAxLFhxzoJLZCOSxjESvNQzNC7q0i8DozStJ6 X-Received: from morats.c.googlers.com ([fda3:e722:ac3:cc00:14:4d90:c0a8:6c]) (user=moritzf job=sendgmr) by 2002:a25:2a51:: with SMTP id q78mr431156ybq.257.1644092267869; Sat, 05 Feb 2022 12:17:47 -0800 (PST) Date: Sat, 5 Feb 2022 12:17:44 -0800 Message-Id: <20220205201745.1059029-1-moritzf@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.35.0.263.gb82422642f-goog Subject: [PATCH 1/2] arch: x86: lib: acpi_table: Fix MCFG entries From: Moritz Fischer To: u-boot@lists.denx.de Cc: sjg@chromium.org, bmeng.cn@gmail.com, andriy.shevchenko@linux.intel.com, Moritz Fischer Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Sat, 05 Feb 2022 21:19:49 +0100 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Commit d953137526cc ("x86: Move SSDT table to a writer function") introduced a bug where the actual MCFG entries are no longer generated. Cc: Simon Glass Fixes: d953137526cc ("x86: Move SSDT table to a writer function") Signed-off-by: Moritz Fischer --- Hi Simon, Andriy, it looks like this got dropped when moving stuff around, I don't have HW to test this, but it seemed off. - Moritz --- arch/x86/lib/acpi_table.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/lib/acpi_table.c b/arch/x86/lib/acpi_table.c index c0534343f1..753bf39619 100644 --- a/arch/x86/lib/acpi_table.c +++ b/arch/x86/lib/acpi_table.c @@ -499,6 +499,8 @@ int acpi_write_mcfg(struct acpi_ctx *ctx, const struct acpi_writer *entry) header->length = sizeof(struct acpi_mcfg); header->revision = 1; + current = acpi_fill_mcfg(current); + /* (Re)calculate length and checksum */ header->length = current - (u32)mcfg; header->checksum = table_compute_checksum(mcfg, header->length); -- 2.35.0.263.gb82422642f-goog