public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Francis Laniel <francis.laniel@amarulasolutions.com>
To: u-boot@lists.denx.de
Cc: Marek Behun <marek.behun@nic.cz>,
	Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
	Simon Glass <sjg@chromium.org>, Wolfgang Denk <wd@denx.de>,
	Harald Seiler <hws@denx.de>,
	Francis Laniel <francis.laniel@amarulasolutions.com>
Subject: [RFC PATCH v2 01/21] test: Add framework to test hush behavior
Date: Sun,  6 Feb 2022 19:36:57 +0100	[thread overview]
Message-ID: <20220206183717.57446-2-francis.laniel@amarulasolutions.com> (raw)
In-Reply-To: <20220206183717.57446-1-francis.laniel@amarulasolutions.com>

Introduce a new subcommand to ut: ut hush.
For the moment, this command does nothing, future commits will add tests which
will be run on command call.

Note that CONFIG_HUSH_PARSER must be defined to compile this new subcommand.

Signed-off-by: Francis Laniel <francis.laniel@amarulasolutions.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
 include/test/hush.h     | 15 +++++++++++++++
 include/test/suites.h   |  1 +
 test/Makefile           |  3 +++
 test/cmd_ut.c           |  6 ++++++
 test/hush/Makefile      |  6 ++++++
 test/hush/cmd_ut_hush.c | 20 ++++++++++++++++++++
 6 files changed, 51 insertions(+)
 create mode 100644 include/test/hush.h
 create mode 100644 test/hush/Makefile
 create mode 100644 test/hush/cmd_ut_hush.c

diff --git a/include/test/hush.h b/include/test/hush.h
new file mode 100644
index 0000000000..cca66544a0
--- /dev/null
+++ b/include/test/hush.h
@@ -0,0 +1,15 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * (C) Copyright 2021
+ * Francis Laniel, Amarula Solutions, francis.laniel@amarulasolutions.com
+ */
+
+#ifndef __TEST_HUSH_H__
+#define __TEST_HUSH_H__
+
+#include <test/test.h>
+
+/* Declare a new environment test */
+#define HUSH_TEST(_name, _flags)	UNIT_TEST(_name, _flags, hush_test)
+
+#endif /* __TEST_HUSH_H__ */
diff --git a/include/test/suites.h b/include/test/suites.h
index d35cd83a4e..35a8429e18 100644
--- a/include/test/suites.h
+++ b/include/test/suites.h
@@ -36,6 +36,7 @@ int do_ut_compression(struct cmd_tbl *cmdtp, int flag, int argc,
 		      char *const argv[]);
 int do_ut_dm(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]);
 int do_ut_env(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]);
+int do_ut_hush(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]);
 int do_ut_lib(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]);
 int do_ut_log(struct cmd_tbl *cmdtp, int flag, int argc, char * const argv[]);
 int do_ut_mem(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]);
diff --git a/test/Makefile b/test/Makefile
index b3b2902e2e..c471125982 100644
--- a/test/Makefile
+++ b/test/Makefile
@@ -16,6 +16,9 @@ obj-$(CONFIG_$(SPL_)CMDLINE) += cmd_ut.o
 obj-$(CONFIG_$(SPL_)CMDLINE) += command_ut.o
 obj-$(CONFIG_$(SPL_)UT_COMPRESSION) += compression.o
 obj-y += dm/
+ifneq ($(CONFIG_HUSH_PARSER),)
+obj-$(CONFIG_CMDLINE) += hush/
+endif
 obj-$(CONFIG_$(SPL_)CMDLINE) += print_ut.o
 obj-$(CONFIG_$(SPL_)CMDLINE) += str_ut.o
 obj-$(CONFIG_UT_TIME) += time_ut.o
diff --git a/test/cmd_ut.c b/test/cmd_ut.c
index 90b260f72d..714b7e7417 100644
--- a/test/cmd_ut.c
+++ b/test/cmd_ut.c
@@ -70,6 +70,9 @@ static struct cmd_tbl cmd_ut_sub[] = {
 #ifdef CONFIG_CMD_ADDRMAP
 	U_BOOT_CMD_MKENT(addrmap, CONFIG_SYS_MAXARGS, 1, do_ut_addrmap, "", ""),
 #endif
+#if CONFIG_IS_ENABLED(HUSH_PARSER)
+	U_BOOT_CMD_MKENT(hush, CONFIG_SYS_MAXARGS, 1, do_ut_hush, "", ""),
+#endif
 };
 
 static int do_ut_all(struct cmd_tbl *cmdtp, int flag, int argc,
@@ -148,6 +151,9 @@ static char ut_help_text[] =
 #endif
 #ifdef CONFIG_CMD_ADDRMAP
 	"ut addrmap - Very basic test of addrmap command\n"
+#endif
+#if CONFIG_IS_ENABLED(HUSH_PARSER)
+	"ut hush [test-name] - Test hush behavior\n"
 #endif
 	;
 #endif /* CONFIG_SYS_LONGHELP */
diff --git a/test/hush/Makefile b/test/hush/Makefile
new file mode 100644
index 0000000000..dfa2a92615
--- /dev/null
+++ b/test/hush/Makefile
@@ -0,0 +1,6 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# (C) Copyright 2021
+# Francis Laniel, Amarula Solutions, francis.laniel@amarulasolutions.com
+
+obj-y += cmd_ut_hush.o
diff --git a/test/hush/cmd_ut_hush.c b/test/hush/cmd_ut_hush.c
new file mode 100644
index 0000000000..48a1adbf28
--- /dev/null
+++ b/test/hush/cmd_ut_hush.c
@@ -0,0 +1,20 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * (C) Copyright 2021
+ * Francis Laniel, Amarula Solutions, francis.laniel@amarulasolutions.com
+ */
+
+#include <common.h>
+#include <command.h>
+#include <test/hush.h>
+#include <test/suites.h>
+#include <test/ut.h>
+
+int do_ut_hush(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
+{
+	struct unit_test *tests = UNIT_TEST_SUITE_START(hush_test);
+	const int n_ents = UNIT_TEST_SUITE_COUNT(hush_test);
+
+	return cmd_ut_category("hush", "hush_test_",
+			       tests, n_ents, argc, argv);
+}
-- 
2.25.1


  reply	other threads:[~2022-02-06 18:37 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-06 18:36 [RFC PATCH v2 00/21] Modernize U-Boot shell Francis Laniel
2022-02-06 18:36 ` Francis Laniel [this message]
2022-02-06 18:36 ` [RFC PATCH v2 02/21] test: hush: Test hush if/else Francis Laniel
2022-02-06 18:36 ` [RFC PATCH v2 03/21] test/py: hush_if_test: Remove the test file Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 04/21] test: hush: Test hush variable expansion Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 05/21] test: hush: Test hush commands list Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 06/21] test: hush: Test hush loops Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 07/21] cli: Add Busybox upstream hush.c file Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 08/21] cli: Port Busybox 2021 hush to U-Boot Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 09/21] cli: Add choice for hush parser Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 10/21] cli: Add HUSH_2021_PARSER to hush parser choice Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 11/21] cli: Enables using hush 2021 parser as command line parser Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 12/21] cli: hush_2021: Enable variables expansion for hush 2021 Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 13/21] cli: hush_2021: Add functions to be called from run_command() Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 14/21] cli: Modify run_command() to add hush 2021 as parser Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 15/21] test: hush: Fix instructions list tests for hush 2021 Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 16/21] test: hush: Fix variable expansion " Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 17/21] cli: hush_2021: Enable using \< and \> as string compare operators Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 18/21] cli: hush_2021: Enable if keyword Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 19/21] test: hush: Fix if tests for hush 2021 Francis Laniel
2022-02-06 19:07   ` Marek Behún
2022-02-06 18:37 ` [RFC PATCH v2 20/21] cli: hush_2021: Enable loops Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 21/21] test: hush: Fix loop tests for hush 2021 Francis Laniel
2022-02-06 19:07   ` Marek Behún
2022-02-06 18:54 ` [RFC PATCH v2 00/21] Modernize U-Boot shell Heinrich Schuchardt
2022-02-08 15:28   ` Tom Rini
2022-02-08 15:32     ` Simon Glass
2022-02-18 20:51 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220206183717.57446-2-francis.laniel@amarulasolutions.com \
    --to=francis.laniel@amarulasolutions.com \
    --cc=hws@denx.de \
    --cc=marek.behun@nic.cz \
    --cc=michael@amarulasolutions.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    --cc=wd@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox