From: Francis Laniel <francis.laniel@amarulasolutions.com>
To: u-boot@lists.denx.de
Cc: Marek Behun <marek.behun@nic.cz>,
Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
Simon Glass <sjg@chromium.org>, Wolfgang Denk <wd@denx.de>,
Harald Seiler <hws@denx.de>,
Francis Laniel <francis.laniel@amarulasolutions.com>
Subject: [RFC PATCH v2 03/21] test/py: hush_if_test: Remove the test file
Date: Sun, 6 Feb 2022 19:36:59 +0100 [thread overview]
Message-ID: <20220206183717.57446-4-francis.laniel@amarulasolutions.com> (raw)
In-Reply-To: <20220206183717.57446-1-francis.laniel@amarulasolutions.com>
ce40f44eb336 ("test: hush: Test hush if/else") translated this test to a C test,
so this python file is no more needed.
Signed-off-by: Francis Laniel <francis.laniel@amarulasolutions.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
test/py/tests/test_hush_if_test.py | 184 -----------------------------
1 file changed, 184 deletions(-)
delete mode 100644 test/py/tests/test_hush_if_test.py
diff --git a/test/py/tests/test_hush_if_test.py b/test/py/tests/test_hush_if_test.py
deleted file mode 100644
index 37c1608bb2..0000000000
--- a/test/py/tests/test_hush_if_test.py
+++ /dev/null
@@ -1,184 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-# Copyright (c) 2015-2016, NVIDIA CORPORATION. All rights reserved.
-
-# Test operation of the "if" shell command.
-
-import os
-import os.path
-import pytest
-
-# TODO: These tests should be converted to a C test.
-# For more information please take a look at the thread
-# https://lists.denx.de/pipermail/u-boot/2019-October/388732.html
-
-pytestmark = pytest.mark.buildconfigspec('hush_parser')
-
-# The list of "if test" conditions to test.
-subtests = (
- # Base if functionality.
-
- ('true', True),
- ('false', False),
-
- # Basic operators.
-
- ('test aaa = aaa', True),
- ('test aaa = bbb', False),
-
- ('test aaa != bbb', True),
- ('test aaa != aaa', False),
-
- ('test aaa < bbb', True),
- ('test bbb < aaa', False),
-
- ('test bbb > aaa', True),
- ('test aaa > bbb', False),
-
- ('test 123 -eq 123', True),
- ('test 123 -eq 456', False),
-
- ('test 123 -ne 456', True),
- ('test 123 -ne 123', False),
-
- ('test 123 -lt 456', True),
- ('test 123 -lt 123', False),
- ('test 456 -lt 123', False),
-
- ('test 123 -le 456', True),
- ('test 123 -le 123', True),
- ('test 456 -le 123', False),
-
- ('test 456 -gt 123', True),
- ('test 123 -gt 123', False),
- ('test 123 -gt 456', False),
-
- ('test 456 -ge 123', True),
- ('test 123 -ge 123', True),
- ('test 123 -ge 456', False),
-
- # Octal tests
-
- ('test 010 -eq 010', True),
- ('test 010 -eq 011', False),
-
- ('test 010 -ne 011', True),
- ('test 010 -ne 010', False),
-
- # Hexadecimal tests
-
- ('test 0x2000000 -gt 0x2000001', False),
- ('test 0x2000000 -gt 0x2000000', False),
- ('test 0x2000000 -gt 0x1ffffff', True),
-
- # Mixed tests
-
- ('test 010 -eq 10', False),
- ('test 010 -ne 10', True),
- ('test 0xa -eq 10', True),
- ('test 0xa -eq 012', True),
-
- ('test 2000000 -gt 0x1ffffff', False),
- ('test 0x2000000 -gt 1ffffff', True),
- ('test 0x2000000 -lt 1ffffff', False),
- ('test 0x2000000 -eq 2000000', False),
- ('test 0x2000000 -ne 2000000', True),
-
- ('test -z ""', True),
- ('test -z "aaa"', False),
-
- ('test -n "aaa"', True),
- ('test -n ""', False),
-
- # Inversion of simple tests.
-
- ('test ! aaa = aaa', False),
- ('test ! aaa = bbb', True),
- ('test ! ! aaa = aaa', True),
- ('test ! ! aaa = bbb', False),
-
- # Binary operators.
-
- ('test aaa != aaa -o bbb != bbb', False),
- ('test aaa != aaa -o bbb = bbb', True),
- ('test aaa = aaa -o bbb != bbb', True),
- ('test aaa = aaa -o bbb = bbb', True),
-
- ('test aaa != aaa -a bbb != bbb', False),
- ('test aaa != aaa -a bbb = bbb', False),
- ('test aaa = aaa -a bbb != bbb', False),
- ('test aaa = aaa -a bbb = bbb', True),
-
- # Inversion within binary operators.
-
- ('test ! aaa != aaa -o ! bbb != bbb', True),
- ('test ! aaa != aaa -o ! bbb = bbb', True),
- ('test ! aaa = aaa -o ! bbb != bbb', True),
- ('test ! aaa = aaa -o ! bbb = bbb', False),
-
- ('test ! ! aaa != aaa -o ! ! bbb != bbb', False),
- ('test ! ! aaa != aaa -o ! ! bbb = bbb', True),
- ('test ! ! aaa = aaa -o ! ! bbb != bbb', True),
- ('test ! ! aaa = aaa -o ! ! bbb = bbb', True),
-)
-
-def exec_hush_if(u_boot_console, expr, result):
- """Execute a shell "if" command, and validate its result."""
-
- config = u_boot_console.config.buildconfig
- maxargs = int(config.get('config_sys_maxargs', '0'))
- args = len(expr.split(' ')) - 1
- if args > maxargs:
- u_boot_console.log.warning('CONFIG_SYS_MAXARGS too low; need ' +
- str(args))
- pytest.skip()
-
- cmd = 'if ' + expr + '; then echo true; else echo false; fi'
- response = u_boot_console.run_command(cmd)
- assert response.strip() == str(result).lower()
-
-@pytest.mark.buildconfigspec('cmd_echo')
-@pytest.mark.parametrize('expr,result', subtests)
-def test_hush_if_test(u_boot_console, expr, result):
- """Test a single "if test" condition."""
-
- exec_hush_if(u_boot_console, expr, result)
-
-def test_hush_z(u_boot_console):
- """Test the -z operator"""
- u_boot_console.run_command('setenv ut_var_nonexistent')
- u_boot_console.run_command('setenv ut_var_exists 1')
- exec_hush_if(u_boot_console, 'test -z "$ut_var_nonexistent"', True)
- exec_hush_if(u_boot_console, 'test -z "$ut_var_exists"', False)
- u_boot_console.run_command('setenv ut_var_exists')
-
-# We might test this on real filesystems via UMS, DFU, 'save', etc.
-# Of those, only UMS currently allows file removal though.
-@pytest.mark.buildconfigspec('cmd_echo')
-@pytest.mark.boardspec('sandbox')
-def test_hush_if_test_host_file_exists(u_boot_console):
- """Test the "if test -e" shell command."""
-
- test_file = u_boot_console.config.result_dir + \
- '/creating_this_file_breaks_u_boot_tests'
-
- try:
- os.unlink(test_file)
- except:
- pass
- assert not os.path.exists(test_file)
-
- expr = 'test -e hostfs - ' + test_file
- exec_hush_if(u_boot_console, expr, False)
-
- try:
- with open(test_file, 'wb'):
- pass
- assert os.path.exists(test_file)
-
- expr = 'test -e hostfs - ' + test_file
- exec_hush_if(u_boot_console, expr, True)
- finally:
- os.unlink(test_file)
-
- expr = 'test -e hostfs - ' + test_file
- exec_hush_if(u_boot_console, expr, False)
--
2.25.1
next prev parent reply other threads:[~2022-02-06 18:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 18:36 [RFC PATCH v2 00/21] Modernize U-Boot shell Francis Laniel
2022-02-06 18:36 ` [RFC PATCH v2 01/21] test: Add framework to test hush behavior Francis Laniel
2022-02-06 18:36 ` [RFC PATCH v2 02/21] test: hush: Test hush if/else Francis Laniel
2022-02-06 18:36 ` Francis Laniel [this message]
2022-02-06 18:37 ` [RFC PATCH v2 04/21] test: hush: Test hush variable expansion Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 05/21] test: hush: Test hush commands list Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 06/21] test: hush: Test hush loops Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 07/21] cli: Add Busybox upstream hush.c file Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 08/21] cli: Port Busybox 2021 hush to U-Boot Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 09/21] cli: Add choice for hush parser Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 10/21] cli: Add HUSH_2021_PARSER to hush parser choice Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 11/21] cli: Enables using hush 2021 parser as command line parser Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 12/21] cli: hush_2021: Enable variables expansion for hush 2021 Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 13/21] cli: hush_2021: Add functions to be called from run_command() Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 14/21] cli: Modify run_command() to add hush 2021 as parser Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 15/21] test: hush: Fix instructions list tests for hush 2021 Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 16/21] test: hush: Fix variable expansion " Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 17/21] cli: hush_2021: Enable using \< and \> as string compare operators Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 18/21] cli: hush_2021: Enable if keyword Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 19/21] test: hush: Fix if tests for hush 2021 Francis Laniel
2022-02-06 19:07 ` Marek Behún
2022-02-06 18:37 ` [RFC PATCH v2 20/21] cli: hush_2021: Enable loops Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 21/21] test: hush: Fix loop tests for hush 2021 Francis Laniel
2022-02-06 19:07 ` Marek Behún
2022-02-06 18:54 ` [RFC PATCH v2 00/21] Modernize U-Boot shell Heinrich Schuchardt
2022-02-08 15:28 ` Tom Rini
2022-02-08 15:32 ` Simon Glass
2022-02-18 20:51 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220206183717.57446-4-francis.laniel@amarulasolutions.com \
--to=francis.laniel@amarulasolutions.com \
--cc=hws@denx.de \
--cc=marek.behun@nic.cz \
--cc=michael@amarulasolutions.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox