Re: [RFC PATCH v2 00/21] Modernize U-Boot shell

Simon Glass
2022-02-08T15:32:43Z

Hi,

On Tue, 8 Feb 2022 at 08:28, Tom Rini <trini@konsulko.com> wrote:
>
> On Sun, Feb 06, 2022 at 07:54:26PM +0100, Heinrich Schuchardt wrote:
> > On 2/6/22 19:36, Francis Laniel wrote:
> > > Hi.
> > >
> > > First I hope you are fine and the same for your relatives.
> > >
> > > During 2021 summer, Sean Anderson wrote a contribution to add a new shell, based
> > > on LIL, to U-Boot [1][2].
> > > While one of the goals of this contribution was to address the fact actual
> > > U-Boot shell, which is based on Busybox hush, is old there was a discussion
> > > about adding a new shell versus updating the actual one [3][4].
> > >
> > > So, in this series, with Harald Seiler, we updated the actual U-Boot shell to
> > > reflect what is currently in Busybox source code.
> > > Basically, this contribution is about taking a snapshot of Busybox shell/hush.c
> > > file (as it exists in commit 37460f5da) and adapt it to suit U-Boot needs.
> > >
> > > This contribution was written to be as backward-compatible as possible to avoid
> > > breaking the existing.
> > > So, the 2021 hush flavor offers the same as the actual, that is to say:
> > > 1. Variable expansion.
> > > 2. Instruction lists (;, && and ||).
> > > 3. If, then and else.
> > > 4. Loops (for, while and until).
> > > No new features offered by Busybox hush were implemented (e.g. functions).
> >
> > If no new features are added relative to what we have, why should we add
> > 12000 lines of code? Please, describe the benefit of the series.
>
> Please see the referenced threads for a longer discussion of why this is
> being looked at.

It was also discussed at length in a U-Boot contributor call.

https://docs.google.com/document/d/1YBOMsbM19uSFyoJWnt7-PsOLBaevzQUgV-hiR88a5-o/edit#bookmark=id.j6h2xzste5sy

I know you cannot attend the meetings, but it is a good idea to check
the notes every now and then :-)

>
> > Is there a repo with your patches?
>
> Note that "b4 am -o - 20220206183717.57446-1-francis.laniel@amarulasolutions.com | git am -3"
> applies cleanly.

Regards,
Simon