From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75F2EC433F5 for ; Sun, 6 Feb 2022 19:07:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 20E4D83BC5; Sun, 6 Feb 2022 20:07:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 478DA83BC5; Sun, 6 Feb 2022 20:07:22 +0100 (CET) Received: from mail.nic.cz (mail.nic.cz [217.31.204.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A098583BC5 for ; Sun, 6 Feb 2022 20:07:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from thinkpad (unknown [IPv6:2a0e:b107:ae1:0:3e97:eff:fe61:c680]) by mail.nic.cz (Postfix) with ESMTPSA id 94F6C14116D; Sun, 6 Feb 2022 20:07:18 +0100 (CET) Date: Sun, 6 Feb 2022 20:07:17 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Francis Laniel Cc: u-boot@lists.denx.de, Michael Nazzareno Trimarchi , Simon Glass , Wolfgang Denk , Harald Seiler Subject: Re: [RFC PATCH v2 21/21] test: hush: Fix loop tests for hush 2021 Message-ID: <20220206200717.65caa076@thinkpad> In-Reply-To: <20220206183717.57446-22-francis.laniel@amarulasolutions.com> References: <20220206183717.57446-1-francis.laniel@amarulasolutions.com> <20220206183717.57446-22-francis.laniel@amarulasolutions.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Sun, 6 Feb 2022 19:37:17 +0100 Francis Laniel wrote: > Modifies return code got from while loop as hush 2021 always returns 0 from > while loop. > > Signed-off-by: Francis Laniel > Reviewed-by: Simon Glass > --- > test/hush/loop.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/test/hush/loop.c b/test/hush/loop.c > index 519c78ef7e..56aae719dc 100644 > --- a/test/hush/loop.c > +++ b/test/hush/loop.c > @@ -20,7 +20,12 @@ static int hush_test_for(struct unit_test_state *uts) > ut_assert_nextline("quux"); > ut_assert_console_end(); > > +#if CONFIG_IS_ENABLED(HUSH_2021_PARSER) No macro. Use ordinary if-else statements please. Marek