From: "Marek Behún" <marek.behun@nic.cz>
To: Francis Laniel <francis.laniel@amarulasolutions.com>
Cc: u-boot@lists.denx.de,
Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
Simon Glass <sjg@chromium.org>, Wolfgang Denk <wd@denx.de>,
Harald Seiler <hws@denx.de>
Subject: Re: [RFC PATCH v2 19/21] test: hush: Fix if tests for hush 2021
Date: Sun, 6 Feb 2022 20:07:46 +0100 [thread overview]
Message-ID: <20220206200746.02472f76@thinkpad> (raw)
In-Reply-To: <20220206183717.57446-20-francis.laniel@amarulasolutions.com>
On Sun, 6 Feb 2022 19:37:15 +0100
Francis Laniel <francis.laniel@amarulasolutions.com> wrote:
> Modifies the command run for hush 2021 when using string comparison operator.
> Indeed, '<' and '>' must be escaped to be used as these operators.
>
> Signed-off-by: Francis Laniel <francis.laniel@amarulasolutions.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
> test/hush/if.c | 43 +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/test/hush/if.c b/test/hush/if.c
> index a57d88850f..b2f1f247f5 100644
> --- a/test/hush/if.c
> +++ b/test/hush/if.c
> @@ -39,6 +39,10 @@ static int hush_test_if_basic_operators(struct unit_test_state *uts)
> {
> char if_formatted[128];
>
> +#if CONFIG_IS_ENABLED(HUSH_2021_PARSER)
> + console_record_reset_enable();
> +#endif /* HUSH_2021_PARSER */
Ordinary if-else statements please.
Marek
next prev parent reply other threads:[~2022-02-06 19:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 18:36 [RFC PATCH v2 00/21] Modernize U-Boot shell Francis Laniel
2022-02-06 18:36 ` [RFC PATCH v2 01/21] test: Add framework to test hush behavior Francis Laniel
2022-02-06 18:36 ` [RFC PATCH v2 02/21] test: hush: Test hush if/else Francis Laniel
2022-02-06 18:36 ` [RFC PATCH v2 03/21] test/py: hush_if_test: Remove the test file Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 04/21] test: hush: Test hush variable expansion Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 05/21] test: hush: Test hush commands list Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 06/21] test: hush: Test hush loops Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 07/21] cli: Add Busybox upstream hush.c file Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 08/21] cli: Port Busybox 2021 hush to U-Boot Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 09/21] cli: Add choice for hush parser Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 10/21] cli: Add HUSH_2021_PARSER to hush parser choice Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 11/21] cli: Enables using hush 2021 parser as command line parser Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 12/21] cli: hush_2021: Enable variables expansion for hush 2021 Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 13/21] cli: hush_2021: Add functions to be called from run_command() Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 14/21] cli: Modify run_command() to add hush 2021 as parser Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 15/21] test: hush: Fix instructions list tests for hush 2021 Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 16/21] test: hush: Fix variable expansion " Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 17/21] cli: hush_2021: Enable using \< and \> as string compare operators Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 18/21] cli: hush_2021: Enable if keyword Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 19/21] test: hush: Fix if tests for hush 2021 Francis Laniel
2022-02-06 19:07 ` Marek Behún [this message]
2022-02-06 18:37 ` [RFC PATCH v2 20/21] cli: hush_2021: Enable loops Francis Laniel
2022-02-06 18:37 ` [RFC PATCH v2 21/21] test: hush: Fix loop tests for hush 2021 Francis Laniel
2022-02-06 19:07 ` Marek Behún
2022-02-06 18:54 ` [RFC PATCH v2 00/21] Modernize U-Boot shell Heinrich Schuchardt
2022-02-08 15:28 ` Tom Rini
2022-02-08 15:32 ` Simon Glass
2022-02-18 20:51 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220206200746.02472f76@thinkpad \
--to=marek.behun@nic.cz \
--cc=francis.laniel@amarulasolutions.com \
--cc=hws@denx.de \
--cc=michael@amarulasolutions.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox