From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 833C4C433F5 for ; Mon, 7 Feb 2022 03:00:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 523D883BFB; Mon, 7 Feb 2022 04:00:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="UqiALjcV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3A50683C22; Mon, 7 Feb 2022 04:00:29 +0100 (CET) Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D303F831B5 for ; Mon, 7 Feb 2022 04:00:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pj1-x1029.google.com with SMTP id r64-20020a17090a43c600b001b8854e682eso4147089pjg.0 for ; Sun, 06 Feb 2022 19:00:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=6tTSKKfPMrI5RCG7jGBqjwYCx5pMoBELF5k1Pd8q0ZI=; b=UqiALjcVpJ7a8t8TUpa+K+XvTSMT+kGTAdWsKhWY9MktVBRbEwf0dZAp974HLrLf0v /MCuMSpAZUE9Cob6HbeCrYT8soKQ7jAGB8voiuRPmPdP5Accx/TYPGXF3e3JYM4R1/bV Wy34PrdOiApiWS/9tQCGN5g9dGvCdyrIPR8Pgl+AXRNOPIFZVOnYMcAu5+NhoCFcwAtF 1qiEXLM38DTORBKiX2Pqdnkpqz3OqOjpDy7gt6Y7iXFwDg46/RzQQYpPhwd5DGDY+U3h 9/cjer085aXGVaRDx9a7+a4KlxSDjZR5QiBd9QmtRVumnJtlk02f5VrC3Ry3Z8Qn9EEz dk/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=6tTSKKfPMrI5RCG7jGBqjwYCx5pMoBELF5k1Pd8q0ZI=; b=pe64wLo5EQuA/WaA6JoL8On5nF3NalXsgD8C+Y/LOrkfYTg70A8GOGoAxSEPD55iod LzlK2MoLs2P5Q31EUIXjzYj3RDUC37zfnDthwvfunBUDJ4DnCNE98lR8lAoMof+Q7m/2 86Qwp13ZhYAK/42kbuQJIG81HXQ9t1gVli7i+PiCIN6qRNpBkb+RQl27OjoSnugsS0go MlBLGOhTOBYsByrm7EmkV9GwcsoziP/NYF98XPTvT9iZ2/R1cd7V7/humJ/dfpQCJLfh LfIDwtj781mEwBpXnJR85IhSx8qzaF1FKdJMgnDr2dBugEGzNgQS2LqDrYvOmkwS5Og8 XGDw== X-Gm-Message-State: AOAM531kf+XSGahVSnN3pgrkDcW/mnuwO6kkcf1+LCMcDmR9qE9PRXTa Q00xE33XZaW3ZH2uX2Erlv9zkA== X-Google-Smtp-Source: ABdhPJy5QWRiwbcKNNfvQyMVeZ1GPX2RkoGFs3Ux3t3Rzw5cGoejq/KEdGGcBO+7farVr83bYT7qFA== X-Received: by 2002:a17:90b:4c0e:: with SMTP id na14mr11793433pjb.164.1644202821925; Sun, 06 Feb 2022 19:00:21 -0800 (PST) Received: from laputa ([2400:4050:c3e1:100:ecd4:c151:c93a:2608]) by smtp.gmail.com with ESMTPSA id z27sm6759989pgk.78.2022.02.06.19.00.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Feb 2022 19:00:21 -0800 (PST) Date: Mon, 7 Feb 2022 12:00:16 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: sjg@chromium.org, ilias.apalodimas@linaro.org, sughosh.ganu@linaro.org, masami.hiramatsu@linaro.org, mark.kettenis@xs4all.nl, u-boot@lists.denx.de Subject: Re: [PATCH v10 6/9] tools: mkeficapsule: allow for specifying GUID explicitly Message-ID: <20220207030016.GA41683@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , sjg@chromium.org, ilias.apalodimas@linaro.org, sughosh.ganu@linaro.org, masami.hiramatsu@linaro.org, mark.kettenis@xs4all.nl, u-boot@lists.denx.de References: <20220201012740.63070-1-takahiro.akashi@linaro.org> <20220201012740.63070-7-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Sat, Feb 05, 2022 at 08:32:37PM +0100, Heinrich Schuchardt wrote: > On 2/1/22 02:27, AKASHI Takahiro wrote: > > The existing options, "--fit" and "--raw," are only used to put a proper > > GUID in a capsule header, where GUID identifies a particular FMP (Firmware > > Management Protocol) driver which then would handle the firmware binary in > > a capsule. In fact, mkeficapsule does the exact same job in creating > > a capsule file whatever the firmware binary type is. > > > > To prepare for the future extension, the command syntax will be a bit > > modified to allow users to specify arbitrary GUID for their own FMP driver. > > OLD: > > [--fit | --raw ] > > NEW: > > [--fit | --raw | --guid ] u > > > > Signed-off-by: AKASHI Takahiro > > Reviewed-by: Simon Glass > > --- > > doc/develop/uefi/uefi.rst | 4 +- > > doc/mkeficapsule.1 | 26 ++++++++---- > > tools/Makefile | 2 +- > > tools/mkeficapsule.c | 85 ++++++++++++++++++++++++++++----------- > > 4 files changed, 84 insertions(+), 33 deletions(-) > > > > diff --git a/doc/develop/uefi/uefi.rst b/doc/develop/uefi/uefi.rst > > index 7e1eb8256259..a1a2afd60bbc 100644 > > --- a/doc/develop/uefi/uefi.rst > > +++ b/doc/develop/uefi/uefi.rst > > @@ -375,8 +375,8 @@ and used by the steps highlighted below. > > --private-key CRT.key \ > > --certificate CRT.crt \ > > --index 1 --instance 0 \ > > - [--fit | --raw ] \ > > - > > + [--fit | --raw | --guid > + > > > > 4. Insert the signature list into a device tree in the following format:: > > > > diff --git a/doc/mkeficapsule.1 b/doc/mkeficapsule.1 > > index 680362f5c4e9..8babb27ee8b2 100644 > > --- a/doc/mkeficapsule.1 > > +++ b/doc/mkeficapsule.1 > > @@ -8,7 +8,7 @@ mkeficapsule \- Generate EFI capsule file for U-Boot > > > > .SH SYNOPSIS > > .B mkeficapsule > > -.RI [ options "] " capsule-file > > +.RI [ options "] " image-blob " " capsule-file > > > > .SH "DESCRIPTION" > > .B mkeficapsule > > @@ -24,7 +24,7 @@ In this case, the update will be authenticated by verifying the signature > > before applying. > > > > .B mkeficapsule > > -supports two different format of image files: > > +takes any type of image files, including: > > .TP > > .I raw image > > format is a single binary blob of any type of firmware. > > @@ -36,18 +36,30 @@ multiple binary blobs in a single capsule file. > > This type of image file can be generated by > > .BR mkimage . > > > > +.PP > > +If you want to use other types than above two, you should explicitly > > +specify a guid for the FMP driver. > > + > > .SH "OPTIONS" > > One of > > -.BR --fit " or " --raw > > +.BR --fit ", " --raw " or " --guid > > option must be specified. > > > > .TP > > -.BI "-f\fR,\fB --fit " fit-image-file > > -Specify a FIT image file > > +.BR -f ", " --fit > > +Indicate that the blob is a FIT image file > > > > .TP > > -.BI "-r\fR,\fB --raw " raw-image-file > > -Specify a raw image file > > +.BR -r ", " --raw > > +Indicate that the blob is a raw image file > > + > > +.TP > > +.BI "-g\fR,\fB --guid " guid-string > > +Specify guid for image blob type. The format is: > > + xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx > > + > > +The first three elements are in little endian, while the rest > > +is in big endian. > > > > .TP > > .BI "-i\fR,\fB --index " index > > diff --git a/tools/Makefile b/tools/Makefile > > index 8da07d60a755..5409ff2879c6 100644 > > --- a/tools/Makefile > > +++ b/tools/Makefile > > @@ -238,7 +238,7 @@ hostprogs-$(CONFIG_MIPS) += mips-relocs > > hostprogs-$(CONFIG_ASN1_COMPILER) += asn1_compiler > > HOSTCFLAGS_asn1_compiler.o = -idirafter $(srctree)/include > > > > -HOSTLDLIBS_mkeficapsule += -lgnutls > > +HOSTLDLIBS_mkeficapsule += -lgnutls -luuid > > hostprogs-$(CONFIG_TOOLS_MKEFICAPSULE) += mkeficapsule > > > > # We build some files with extra pedantic flags to try to minimize things > > diff --git a/tools/mkeficapsule.c b/tools/mkeficapsule.c > > index b996c66ad26a..7ff1f999db85 100644 > > --- a/tools/mkeficapsule.c > > +++ b/tools/mkeficapsule.c > > @@ -15,7 +15,7 @@ > > > > #include > > #include > > - > > +#include > > https://dev.azure.com/u-boot/a1096300-2999-4ec4-a21a-4c22075e3771/_apis/build/builds/3589/logs/128: > > 2022-02-05T16:53:55.9574749Z HOSTCC tools/mkeficapsule > 2022-02-05T16:53:56.1341775Z tools/mkeficapsule.c:18:10: fatal error: > uuid/uuid.h: No such file or directory > 2022-02-05T16:53:56.1343964Z 18 | #include > 2022-02-05T16:53:56.1344702Z | ^~~~~~~~~~~~~ > 2022-02-05T16:53:56.1347501Z compilation terminated. > 2022-02-05T16:53:56.1392680Z make[2]: *** [scripts/Makefile.host:95: > tools/mkeficapsule] Error 1 > > Instead of adding a dependency on uuid-dev (linux-utils) it might be > better to write your own uuid_parse() function. I don't want to re-invent a library function even if it looks quite easy. Looking at azure-pipelines.yml, the build process makes use of msys2 on Windows and brew on MacOS. Adding dependencies seems not difficult (although I don't know the exact package names for the library and headers). Apparently, this is not only about libuuid but also libgnutls. Please note, in addition, that there is no current user for "--guid" option. We may drop this patch for now if appropriate. -Takahiro Akashi > https://u-boot.readthedocs.io/en/latest/develop/ci_testing.html > describes how to trigger the Azure pipelines using a pull request on Github. > > Please, trigger the test before resubmitting. > > Best regards > > Heinrich > > > #include > > > > #include > > @@ -33,11 +33,12 @@ efi_guid_t efi_guid_image_type_uboot_raw = > > EFI_FIRMWARE_IMAGE_TYPE_UBOOT_RAW_GUID; > > efi_guid_t efi_guid_cert_type_pkcs7 = EFI_CERT_TYPE_PKCS7_GUID; > > > > -static const char *opts_short = "f:r:i:I:v:p:c:m:dh"; > > +static const char *opts_short = "frg:i:I:v:p:c:m:dh"; > > > > static struct option options[] = { > > - {"fit", required_argument, NULL, 'f'}, > > - {"raw", required_argument, NULL, 'r'}, > > + {"fit", no_argument, NULL, 'f'}, > > + {"raw", no_argument, NULL, 'r'}, > > + {"guid", required_argument, NULL, 'g'}, > > {"index", required_argument, NULL, 'i'}, > > {"instance", required_argument, NULL, 'I'}, > > {"private-key", required_argument, NULL, 'p'}, > > @@ -50,11 +51,12 @@ static struct option options[] = { > > > > static void print_usage(void) > > { > > - printf("Usage: %s [options] \n" > > + fprintf(stderr, "Usage: %s [options] \n" > > "Options:\n" > > > > - "\t-f, --fit new FIT image file\n" > > - "\t-r, --raw new raw image file\n" > > + "\t-f, --fit FIT image type\n" > > + "\t-r, --raw raw image type\n" > > + "\t-g, --guid guid for image blob type\n" > > "\t-i, --index update image index\n" > > "\t-I, --instance update hardware instance\n" > > "\t-p, --private-key private key file\n" > > @@ -541,6 +543,37 @@ err: > > return ret; > > } > > > > +/** > > + * convert_uuid_to_guid() - convert UUID to GUID > > + * @buf: UUID binary > > + * > > + * UUID and GUID have the same data structure, but their binary > > + * formats are different due to the endianness. See lib/uuid.c. > > + * Since uuid_parse() can handle only UUID, this function must > > + * be called to get correct data for GUID when parsing a string. > > + * > > + * The correct data will be returned in @buf. > > + */ > > +void convert_uuid_to_guid(unsigned char *buf) > > +{ > > + unsigned char c; > > + > > + c = buf[0]; > > + buf[0] = buf[3]; > > + buf[3] = c; > > + c = buf[1]; > > + buf[1] = buf[2]; > > + buf[2] = c; > > + > > + c = buf[4]; > > + buf[4] = buf[5]; > > + buf[5] = c; > > + > > + c = buf[6]; > > + buf[6] = buf[7]; > > + buf[7] = c; > > +} > > + > > /** > > * main - main entry function of mkeficapsule > > * @argc: Number of arguments > > @@ -555,14 +588,13 @@ err: > > */ > > int main(int argc, char **argv) > > { > > - char *file; > > efi_guid_t *guid; > > + unsigned char uuid_buf[16]; > > unsigned long index, instance; > > uint64_t mcount; > > char *privkey_file, *cert_file; > > int c, idx; > > > > - file = NULL; > > guid = NULL; > > index = 0; > > instance = 0; > > @@ -577,21 +609,34 @@ int main(int argc, char **argv) > > > > switch (c) { > > case 'f': > > - if (file) { > > - fprintf(stderr, "Image already specified\n"); > > + if (guid) { > > + fprintf(stderr, > > + "Image type already specified\n"); > > exit(EXIT_FAILURE); > > } > > - file = optarg; > > guid = &efi_guid_image_type_uboot_fit; > > break; > > case 'r': > > - if (file) { > > - fprintf(stderr, "Image already specified\n"); > > + if (guid) { > > + fprintf(stderr, > > + "Image type already specified\n"); > > exit(EXIT_FAILURE); > > } > > - file = optarg; > > guid = &efi_guid_image_type_uboot_raw; > > break; > > + case 'g': > > + if (guid) { > > + fprintf(stderr, > > + "Image type already specified\n"); > > + exit(EXIT_FAILURE); > > + } > > + if (uuid_parse(optarg, uuid_buf)) { > > + fprintf(stderr, "Wrong guid format\n"); > > + exit(EXIT_FAILURE); > > + } > > + convert_uuid_to_guid(uuid_buf); > > + guid = (efi_guid_t *)uuid_buf; > > + break; > > case 'i': > > index = strtoul(optarg, NULL, 0); > > break; > > @@ -627,20 +672,14 @@ int main(int argc, char **argv) > > } > > > > /* check necessary parameters */ > > - if ((argc != optind + 1) || !file || > > + if ((argc != optind + 2) || !guid || > > ((privkey_file && !cert_file) || > > (!privkey_file && cert_file))) { > > print_usage(); > > exit(EXIT_FAILURE); > > } > > > > - /* need a fit image file or raw image file */ > > - if (!file) { > > - print_usage(); > > - exit(EXIT_SUCCESS); > > - } > > - > > - if (create_fwbin(argv[optind], file, guid, index, instance, > > + if (create_fwbin(argv[argc - 1], argv[argc - 2], guid, index, instance, > > mcount, privkey_file, cert_file) < 0) { > > fprintf(stderr, "Creating firmware capsule failed\n"); > > exit(EXIT_FAILURE); >