From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13E76C433EF for ; Tue, 8 Feb 2022 15:28:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9AAC683910; Tue, 8 Feb 2022 16:28:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="YwL/GMv8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 46181811BA; Tue, 8 Feb 2022 16:28:14 +0100 (CET) Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E95E083CCA for ; Tue, 8 Feb 2022 16:28:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2d.google.com with SMTP id h9so4546111qvm.0 for ; Tue, 08 Feb 2022 07:28:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VLk9kLTJIDZlUoaIzdXO2dCmqU8XQU0+mzyGXKeV0Hc=; b=YwL/GMv8TPc4PiGYMt1tEZmCQpAcE0eA5HtTtoTCe3KBQKG1oU2uKZueflIDU9Y9/M njBi/QMZ5iNQimFyDRKGItdxg4C382QGBpdOAsyLaRfMT5tMlXW6PqtON5yDu5XVKVlz tPXN8rg5Yi/wEvtRd+imuF1YrfGx0i2GjWeCY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VLk9kLTJIDZlUoaIzdXO2dCmqU8XQU0+mzyGXKeV0Hc=; b=POWhAJc4eg8789vLpVU09ZtU4VIbRBh1RXcsgwkHQiQVO//jvhRUbj4U2L38ZrC1E0 QyBqWZrvE49i8SyNMqLmYa2lWJzije2vgPiKxNz/xTh3ISrrMjF5W5oD7VwZrx6c/BGx 1dzEmvvBIr0OLwcavNt7oJa9Wnv8GauUKQ404yIbwU8NsJE3y6OJA2LmMBd+nMc/Fg95 xfQWjOSusAKzEJ22S5ZRJUOzGZ7njlJidwRYFbdPewH6Bdn/Z5KrusmVDExqmYv9OLL0 YXZj9x+ppggeG7k88/pViN+k3Ypc/qWNyHq1G7EHcfuGkOg6zrFW9sSatBeky3mQPn2q V02A== X-Gm-Message-State: AOAM531HSiJtOcJDnacEPX6YV6Fk54OGny1p/jdEK8A0XF/pBGw4uhTg vA8EQ8OWk8c4qCfM9/9JzPsGqA== X-Google-Smtp-Source: ABdhPJxNBIhH3IlUOd/cPasTNqIY1S7k+tc3+FI7+RJHXNqUeJKJK9JgBktzscEwOq8zZ77+hbbk0w== X-Received: by 2002:ad4:5aaa:: with SMTP id u10mr3495603qvg.123.1644334088745; Tue, 08 Feb 2022 07:28:08 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id c7sm7550728qtd.12.2022.02.08.07.28.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 07:28:08 -0800 (PST) Date: Tue, 8 Feb 2022 10:28:06 -0500 From: Tom Rini To: Heinrich Schuchardt Cc: Francis Laniel , Marek Behun , Michael Nazzareno Trimarchi , Simon Glass , Wolfgang Denk , Harald Seiler , u-boot@lists.denx.de Subject: Re: [RFC PATCH v2 00/21] Modernize U-Boot shell Message-ID: <20220208152806.GP7515@bill-the-cat> References: <20220206183717.57446-1-francis.laniel@amarulasolutions.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="O4mGAVrr2vwGVaZ3" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --O4mGAVrr2vwGVaZ3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 06, 2022 at 07:54:26PM +0100, Heinrich Schuchardt wrote: > On 2/6/22 19:36, Francis Laniel wrote: > > Hi. > >=20 > > First I hope you are fine and the same for your relatives. > >=20 > > During 2021 summer, Sean Anderson wrote a contribution to add a new she= ll, based > > on LIL, to U-Boot [1][2]. > > While one of the goals of this contribution was to address the fact act= ual > > U-Boot shell, which is based on Busybox hush, is old there was a discus= sion > > about adding a new shell versus updating the actual one [3][4]. > >=20 > > So, in this series, with Harald Seiler, we updated the actual U-Boot sh= ell to > > reflect what is currently in Busybox source code. > > Basically, this contribution is about taking a snapshot of Busybox shel= l/hush.c > > file (as it exists in commit 37460f5da) and adapt it to suit U-Boot nee= ds. > >=20 > > This contribution was written to be as backward-compatible as possible = to avoid > > breaking the existing. > > So, the 2021 hush flavor offers the same as the actual, that is to say: > > 1. Variable expansion. > > 2. Instruction lists (;, && and ||). > > 3. If, then and else. > > 4. Loops (for, while and until). > > No new features offered by Busybox hush were implemented (e.g. function= s). >=20 > If no new features are added relative to what we have, why should we add > 12000 lines of code? Please, describe the benefit of the series. Please see the referenced threads for a longer discussion of why this is being looked at. > Is there a repo with your patches? Note that "b4 am -o - 20220206183717.57446-1-francis.laniel@amarulasolution= s.com | git am -3" applies cleanly. --=20 Tom --O4mGAVrr2vwGVaZ3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmICjAYACgkQFHw5/5Y0 tyxzPQv/Tv4UUO9LSo8Cf06EjmGj15k1cklvvpfup3huObtvV02Te3HqWyaE2aKM zIJiMTa0cfV6k6LhAMGlbR08/h1wHKBoKfLEdp8zmb56ZxY9T4rjJdI8xrg6sRLd XuxhzZ7+dypl2TJqp5yjCoGBkfftqmIlNR1aygZiSW/hwuRKku9Q4py7W37pfDzu KB0bFWNVMG25NDJprpXjKKasjE9xFdUOiYRBmkw0X5YfkcjEGl+cCuCNOK+s2tXO a6d8B/TdN+7egEZRKNtGFJJ5x/Y0AJ6Cnj0UCU3A5hyzVeoeEANfqYfU+x1lyGe0 8T4OoU/jkkeYz0kULwjfgO15laM5xsWnzwsxiclPrPFDBmtjF3/S4EuBBDoVaZNy Qy6o6JhVejkV6cPY9xvb5QDIGprCSIQ+acWOIAOyIeTbdaE2fjggvTUqXHNcV5S4 Rm/mQzkxsMFtMPeV2JK4oZRKotDUn/LfqcXT6pjQ2l4SogupAXWZndtb7JqViuEt IKdZ58g+ =U7CI -----END PGP SIGNATURE----- --O4mGAVrr2vwGVaZ3--