Re: [PATCH 2/2] net: phy: mv88e6352: Fix miiphy_read/miiphy_write return value checks

Ramon Fried
2022-02-15T07:09:02Z

On Mon, Feb 14, 2022 at 12:33 PM Daniel Klauer <daniel.klauer@gin.de> wrote:
>
> On 12.02.22 12:50, Ramon Fried wrote:
> > On Wed, Feb 9, 2022 at 5:41 PM Daniel Klauer <daniel.klauer@gin.de> wrote:
> >>
> >> The miiphy_read/miiphy_write functions return 1 on error, not -errno.
> > Why don't you just fix the miiphy_read/miiphy_write functions ?
>
> Other functions from that module do the same, so I assumed it's intentional.
> It could be fixed too though, with a corresponding fix up of the few callers
> that expect the positive return value on error.
Sometimes a real fix needs more work.
What caused you to change it on your side to -EIO, is there someone
checking for EIO in the framework code ?