Re: [PATCH 2/2] net: phy: mv88e6352: Fix miiphy_read/miiphy_write return value checks

Daniel Klauer
2022-02-14T10:34:08Z

On 12.02.22 12:50, Ramon Fried wrote:
> On Wed, Feb 9, 2022 at 5:41 PM Daniel Klauer <daniel.klauer@gin.de> wrote:
>>
>> The miiphy_read/miiphy_write functions return 1 on error, not -errno.
> Why don't you just fix the miiphy_read/miiphy_write functions ?

Other functions from that module do the same, so I assumed it's intentional.
It could be fixed too though, with a corresponding fix up of the few callers
that expect the positive return value on error.