From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Jaehoon Chung <jh80.chung@samsung.com>,
Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH v5 03/13] mmc: fsl: Use brackets around if()
Date: Wed, 9 Feb 2022 11:37:42 -0500 [thread overview]
Message-ID: <20220209163742.GE7515@bill-the-cat> (raw)
In-Reply-To: <20220122050728.v5.3.I1dc474c992ec58cc19f8053464c13e50efa56c14@changeid>
[-- Attachment #1: Type: text/plain, Size: 406 bytes --]
On Sat, Jan 22, 2022 at 05:07:24AM -0700, Simon Glass wrote:
> At present the IS_ENABLED() macro has extra brackets, making it possible
> to write:
>
> if IS_ENABLED(CONFIG_XXX)
>
> but it is a bit confusing. Add the missing brackets.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-02-09 16:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-22 12:07 [PATCH v5 00/13] kconfig: Add some new macros Simon Glass
2022-01-22 12:07 ` [PATCH v5 01/13] imx: Don't define __ASSEMBLY__ in source files Simon Glass
2022-02-09 16:37 ` Tom Rini
2022-01-22 12:07 ` [PATCH v5 02/13] mips: Avoid using config_enabled() directly Simon Glass
2022-02-09 16:37 ` Tom Rini
2022-01-22 12:07 ` [PATCH v5 03/13] mmc: fsl: Use brackets around if() Simon Glass
2022-01-26 23:17 ` Jaehoon Chung
2022-02-09 16:37 ` Tom Rini [this message]
2022-01-22 12:07 ` [PATCH v5 04/13] kconfig: Update IS_ENABLED() internals Simon Glass
2022-02-09 16:37 ` Tom Rini
2022-01-22 12:07 ` [PATCH v5 05/13] kconfig: Add support for conditional values Simon Glass
2022-02-09 16:37 ` Tom Rini
2022-01-22 12:07 ` [PATCH v5 06/13] bloblist: Update to use conditional value Simon Glass
2022-02-09 16:37 ` Tom Rini
2022-01-22 12:07 ` [PATCH v5 07/13] patman: Update test_util to run doc tests Simon Glass
2022-02-09 16:38 ` Tom Rini
2022-01-22 12:07 ` [PATCH v5 08/13] buildman: Add a flag to control the traceback Simon Glass
2022-02-09 16:38 ` Tom Rini
2022-01-22 12:07 ` [PATCH v5 09/13] buildman: Make use of test_util Simon Glass
2022-02-09 16:38 ` Tom Rini
2022-01-22 12:07 ` [PATCH v5 10/13] buildman: Add helper functions for updating .config files Simon Glass
2022-02-09 16:38 ` Tom Rini
2022-01-22 12:07 ` [PATCH v5 11/13] buildman: Provide a hint on how to debug thread crashes Simon Glass
2022-02-09 16:38 ` Tom Rini
2022-01-22 12:07 ` [PATCH v5 12/13] buildman: Allow adjusting board config on the fly Simon Glass
2022-02-09 16:38 ` Tom Rini
2022-01-22 12:07 ` [PATCH v5 13/13] test: Add some tests for kconfig.h Simon Glass
2022-02-09 14:57 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220209163742.GE7515@bill-the-cat \
--to=trini@konsulko.com \
--cc=jh80.chung@samsung.com \
--cc=peng.fan@nxp.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox