From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: lukma@denx.de, peng.fan@nxp.com, bmeng.cn@gmail.com,
peng.ma@nxp.com, sr@denx.de, xypron.glpk@gmx.de,
sjg@chromium.org, ilias.apalodimas@linaro.org,
masami.hiramatsu@linaro.org, u-boot@lists.denx.de
Subject: Re: [PATCH 03/19] mmc: call device_probe() after scanning
Date: Thu, 10 Feb 2022 12:45:09 +0900 [thread overview]
Message-ID: <20220210034509.GC12412@laputa> (raw)
In-Reply-To: <db9da9a6-dc4b-bffe-16cc-b5c2673b24e1@samsung.com>
On Wed, Feb 09, 2022 at 08:46:18AM +0900, Jaehoon Chung wrote:
> On 2/2/22 10:08, AKASHI Takahiro wrote:
> > Every time a mmc bus/port is scanned and a new device is detected,
> > we want to call device_probe() as it will give us a chance to run
> > additional post-processings for some purposes.
> >
> > In particular, support for creating partitions on a device will be added.
> >
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > ---
> > drivers/mmc/mmc-uclass.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c
> > index b80e838066ca..e918f58a212e 100644
> > --- a/drivers/mmc/mmc-uclass.c
> > +++ b/drivers/mmc/mmc-uclass.c
> > @@ -467,6 +467,18 @@ static int mmc_blk_probe(struct udevice *dev)
> > return ret;
> > }
> >
> > + ret = device_probe(dev);
> > + if (ret) {
> > + debug("Can't probe\n");
>
> how about displaying return value to debug?
Sure.
-Takahiro Akashi
> Best Regards,
> Jaehoon Chung
>
> > +
> > + if (IS_ENABLED(CONFIG_MMC_UHS_SUPPORT) ||
> > + IS_ENABLED(CONFIG_MMC_HS200_SUPPORT) ||
> > + IS_ENABLED(CONFIG_MMC_HS400_SUPPORT))
> > + mmc_deinit(mmc);
> > +
> > + return ret;
> > + }
> > +
> > return 0;
> > }
> >
>
next prev parent reply other threads:[~2022-02-10 3:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 1:08 [PATCH 00/19] efi_loader: more tightly integrate UEFI disks to driver model AKASHI Takahiro
2022-02-02 1:08 ` [PATCH 01/19] scsi: call device_probe() after scanning AKASHI Takahiro
2022-02-02 1:08 ` [PATCH 02/19] usb: storage: " AKASHI Takahiro
2022-02-02 1:08 ` [PATCH 03/19] mmc: " AKASHI Takahiro
2022-02-08 23:46 ` Jaehoon Chung
2022-02-10 3:45 ` AKASHI Takahiro [this message]
2022-02-02 1:08 ` [PATCH 04/19] nvme: " AKASHI Takahiro
2022-02-02 1:08 ` [PATCH 05/19] sata: " AKASHI Takahiro
2022-02-02 1:08 ` [PATCH 06/19] block: ide: " AKASHI Takahiro
2022-02-02 1:08 ` [PATCH 07/19] virtio: call device_probe() in scanning AKASHI Takahiro
2022-02-02 1:08 ` [PATCH 08/19] dm: add event notification AKASHI Takahiro
2022-02-05 8:59 ` Heinrich Schuchardt
2022-02-02 1:08 ` [PATCH 09/19] dm: add tag support AKASHI Takahiro
2022-02-05 9:34 ` Heinrich Schuchardt
2022-02-02 1:08 ` [PATCH 10/19] dm: tag: add some document AKASHI Takahiro
2022-02-02 1:08 ` [PATCH 11/19] test: dm: add tests for tag support AKASHI Takahiro
2022-02-02 1:08 ` [PATCH 12/19] dm: disk: add UCLASS_PARTITION AKASHI Takahiro
2022-02-02 1:08 ` [PATCH 13/19] dm: blk: add a device-probe hook for scanning disk partitions AKASHI Takahiro
2022-02-02 1:08 ` [PATCH 14/19] efi_loader: disk: a helper function to create efi_disk objects from udevice AKASHI Takahiro
2022-02-02 1:08 ` [PATCH 15/19] efi_loader: disk: a helper function to delete efi_disk objects AKASHI Takahiro
2022-02-02 1:08 ` [PATCH 16/19] dm: disk: add read/write interfaces with udevice AKASHI Takahiro
2022-02-02 1:08 ` [PATCH 17/19] efi_loader: disk: use udevice instead of blk_desc AKASHI Takahiro
2022-02-05 9:02 ` Heinrich Schuchardt
2022-02-02 1:08 ` [PATCH 18/19] efi_loader: disk: not create BLK device for BLK(IF_TYPE_EFI_LOADER) devices AKASHI Takahiro
2022-02-02 1:08 ` [PATCH 19/19] efi_driver: align with efi_disk-dm integration AKASHI Takahiro
2022-02-05 9:39 ` [PATCH 00/19] efi_loader: more tightly integrate UEFI disks to driver model Heinrich Schuchardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220210034509.GC12412@laputa \
--to=takahiro.akashi@linaro.org \
--cc=bmeng.cn@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jh80.chung@samsung.com \
--cc=lukma@denx.de \
--cc=masami.hiramatsu@linaro.org \
--cc=peng.fan@nxp.com \
--cc=peng.ma@nxp.com \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox