From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2561FC433F5 for ; Thu, 10 Feb 2022 21:20:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3601F836D3; Thu, 10 Feb 2022 22:20:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 86D87836A9; Thu, 10 Feb 2022 22:20:35 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 40891836A9 for ; Thu, 10 Feb 2022 22:20:32 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 25F4CD6E; Thu, 10 Feb 2022 13:20:31 -0800 (PST) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 471353F70D; Thu, 10 Feb 2022 13:20:28 -0800 (PST) Date: Thu, 10 Feb 2022 21:19:57 +0000 From: Andre Przywara To: Jesse Taube Cc: Siarhei Siamashka , u-boot@lists.denx.de, jagan@amarulasolutions.com, hdegoede@redhat.com, sjg@chromium.org, icenowy@aosc.io, marek.behun@nic.cz, festevam@denx.de, narmstrong@baylibre.com, tharvey@gateworks.com, christianshewitt@gmail.com, pbrobinson@gmail.com, jernej.skrabec@gmail.com, hs@denx.de, samuel@sholland.org, arnaud.ferraris@gmail.com, giulio.benetti@benettiengineering.com, thirtythreeforty@gmail.com Subject: Re: [PATCH v1 1/3] mach-sunxi: Add boot device detection for SUNIV Message-ID: <20220210211957.78392ad5@slackpad.lan> In-Reply-To: <67bd2cd2-d531-9413-9974-dbfd67a149d6@gmail.com> References: <20220210043438.1706939-1-Mr.Bossman075@gmail.com> <20220210043438.1706939-2-Mr.Bossman075@gmail.com> <67bd2cd2-d531-9413-9974-dbfd67a149d6@gmail.com> Organization: Arm Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Thu, 10 Feb 2022 14:51:11 -0500 Jesse Taube wrote: > On 2/10/22 14:38, Siarhei Siamashka wrote: > > On Thu, Feb 10, 2022 at 6:35 AM Jesse Taube wrote: > > [...] > >> + case SUNIV_BOOTED_FROM_NAND: > >> + case SUNIV_BOOTED_FROM_SPI: > >> + return BOOT_DEVICE_SPI; > > > > Is it really okay to lump SPI and NAND together and return > > BOOT_DEVICE_SPI for both? > Booting from SPI NAND. > I can change it to BOOT_DEVICE_NAND. Ah, sorry, I missed that. So SPI NAND is different from both SPI NOR and parallel NAND, and we just don't support it (yet). So just bail out in this case, ideally with a message. Cheers, Andre > > What's the NAND support story on this device? > I thought BOOT_DEVICE_NAND was for parallel NAND but I may be wrong > could come one clarify please? > > Thanks, > Jesse Taube