From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Masami Hiramatsu <masami.hiramatsu@linaro.org>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Patrice Chotard <patrice.chotard@foss.st.com>,
Alexander Graf <agraf@csgraf.de>, Simon Glass <sjg@chromium.org>,
Bin Meng <bmeng.cn@gmail.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Jose Marinho <jose.marinho@arm.com>,
Grant Likely <grant.likely@arm.com>,
Tom Rini <trini@konsulko.com>,
Etienne Carriere <etienne.carriere@linaro.org>,
Sughosh Ganu <sughosh.ganu@linaro.org>,
Paul Liu <paul.liu@linaro.org>,
u-boot@lists.denx.de
Subject: Re: [PATCH v4 2/2] efi_loader: Reset system after CapsuleUpdate on disk
Date: Mon, 14 Feb 2022 10:06:21 +0900 [thread overview]
Message-ID: <20220214010621.GC39639@laputa> (raw)
In-Reply-To: <41b3551c-5223-a924-99a3-cd245baac51c@gmx.de>
On Sun, Feb 13, 2022 at 11:17:37AM +0100, Heinrich Schuchardt wrote:
> On 2/13/22 10:01, Heinrich Schuchardt wrote:
> > On 2/3/22 10:23, Masami Hiramatsu wrote:
> > > Add a cold reset soon after processing capsule update on disk.
> > > This is required in UEFI specification 2.9 Section 8.5.5
> > > "Delivery of Capsules via file on Mass Storage device" as;
> > >
> > > In all cases that a capsule is identified for processing the
> > > system is
> > > restarted after capsule processing is completed.
> > >
> > > This also reports the result of each capsule update so that the user can
> > > notice that the capsule update has been succeeded or not from console
> > > log.
> > >
> > > Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
> >
> > Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>
>
> Gitlab CI tests fail. Please, resubmit with the Python tests adjusted.
> Make sure that 'make tests' does not fail.
>
> https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/392345
>
> FAILED
> test/py/tests/test_efi_capsule/test_capsule_firmware.py::TestEfiCapsuleFirmwareFit::test_efi_capsule_fw2
> FAILED
> test/py/tests/test_efi_capsule/test_capsule_firmware.py::TestEfiCapsuleFirmwareFit::test_efi_capsule_fw3
> FAILED
> test/py/tests/test_efi_capsule/test_capsule_firmware.py::TestEfiCapsuleFirmwareFit::test_efi_capsule_fw4
I should have mentioned this in my previous comment.
My capsule tests assume that the capsule update does *not* initiate
a reboot automatically and does "reboot" by "env print -e Capsule0000".
Furthermore, since the current sandbox_defconfig does not enable any
U-Boot environment storage, "dfu_alt_info," for instance, cannot
retain across the reboot (and so I didn't use CAPSULE_ON_DISK_EARLY).
I will help Masami fix the issue.
-Takahiro Akashi
> Best regards
>
> Heinrich
>
>
> Best regards
>
> Heinrich
next prev parent reply other threads:[~2022-02-14 1:06 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 9:23 [PATCH v4 0/2] EFI: Reset system after capsule-on-disk Masami Hiramatsu
2022-02-03 9:23 ` [PATCH v4 1/2] efi_loader: use efi_update_capsule_firmware() for capsule on disk Masami Hiramatsu
2022-02-13 8:58 ` Heinrich Schuchardt
2022-02-03 9:23 ` [PATCH v4 2/2] efi_loader: Reset system after CapsuleUpdate " Masami Hiramatsu
2022-02-09 3:13 ` AKASHI Takahiro
2022-02-09 3:54 ` Masami Hiramatsu
2022-02-13 9:01 ` Heinrich Schuchardt
2022-02-13 10:17 ` Heinrich Schuchardt
2022-02-14 1:06 ` AKASHI Takahiro [this message]
2022-02-14 2:39 ` Masami Hiramatsu
2022-02-15 9:05 ` [PATCH] test/py: efi_capsule: Handle expected reset after capsule " Masami Hiramatsu
2022-02-15 9:09 ` Masami Hiramatsu
2022-02-15 13:51 ` Heinrich Schuchardt
2022-02-15 13:52 ` Heinrich Schuchardt
2022-02-15 14:15 ` Heinrich Schuchardt
2022-02-15 23:50 ` Masami Hiramatsu
2022-02-16 1:34 ` AKASHI Takahiro
2022-02-16 1:46 ` Masami Hiramatsu
2022-02-16 15:26 ` Simon Glass
2022-02-16 15:32 ` Heinrich Schuchardt
2022-02-16 15:46 ` Tom Rini
2022-02-16 17:45 ` Heinrich Schuchardt
2022-02-16 17:51 ` Tom Rini
2022-02-16 17:52 ` Simon Glass
2022-02-17 1:11 ` Masami Hiramatsu
2022-02-17 17:55 ` Simon Glass
2022-02-18 2:16 ` Masami Hiramatsu
2022-02-18 13:48 ` Heinrich Schuchardt
2022-02-19 1:15 ` AKASHI Takahiro
2022-03-12 2:24 ` Simon Glass
2022-03-13 14:00 ` Masami Hiramatsu
2022-03-13 22:23 ` Simon Glass
2022-03-14 1:08 ` AKASHI Takahiro
2022-03-14 2:15 ` Simon Glass
2022-03-14 2:42 ` AKASHI Takahiro
2022-03-14 6:45 ` Simon Glass
2022-03-14 7:35 ` Masami Hiramatsu
2022-03-14 8:03 ` AKASHI Takahiro
2022-03-14 18:24 ` Simon Glass
2022-03-15 0:40 ` Masami Hiramatsu
2022-03-15 5:02 ` AKASHI Takahiro
2022-03-15 5:04 ` Simon Glass
2022-03-15 8:36 ` Masami Hiramatsu
2022-03-16 3:13 ` Simon Glass
2022-03-16 3:26 ` AKASHI Takahiro
2022-03-16 6:09 ` Masami Hiramatsu
2022-03-16 19:23 ` Simon Glass
2022-03-16 20:41 ` Heinrich Schuchardt
2022-03-17 0:29 ` Simon Glass
2022-02-18 13:59 ` Heinrich Schuchardt
2022-02-18 14:11 ` Tom Rini
2022-02-19 4:18 ` Masami Hiramatsu
2022-02-18 16:50 ` Tom Rini
2022-02-16 17:46 ` Simon Glass
2022-02-26 18:37 ` [PATCH v4 2/2] efi_loader: Reset system after CapsuleUpdate " Simon Glass
2022-02-28 4:19 ` Masami Hiramatsu
2022-02-28 7:53 ` Masami Hiramatsu
2022-03-01 14:58 ` Simon Glass
2022-03-02 1:58 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220214010621.GC39639@laputa \
--to=takahiro.akashi@linaro.org \
--cc=agraf@csgraf.de \
--cc=bmeng.cn@gmail.com \
--cc=etienne.carriere@linaro.org \
--cc=grant.likely@arm.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jose.marinho@arm.com \
--cc=masami.hiramatsu@linaro.org \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=paul.liu@linaro.org \
--cc=sjg@chromium.org \
--cc=sughosh.ganu@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox