From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86F54C433F5 for ; Mon, 14 Feb 2022 01:06:36 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0EC3983BC7; Mon, 14 Feb 2022 02:06:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="Al+MzRqa"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 93CA683B85; Mon, 14 Feb 2022 02:06:32 +0100 (CET) Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E07D283B85 for ; Mon, 14 Feb 2022 02:06:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pj1-x1031.google.com with SMTP id ki18-20020a17090ae91200b001b8be87e9abso8435879pjb.1 for ; Sun, 13 Feb 2022 17:06:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=orJIO88fONUeGtwrCr22NwGXiNWr9C57Dsy5FrmC+fQ=; b=Al+MzRqaWdrbW0gwUEvTFNxEe9uOvCR62y5Yyjdd4aVxbJofW1qZ44fkmSOidOXvVq B2Mp0JEhtGWokTJ2n12M/S39PaaZAAYvofxmwPcgwfQfLYkmDCXVydYNRmD71Nx1vpLq 6TegLQIPGmw5OlVERotFyUk8vvYTkkiuw+VIn2Pb4wFT6UXLnmKoJLBe9zdCHqSR2nG7 NehPfNmskEcbnlJHBoGxNxOvp3zGVzjdBkulNLsyp/rd8gKfSeLGsXT3JC5XdBo3C5sU aPUzm/beEDY8BViPb/ENPErdDbnvAjQ30CZ83ZTGdLCmmJi82IJp06cWug1jarFHSmeo icCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=orJIO88fONUeGtwrCr22NwGXiNWr9C57Dsy5FrmC+fQ=; b=RBESMaMg07WUD44M24t6qneNmrBzkk/fhmD+ZJnkAJMvWSGQxtCRBwMOCZldWUd4q6 e3nceONJ6zsuXtGlgPhkDQCtvS/ZsMD4BNhKygWzJAa9Qw/RLb7Dn2T5umWwDL4R/2lC cmnJz9kHHSeGCcMlVbgvWNzOUniSR048XShM1D9EPSAwAjCDlf2Xov/OjOuF33oGgX4L 6LVtg3PLOQTwzRm/bfk+74ABZNvl7MRizR6nDmFaJM+96m0RwPKwyiTAMQO4UL00IH+o jPPbaDxAvURqtp26e3K2Qq0UPOFvLUY6DVhxI9px9U6ocqsISFH9u7Mk1UyEYVpskctq agSA== X-Gm-Message-State: AOAM530Rs/XRUKR8uQUgUjIHGNRe5BR4811xdbH5U8ju5xTml+P1FL5i a8ewOtFfbcmY07zE7GFC9ylC6A== X-Google-Smtp-Source: ABdhPJzo6ZPUHhUI31xW6SxcUbI2J1w1rzK160eN+tEiQ9zE+g/WwO/UmTrEJVkWHYU7avL3+oOXKA== X-Received: by 2002:a17:90b:4b0c:: with SMTP id lx12mr2849840pjb.128.1644800787376; Sun, 13 Feb 2022 17:06:27 -0800 (PST) Received: from laputa ([2400:4050:c3e1:100:c11:cd20:ca66:ba1d]) by smtp.gmail.com with ESMTPSA id 13sm33367728pfm.161.2022.02.13.17.06.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Feb 2022 17:06:27 -0800 (PST) Date: Mon, 14 Feb 2022 10:06:21 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: Masami Hiramatsu , Patrick Delaunay , Patrice Chotard , Alexander Graf , Simon Glass , Bin Meng , Ilias Apalodimas , Jose Marinho , Grant Likely , Tom Rini , Etienne Carriere , Sughosh Ganu , Paul Liu , u-boot@lists.denx.de Subject: Re: [PATCH v4 2/2] efi_loader: Reset system after CapsuleUpdate on disk Message-ID: <20220214010621.GC39639@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , Masami Hiramatsu , Patrick Delaunay , Patrice Chotard , Alexander Graf , Simon Glass , Bin Meng , Ilias Apalodimas , Jose Marinho , Grant Likely , Tom Rini , Etienne Carriere , Sughosh Ganu , Paul Liu , u-boot@lists.denx.de References: <164388018493.446835.11931101380744085380.stgit@localhost> <164388020701.446835.322529861013544459.stgit@localhost> <41b3551c-5223-a924-99a3-cd245baac51c@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <41b3551c-5223-a924-99a3-cd245baac51c@gmx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Sun, Feb 13, 2022 at 11:17:37AM +0100, Heinrich Schuchardt wrote: > On 2/13/22 10:01, Heinrich Schuchardt wrote: > > On 2/3/22 10:23, Masami Hiramatsu wrote: > > > Add a cold reset soon after processing capsule update on disk. > > > This is required in UEFI specification 2.9 Section 8.5.5 > > > "Delivery of Capsules via file on Mass Storage device" as; > > > > > >      In all cases that a capsule is identified for processing the > > > system is > > >      restarted after capsule processing is completed. > > > > > > This also reports the result of each capsule update so that the user can > > > notice that the capsule update has been succeeded or not from console > > > log. > > > > > > Signed-off-by: Masami Hiramatsu > > > > Reviewed-by: Heinrich Schuchardt > > > Gitlab CI tests fail. Please, resubmit with the Python tests adjusted. > Make sure that 'make tests' does not fail. > > https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/392345 > > FAILED > test/py/tests/test_efi_capsule/test_capsule_firmware.py::TestEfiCapsuleFirmwareFit::test_efi_capsule_fw2 > FAILED > test/py/tests/test_efi_capsule/test_capsule_firmware.py::TestEfiCapsuleFirmwareFit::test_efi_capsule_fw3 > FAILED > test/py/tests/test_efi_capsule/test_capsule_firmware.py::TestEfiCapsuleFirmwareFit::test_efi_capsule_fw4 I should have mentioned this in my previous comment. My capsule tests assume that the capsule update does *not* initiate a reboot automatically and does "reboot" by "env print -e Capsule0000". Furthermore, since the current sandbox_defconfig does not enable any U-Boot environment storage, "dfu_alt_info," for instance, cannot retain across the reboot (and so I didn't use CAPSULE_ON_DISK_EARLY). I will help Masami fix the issue. -Takahiro Akashi > Best regards > > Heinrich > > > Best regards > > Heinrich