From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EA09C433EF for ; Tue, 15 Feb 2022 12:11:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B2B15839F5; Tue, 15 Feb 2022 13:11:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=nic.cz header.i=@nic.cz header.b="E8R18DMN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9A227839F5; Tue, 15 Feb 2022 13:11:29 +0100 (CET) Received: from mail.nic.cz (mail.nic.cz [217.31.204.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6409C832DB for ; Tue, 15 Feb 2022 13:11:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from dellmb (unknown [IPv6:2001:1488:fffe:6:8747:7254:5571:3010]) by mail.nic.cz (Postfix) with ESMTPSA id F01141409CF; Tue, 15 Feb 2022 13:11:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1644927086; bh=kFW21UyGhNNoDjlcOyaJUQ3pCbvqy5RjiIxciYCF+kU=; h=Date:From:To; b=E8R18DMNxoiIwdQIKu4yn6nYwDe+XHa41ZpaAdThZBJskuXuZ65LMUn1oNegQIHi7 J7MVFdMcmLbO1BqT94MfzbQ8Z7oeuTwF0AAR+0sx78C1rXQYNS4vYQKM08O//p5dGW bZ5SoD/vCYkvGl3IuKI+xFEicgn2bqy24F0U59DE= Date: Tue, 15 Feb 2022 13:11:25 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Stefan Roese , u-boot@lists.denx.de Subject: Re: [PATCH u-boot-mvebu 2/3] arm: mvebu: a37xx: Map CCI-400 and AP BootROM address space Message-ID: <20220215131125.27598730@dellmb> In-Reply-To: <20220214232835.12924-3-pali@kernel.org> References: <20220214232835.12924-1-pali@kernel.org> <20220214232835.12924-3-pali@kernel.org> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Tue, 15 Feb 2022 00:28:34 +0100 Pali Roh=C3=A1r wrote: > In function build_mem_map() prepares also mapping for CCI-400 and * prepare > AP BootROM address space. >=20 > A53 AP BootROM by default starts at address 0xfff00000 and is 16 kB long. RVBAR_EL3 register has value 0xffff0000. The BootROM is 16 KiB long but the window is 1 MiB long, so the content repeats every 4 KiB. > CCI-400 in new TF-A version starts at address 0xfe000000 and is 64 kB lon= g. >=20 > Physical addresses are read directly from mvebu registers, so if TF-A > remaps it in future then it would not cause any issue. As we talked about in private conversation, I still don't think we should do this unless it is needed. CCI may be needed to be mapped if ever there is some driver that needs to interact with it. BootROM is never needed by the U-Boot code. I really don't think that we should map these in production U-Boot binaries for everyone, when the intention is "for debugging purposes only". In the last 4 years there were 2 people (me, and you :)) who were interested in BootROM. In the next 10 years there will be maybe 2 more. So I really don't think the windows should be mapped for everyone. Maybe you can map them if some debug option is enabled in menuconfig? Marek