public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Felix Brack <fb@ltec.ch>
To: u-boot@lists.denx.de
Cc: Simon Glass <sjg@chromium.org>, Felix Brack <fb@ltec.ch>,
	Tom Rini <trini@konsulko.com>
Subject: [PATCH] arm: pdu001: Fix early debugging UART
Date: Tue, 15 Feb 2022 15:27:23 +0100	[thread overview]
Message-ID: <20220215142723.45242-1-fb@ltec.ch> (raw)

The changes from commit 0dba45864b2a ("arm: Init the debug UART")
prevent the early debug UART from being initialized correctly.
To fix this we not just configure the pin multiplexer but add setting up
early clocks.

Signed-off-by: Felix Brack <fb@ltec.ch>
---

 board/eets/pdu001/Makefile | 6 +-----
 board/eets/pdu001/board.c  | 2 ++
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/board/eets/pdu001/Makefile b/board/eets/pdu001/Makefile
index a5990ce3ad..35ea3978fe 100644
--- a/board/eets/pdu001/Makefile
+++ b/board/eets/pdu001/Makefile
@@ -6,8 +6,4 @@
 # SPDX-License-Identifier: GPL-2.0+
 #
 
-ifeq ($(CONFIG_$(SPL_)SKIP_LOWLEVEL_INIT),)
-obj-y	:= mux.o
-endif
-
-obj-y	+= board.o
+obj-y	:= board.o mux.o
diff --git a/board/eets/pdu001/board.c b/board/eets/pdu001/board.c
index 9f3cfd4f84..8612c09d40 100644
--- a/board/eets/pdu001/board.c
+++ b/board/eets/pdu001/board.c
@@ -240,6 +240,8 @@ void sdram_init(void)
 #ifdef CONFIG_DEBUG_UART
 void board_debug_uart_init(void)
 {
+	setup_early_clocks();
+
 	/* done by pin controller driver if not debugging */
 	enable_uart_pin_mux(CONFIG_DEBUG_UART_BASE);
 }
-- 
2.25.1


             reply	other threads:[~2022-02-15 14:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-15 14:27 Felix Brack [this message]
2022-02-15 19:30 ` [PATCH] arm: pdu001: Fix early debugging UART Tom Rini
2022-02-23 22:59 ` Simon Glass
2022-02-28 20:46 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220215142723.45242-1-fb@ltec.ch \
    --to=fb@ltec.ch \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox