From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CADB9C433EF for ; Wed, 16 Feb 2022 13:27:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 23C8683A35; Wed, 16 Feb 2022 14:27:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="qEEkONdy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2309980820; Wed, 16 Feb 2022 14:27:16 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 25E6083A41 for ; Wed, 16 Feb 2022 14:27:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kabel@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5739061703; Wed, 16 Feb 2022 13:27:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58A1FC004E1; Wed, 16 Feb 2022 13:27:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645018023; bh=OL96dIsbVSc7+Wk5dUDpR4YFwsvkQdcoN7m0gs4QhUg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qEEkONdyt34XGGjkqxUvSenzIyW0mmwzR98jfGlbyeBgNnXd9zDmJmIb/Ua+T7xkx uk0SHHvgEfR6dxK5anOSfDmi1nQy56m8nku9EC/LCAs1+r2RpxgVH/9Athp+m3A04K aYWrPc0SSRGBNzcfP8r0k/7PpsQLnCqCYBzMQy9JT1kwOHyZqydxlxDg56ymX3idPx +Xl63GmTot+8XtOgn3AXuS6UI3J+U/HFuRkhp3gFSS115cJT6tTbv39ThcD5dFHzdm 6uF8TFZh3GZxBLqtKeut1T8OodGNLQe9GIeG2oYMhs0smmgJJyhFAhMIhmrD0t4bJH yz9nxIraMryFA== Date: Wed, 16 Feb 2022 14:26:58 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Stefan Roese Cc: Chris Packham , "u-boot@lists.denx.de" , Mario Six , Dennis Gilmore , Marek =?UTF-8?B?QmVow7pu?= Subject: Re: [PATCH u-boot-marvell RFC] PLEASE TEST: ddr: marvell: a38x: fix BYTE_HOMOGENEOUS_SPLIT_OUT decision Message-ID: <20220216142658.428ffc89@dellmb> In-Reply-To: <2b25f4a4-aca1-a4cd-283b-7d8f5f63c4d1@denx.de> References: <20220210162517.8485-1-kabel@kernel.org> <2b25f4a4-aca1-a4cd-283b-7d8f5f63c4d1@denx.de> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Wed, 16 Feb 2022 09:41:44 +0100 Stefan Roese wrote: > On 2/15/22 23:21, Chris Packham wrote: > > On Fri, Feb 11, 2022 at 5:25 AM Marek Beh=C3=BAn wro= te: =20 > >> > >> From: Marek Beh=C3=BAn > >> > >> In commit 3fc92a215b69 ("ddr: marvell: a38x: fix SPLIT_OUT_MIX state > >> decision") I ported a cleaned up and changed version of patch > >> mv_ddr: a380: fix SPLIT_OUT_MIX state decision > >> > >> In the port we removed checking for BYTE_HOMOGENEOUS_SPLIT_OUT bit, > >> because: > >> - the fix seemed to work without it > >> - the bit was checked for only at one place out of two, while the seco= nd > >> bit, BYTE_SPLIT_OUT_MIX, was checked for in both cases > >> - without the removal it didn't work on Allied Telesis' x530 board > >> > >> We recently had a chance to test on more boards, and it seems that the > >> change needs to be opposite: instead of removing the check for > >> BYTE_HOMOGENEOUS_SPLIT_OUT from the first if() statement, the check > >> needs to be added also to the second one - it needs to be at both > >> places. > >> > >> With this change all the Turris Omnia boards I have had available to > >> test seem to work, I didn't encounter not even one failed DDR training. > >> > >> As last time, I am noting that I do not understand what this code is > >> actually doing, I haven't studied the DDR training algorithm and > >> I suspect that no one will be able to explain it to U-Boot contributor= s, > >> so we are left with this blind poking in the code with testing whether > >> it works on several boards and hoping it doesn't break anything for > >> anyone :-(. > >> > >> Signed-off-by: Marek Beh=C3=BAn =20 > >=20 > > Tested-by: Chris Packham =20 >=20 > Reviewed-by: Stefan Roese Dear Stefan, will you apply this (removing the PLEASE TEST: prefix) or should I send it again without it? I am going to send another patch which will reset the board immediately if DDR training fails, so I can send with that one. Marek