Re: [PATCH] WIP: Nokia RX-51: Convert to CONFIG_DM_VIDEO

[Anatolij Gustschin <agust@denx.de>]

Hi Pali,

On Wed, 16 Feb 2022 21:42:19 +0100
Pali Rohár pali@kernel.org wrote:

> ---
> I had to comment "return -ENOSPC;" in video-uclass.c because without it
> DM_VIDEO does not work and I do not know why. This looks like either
> false-positive test or a bug in DM_VIDEO code. I have already set
> PRE_RELOC flag but it has no effect on that code.

Probably the frame buffer memory allocation did not work. 
Could you please try with a bind callback, i.e.:

static int rx51_video_bind(struct udevice *dev)
{
	struct video_uc_plat *plat = dev_get_uclass_plat(dev);

	plat->size = 800 * 480 * 2;
	return 0;
}
...
U_BOOT_DRIVER(rx51_video) = {
	.name = "rx51_video",
	.id = UCLASS_VIDEO,
	.bind = rx51_video_bind,
	.probe = rx51_video_probe,
	.flags = DM_FLAG_PRE_RELOC,
};

> 
> Second thing is that CONFIG_VIDEO_LOGO is broken and does not work even it
> is enabled in config file. I do not know why too.
> 
> Any idea?

Not yet. There were some logo related changes recently, but if I
remember correctly, I tested them on wandboard and nitrogen6q
targets and with sandbox, and logo drawing worked there.

--
Anatolij