Re: [PATCH u-boot-mvebu 1/5] arm: mvebu: a37xx: Add support for reading NB and SB fuse OTP value

["Marek Behún" <marek.behun@nic.cz>]

On Thu, 17 Feb 2022 10:26:15 +0100
Pali Rohár <pali@kernel.org> wrote:

> Implement it via U-Boot fuse API.

nitpick: In commit messages I prefer not to refer to commit title, i.e.
instead of
  Implement it via U-Boot fuse API.
I would write
  Implement reading NB and SB fuses of Armada 37xx SOC via U-Boot fuse
  API.
as the first sentence.

> 
> Banks 0-43 are reserved for accessing Security OTP (not implemented yet).
> Bank 44 is used for accessing North Bridge OTP (69 bits via words 0-2).
> Bank 45 is used for accessing South Bridge OTP (97 bits via words 0-3).
> 
> Write support is not implemented yet as it looks like that both North
                                       ^because/since
> and South Bridge OTPs are already burned in factory with some data. Meaning
                                                                      ^The
                                                                       meaning
> of some bits of North Bridge are documented in WTMI source code. Meaning of
                               ^is (or meaningS are)               ^The
                                                                    meaning
                                                                    of
> bits in South Bridge is unknown.

Otherwise

Reviewed-by: Marek Behún <marek.behun@nic.cz>