From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: u-boot@lists.denx.de, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH 1/1] tools: mkefitools: remove duplicate test
Date: Sat, 19 Feb 2022 09:55:56 +0900 [thread overview]
Message-ID: <20220219005556.GA6672@laputa> (raw)
In-Reply-To: <20220218202633.91577-1-heinrich.schuchardt@canonical.com>
I have already fixed it.
https://lists.denx.de/pipermail/u-boot/2022-February/475391.html
-Takahiro Akashi
On Fri, Feb 18, 2022 at 09:26:33PM +0100, Heinrich Schuchardt wrote:
> This resolves Coverity CID 348360.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> tools/mkeficapsule.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/mkeficapsule.c b/tools/mkeficapsule.c
> index f7590e482f..c118335b93 100644
> --- a/tools/mkeficapsule.c
> +++ b/tools/mkeficapsule.c
> @@ -210,8 +210,6 @@ static int create_auth_data(struct auth_context *ctx)
> cert.size = file_size;
>
> ret = read_bin_file(ctx->key_file, &key.data, &file_size);
> - if (ret < 0)
> - return -1;
> if (ret < 0)
> return -1;
> if (file_size > UINT_MAX)
> --
> 2.34.1
>
prev parent reply other threads:[~2022-02-19 0:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 20:26 [PATCH 1/1] tools: mkefitools: remove duplicate test Heinrich Schuchardt
2022-02-19 0:55 ` AKASHI Takahiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220219005556.GA6672@laputa \
--to=takahiro.akashi@linaro.org \
--cc=heinrich.schuchardt@canonical.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox