From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FCD1C433EF for ; Sat, 19 Feb 2022 00:56:12 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 97B0A83B9B; Sat, 19 Feb 2022 01:56:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="NXgNhw2Y"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0651383B9F; Sat, 19 Feb 2022 01:56:07 +0100 (CET) Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7EA4783B88 for ; Sat, 19 Feb 2022 01:56:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pf1-x42d.google.com with SMTP id y11so3657973pfa.6 for ; Fri, 18 Feb 2022 16:56:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=s0gNPnFqUVrnNL7obRIus9Lhk9qAbeSbAqTJSi+wSIs=; b=NXgNhw2YARezBJb70Fc5J2UFRr+HAG1tWQTezqfI2+l7OoCSdfXPvaq+C9TQOJnZip Vs1ABc5ith42rptXfVUB8F9NdGC9MplwP3bd/WoMPChFPEWq7UrpJtRu/xsxq8D6Vdpw WikC3dR50uvC7VdGiMF9GKO9zadNXXjeDa7mlANXNpJh5C1xbkoZjNisWlG+SqF4bq/Y r3bzVIQ3JjLBrkc+CSs5JaOhUDKUnnhxLi9QGLSxkzVGydnW8DGTV5wWqytQj1QqSUR+ mzJnD0Gpj6nnuJlGTLZHYtCLb/auEnWeJK667p6sDSbLdu7gzAXCaD6HDoWqBqBl1EMN PMEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=s0gNPnFqUVrnNL7obRIus9Lhk9qAbeSbAqTJSi+wSIs=; b=nqVPgEhnPWo0zFELkqIB/CYiOP8fbwkJe7gVJ+aJyB0IUj2JWvnvZcWPR2UvXE9ZDe LjGaPtk2mCngw9cJVX82YesizsBBpzTCQ2H2dWtUfUOZTuhv7yVbhZv3tfKL7MlkckNS XW3bKhq55HpPnuSawn4aSCIVZcMe/8Zfl+6imcCMTWv3qjRl7TAKUbFGgNY/tEUgQvQM qGm1QvZveRB8dowDWyNbrFum6VTe7T61PKgBRfinvq1lKL4wIezwHT67Wynx6eW38yjv SLAnMf1VuziONAoI+eUxAAnIW+4ek6XUu4bkje5a/JDi28m+r0kUiwRK/bNGCIZqLoxI NZmg== X-Gm-Message-State: AOAM533lt61uAiqtSyKBTbQedyeeIh4HYmFy/80v0Jb0sWbHybkzxyTa 9kfJfDujQywoFALYXbKMeIZcnA== X-Google-Smtp-Source: ABdhPJyB6rJ8ZlfvldDitQc/fS4GUJZRkyIuoiNkzEXW6vlTSL44dzobqNVcW2EnSHxNem0BVcqyIg== X-Received: by 2002:a63:2103:0:b0:36c:10db:5509 with SMTP id h3-20020a632103000000b0036c10db5509mr8055164pgh.348.1645232160495; Fri, 18 Feb 2022 16:56:00 -0800 (PST) Received: from laputa ([2400:4050:c3e1:100:ac97:9e25:a038:e389]) by smtp.gmail.com with ESMTPSA id 13sm3970875pfx.122.2022.02.18.16.55.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Feb 2022 16:56:00 -0800 (PST) Date: Sat, 19 Feb 2022 09:55:56 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: u-boot@lists.denx.de, Tom Rini Subject: Re: [PATCH 1/1] tools: mkefitools: remove duplicate test Message-ID: <20220219005556.GA6672@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , u-boot@lists.denx.de, Tom Rini References: <20220218202633.91577-1-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220218202633.91577-1-heinrich.schuchardt@canonical.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean I have already fixed it. https://lists.denx.de/pipermail/u-boot/2022-February/475391.html -Takahiro Akashi On Fri, Feb 18, 2022 at 09:26:33PM +0100, Heinrich Schuchardt wrote: > This resolves Coverity CID 348360. > > Signed-off-by: Heinrich Schuchardt > --- > tools/mkeficapsule.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/mkeficapsule.c b/tools/mkeficapsule.c > index f7590e482f..c118335b93 100644 > --- a/tools/mkeficapsule.c > +++ b/tools/mkeficapsule.c > @@ -210,8 +210,6 @@ static int create_auth_data(struct auth_context *ctx) > cert.size = file_size; > > ret = read_bin_file(ctx->key_file, &key.data, &file_size); > - if (ret < 0) > - return -1; > if (ret < 0) > return -1; > if (file_size > UINT_MAX) > -- > 2.34.1 >