* [PATCH 1/1] tools: mkefitools: remove duplicate test
@ 2022-02-18 20:26 Heinrich Schuchardt
2022-02-19 0:55 ` AKASHI Takahiro
0 siblings, 1 reply; 2+ messages in thread
From: Heinrich Schuchardt @ 2022-02-18 20:26 UTC (permalink / raw)
To: u-boot; +Cc: Tom Rini, AKASHI Takahiro, Heinrich Schuchardt
This resolves Coverity CID 348360.
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
tools/mkeficapsule.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/mkeficapsule.c b/tools/mkeficapsule.c
index f7590e482f..c118335b93 100644
--- a/tools/mkeficapsule.c
+++ b/tools/mkeficapsule.c
@@ -210,8 +210,6 @@ static int create_auth_data(struct auth_context *ctx)
cert.size = file_size;
ret = read_bin_file(ctx->key_file, &key.data, &file_size);
- if (ret < 0)
- return -1;
if (ret < 0)
return -1;
if (file_size > UINT_MAX)
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] tools: mkefitools: remove duplicate test
2022-02-18 20:26 [PATCH 1/1] tools: mkefitools: remove duplicate test Heinrich Schuchardt
@ 2022-02-19 0:55 ` AKASHI Takahiro
0 siblings, 0 replies; 2+ messages in thread
From: AKASHI Takahiro @ 2022-02-19 0:55 UTC (permalink / raw)
To: Heinrich Schuchardt; +Cc: u-boot, Tom Rini
I have already fixed it.
https://lists.denx.de/pipermail/u-boot/2022-February/475391.html
-Takahiro Akashi
On Fri, Feb 18, 2022 at 09:26:33PM +0100, Heinrich Schuchardt wrote:
> This resolves Coverity CID 348360.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> tools/mkeficapsule.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/mkeficapsule.c b/tools/mkeficapsule.c
> index f7590e482f..c118335b93 100644
> --- a/tools/mkeficapsule.c
> +++ b/tools/mkeficapsule.c
> @@ -210,8 +210,6 @@ static int create_auth_data(struct auth_context *ctx)
> cert.size = file_size;
>
> ret = read_bin_file(ctx->key_file, &key.data, &file_size);
> - if (ret < 0)
> - return -1;
> if (ret < 0)
> return -1;
> if (file_size > UINT_MAX)
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-19 0:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-18 20:26 [PATCH 1/1] tools: mkefitools: remove duplicate test Heinrich Schuchardt
2022-02-19 0:55 ` AKASHI Takahiro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox