Re: [PATCH] board: stemmy: Detect board variants and patch DTB

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]

On Sun, Feb 20, 2022 at 02:09:42AM +0100, Linus Walleij wrote:

> This patch scans the cmdline from the Samsung SBL (second stage
> bootloader) and stores the parameters board_id=N and lcdtype=N
> in order to augment the DTB for different board and LCD types.
> 
> We then add a custom command "stemmy_patch" that will inspect
> the DTB and patch it using the stored LCD type. At this point
> we know which product we are dealing with, so using the passed
> board_id we can also print the board variant for diagnostics.
> 
> We patch the Codina, Skomer and Kyle DTBs to use the right
> LCD type as passed in lcdtype from the SBL.
> 
> This also creates an infrastructure for handling any other
> Samsung U8500 board variants that may need a slightly augmented
> DTB.
> 
> Cc: Markuss Broks <markuss.broks@gmail.com>
> Cc: Stephan Gerhold <stephan@gerhold.net>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> This patch depends on the patch to abootimg.c that makes the
> abootimg command properly report the location of a DTB in the
> "second" area submitted earlier.
> 
> The patch refers to samsung,codina-tmo which is a device tree
> which is not yet in the upstream Linux kernel but it is on
> its way there.

My only real question / concern is why is this a command and not
board_fixup_fdt() ?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]